Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
Please do. I applied the patch to the 2.6.32 kernel by hand, and it loaded and detected the trackpad, but didn't seem to work. There were plenty of other issues with this machine, due to the lack of support for the new hardware. E.g. Radeon R600 requires at least 2.6.33, tg3 driver didn't support the bcrm network card, etc. I think maybe it's not really appropriate for a kernel that old to be running on this machine? cheers, Andy -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cahj+3c50m_1df6i23-y-rapmcqhqgmg01wl6dalp_apuntv...@mail.gmail.com
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
On Thu, Aug 11, 2011 at 02:27:09PM +0100, Andy Botting wrote: Please do. I applied the patch to the 2.6.32 kernel by hand, and it loaded and detected the trackpad, but didn't seem to work. There were plenty of other issues with this machine, due to the lack of support for the new hardware. E.g. Radeon R600 requires at least 2.6.33, tg3 driver didn't support the bcrm network card, etc. I think maybe it's not really appropriate for a kernel that old to be running on this machine? Sounds like it is not, so I'll just drop this patch from the to-apply queue. thanks, greg k-h -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110811141827.ga14...@suse.de
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
Andy has the hardware, or at least had access to the hardware back then. I have the hardware too now, but I don't have time to run the tests. This patch is fairly trivial - but I can test it some time in the next few days if needed. cheers, Andy -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cahj+3c7osttwxtqobsm6rhtjxvb3dnq6sadxaknvehkmkis...@mail.gmail.com
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
On Wed, Aug 10, 2011 at 08:45:09AM +0100, Andy Botting wrote: Andy has the hardware, or at least had access to the hardware back then. I have the hardware too now, but I don't have time to run the tests. This patch is fairly trivial - but I can test it some time in the next few days if needed. Please do. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110810145159.ga7...@suse.de
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
Jonathan Nieder wrote: commit 4d4cf23cdde2f8f9324f5684a7f349e182039529 upstream. Agh, that should have said From: Andy Botting a...@andybotting.com commit 47340bd9fefb57136da942b5aee0e85e959c upstream. which I assume you can grab with git cherry-pick -s. The diff was the right one, though. Sorry for the noise. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110809055611.gc3...@elie.gateway.2wire.net
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
On Tue, Aug 09, 2011 at 07:48:42AM +0200, Jonathan Nieder wrote: commit 4d4cf23cdde2f8f9324f5684a7f349e182039529 upstream. This patch add multitouch support for the MacBookPro8,1 and MacBookPro8,2 models. Signed-off-by: Andy Botting a...@andybotting.com Signed-off-by: Henrik Rydberg rydb...@euromail.se Acked-by: Jiri Kosina jkos...@suse.cz Signed-off-by: Dmitry Torokhov d...@mail.ru Signed-off-by: Jonathan Nieder jrnie...@gmail.com --- Julien BLACHE wrote[1]: The attached commit, taken from Dmitry Torokhov's input tree, adds input support for the MacBookPro8,* released in March 2011. Only build tested. Julien: have you tested[2] that the patch works correctly on top of v2.6.32.y? Greg: does this look like a reasonable candidate for application to the longterm/linux-2.6.32.y tree? Yes it does, if someone can verify that it works :) I'll be glad to apply it if someone can do that. thanks, greg k-h -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110809055110.ga3...@suse.de
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
Jonathan Nieder jrnie...@gmail.com wrote: Hi, The attached commit, taken from Dmitry Torokhov's input tree, adds input support for the MacBookPro8,* released in March 2011. Only build tested. Julien: have you tested[2] that the patch works correctly on top of v2.6.32.y? No; IIRC I was made aware of the patches with the mention that they do work, and then they went upstream. I went fishing for the patches on request from the kernel team. This patch only adds IDs to the drivers, there's no reason why it wouldn't work if it applies. JB. -- Julien BLACHE jbla...@debian.org | Debian, because code matters more Debian GNU/Linux Developer| http://www.debian.org Public key available on http://www.jblache.org - KeyID: FA1E 5292 GPG Fingerprint : CC1A 2FE4 76FE 444A CD23 A5CD 26E9 8AEA FA1E 5292 -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/8739ha35q6@sonic.technologeek.org
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
Julien BLACHE wrote: This patch only adds IDs to the drivers, there's no reason why it wouldn't work if it applies. Do you have (or know anyone who has) hardware to test? Of course the patch only enables the driver on that hardware, which is what it would be useful to test. :) Roughly speaking, working means (1) booting correctly (2) not regressing in working as an ordinary mouse (3) not regressing in suspend support and (4) behaving as advertised. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110809164621.gi22...@elie.gateway.2wire.net
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
Jonathan Nieder jrnie...@gmail.com wrote: This patch only adds IDs to the drivers, there's no reason why it wouldn't work if it applies. Do you have (or know anyone who has) hardware to test? Of course the patch only enables the driver on that hardware, which is what it would be useful to test. :) Andy has the hardware, or at least had access to the hardware back then. I have the hardware too now, but I don't have time to run the tests. Plus, it's really wasted time for this patch as far as I remember. JB. -- Julien BLACHE jbla...@debian.org | Debian, because code matters more Debian GNU/Linux Developer| http://www.debian.org Public key available on http://www.jblache.org - KeyID: FA1E 5292 GPG Fingerprint : CC1A 2FE4 76FE 444A CD23 A5CD 26E9 8AEA FA1E 5292 -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87y5z21plc@sonic.technologeek.org
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
Julien BLACHE wrote: Andy has the hardware, or at least had access to the hardware back then. I have the hardware too now, but I don't have time to run the tests. Kernel team: could we enable this and similar patches in s-p-u or a similar repository, perhaps with a NEWS entry explaining that they will be backed out before migrating to stable if there are no positive reports from testing? It seems like a common problem, and this way it would also be easier to find regressions for people not specifically testing the hardware in question. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110809171928.gk22...@elie.gateway.2wire.net
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
On Tue, Aug 09, 2011 at 07:19:29PM +0200, Jonathan Nieder wrote: Julien BLACHE wrote: Andy has the hardware, or at least had access to the hardware back then. I have the hardware too now, but I don't have time to run the tests. Kernel team: could we enable this and similar patches in s-p-u or a similar repository, perhaps with a NEWS entry explaining that they will be backed out before migrating to stable if there are no positive reports from testing? [...] I wouldn't bother with a NEWS entry; we add stuff like this in almost every stable update. Let's just do it. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110809212835.gi29...@decadent.org.uk
Bug#618006: [PATCH 2.6.32.y] Input: bcm5974 - add support for MacBookPro8
commit 4d4cf23cdde2f8f9324f5684a7f349e182039529 upstream.
This patch add multitouch support for the MacBookPro8,1 and
MacBookPro8,2 models.
Signed-off-by: Andy Botting a...@andybotting.com
Signed-off-by: Henrik Rydberg rydb...@euromail.se
Acked-by: Jiri Kosina jkos...@suse.cz
Signed-off-by: Dmitry Torokhov d...@mail.ru
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
---
Julien BLACHE wrote[1]:
The attached commit, taken from Dmitry Torokhov's input tree, adds
input support for the MacBookPro8,* released in March 2011.
Only build tested.
Julien: have you tested[2] that the patch works correctly on top of
v2.6.32.y?
Greg: does this look like a reasonable candidate for application to
the longterm/linux-2.6.32.y tree?
Thanks, and sorry for a slow reply,
Jonathan
[1] http://bugs.debian.org/618006
[2] e.g., as described at
http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s4.2.2
drivers/hid/hid-apple.c |6 ++
drivers/hid/hid-core.c|6 ++
drivers/hid/hid-ids.h |3 +++
drivers/input/mouse/bcm5974.c | 20
4 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 5f38014e..7afa6a6b 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -469,6 +469,12 @@ static const struct hid_device_id apple_devices[] = {
.driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS),
.driver_data = APPLE_HAS_FN | APPLE_RDESC_JIS },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_ANSI),
+ .driver_data = APPLE_HAS_FN },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_ISO),
+ .driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_JIS),
+ .driver_data = APPLE_HAS_FN | APPLE_RDESC_JIS },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ANSI),
.driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO),
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index f3f14159..9cc4cea0 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1293,6 +1293,9 @@ static const struct hid_device_id hid_blacklist[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING4A_ANSI) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING4A_ISO) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_ANSI) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_ISO) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_JIS) },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ANSI) },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO) },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_JIS) },
@@ -1717,6 +1720,9 @@ static const struct hid_device_id hid_mouse_ignore_list[]
= {
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING4A_ANSI) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING4A_ISO) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_ANSI) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_ISO) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_WELLSPRING5_JIS) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE,
USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) },
{ }
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index aef92bbe..93d2da3c 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -94,6 +94,9 @@
#define USB_DEVICE_ID_APPLE_WELLSPRING4A_ANSI 0x0242
#define USB_DEVICE_ID_APPLE_WELLSPRING4A_ISO 0x0243
#define USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS 0x0244
+#define USB_DEVICE_ID_APPLE_WELLSPRING5_ANSI 0x0245
+#define USB_DEVICE_ID_APPLE_WELLSPRING5_ISO0x0246
+#define USB_DEVICE_ID_APPLE_WELLSPRING5_JIS0x0247
#define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ANSI 0x0239
#define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO 0x023a
#define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_JIS 0x023b
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index bbedd57c..d6ad4418 100644
--- a/drivers/input/mouse/bcm5974.c
+++
