Bug#846597: linux: please enable `perf data' support

[Sebastian Andrzej Siewior]

On 2017-01-26 16:36:45 [+0100], Hector Oron wrote:
> Hello,
Hi,

> On Fri, Dec 02, 2016 at 02:37:21PM +0100, Sebastian Andrzej Siewior wrote:
> > diff --git a/debian/templates/control.source.in 
> > b/debian/templates/control.source.in
> > index 08969a3da9d9..2a1fdf048823 100644
> > --- a/debian/templates/control.source.in
> > +++ b/debian/templates/control.source.in
> > @@ -41,6 +41,8 @@ Standards-Version: 3.9.8
> >   libperl-dev ,
> >   libunwind8-dev [amd64 armel armhf arm64 i386]  > !nopython>,
> >   python-dev ,
> > + libbabeltrace-dev ,
> > + libbabeltrace-ctf-dev ,
> 
> Out of curiosity,
> 
> The final patch that got merged has versioned depends on babeltrace >=1.5.0, 
> but
> Jessie has 1.2.3. While trying to do a linux kernel backport, I have come up
> with a question if we really need babeltrace >=1.5.0 or if 1.2.3 has the 
> needed
> features. Do you happen to know?

You need babeltrace >= 1.5.0 for perf-data to work and that was the
whole point of libbabeltrace.
If you don't care about perf-data you can drop that babeltrace
dependency (and not enable it later while building perf).
I am happy that the next stable will bring working perf-data
to Debian and I don't need it in backports (as it will introduce yet
another library).

> Note: In anycase, I am preparing a backport of babeltrace.
> 
> Regards

Sebastian

Bug#846597: linux: please enable `perf data' support

[Hector Oron]

Hello,

On Fri, Dec 02, 2016 at 02:37:21PM +0100, Sebastian Andrzej Siewior wrote:
> diff --git a/debian/templates/control.source.in 
> b/debian/templates/control.source.in
> index 08969a3da9d9..2a1fdf048823 100644
> --- a/debian/templates/control.source.in
> +++ b/debian/templates/control.source.in
> @@ -41,6 +41,8 @@ Standards-Version: 3.9.8
>   libperl-dev ,
>   libunwind8-dev [amd64 armel armhf arm64 i386]  !nopython>,
>   python-dev ,
> + libbabeltrace-dev ,
> + libbabeltrace-ctf-dev ,

Out of curiosity,

The final patch that got merged has versioned depends on babeltrace >=1.5.0, but
Jessie has 1.2.3. While trying to do a linux kernel backport, I have come up
with a question if we really need babeltrace >=1.5.0 or if 1.2.3 has the needed
features. Do you happen to know?

Note: In anycase, I am preparing a backport of babeltrace.

Regards

>  # used by upstream to build usbip
>   autoconf ,
>   automake ,
> -- 
> 2.10.2
> 


-- 
  Hector Oron


signature.asc
Description: PGP signature

Bug#846597: linux: please enable `perf data' support

[Sebastian Andrzej Siewior]

Package: src:linux
Version: 4.9~rc5-1~exp1
Severity: normal
Tags: patch

Please enable `perf data' support for perf. This requires two extra
dependencies which are already in debian in the required version. During
the invocation of make (for perf) you libbabeltrace needs to be
explicitly enabled. Upstream disabled it by default until more distros
ship a libbabeltrace with the requested functions (and Debian is the
first one).

All this can be found in the patch attached.

Sebastian
From: Sebastian Andrzej Siewior 
Date: Fri, 2 Dec 2016 13:09:45 +
Subject: [PATCH] perf: enable perf data support

Signed-off-by: Sebastian Andrzej Siewior 
---
 debian/rules.d/tools/perf/Makefile | 3 +++
 debian/templates/control.source.in | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/debian/rules.d/tools/perf/Makefile b/debian/rules.d/tools/perf/Makefile
index aa50e42efc3a..ec0c9e97486d 100644
--- a/debian/rules.d/tools/perf/Makefile
+++ b/debian/rules.d/tools/perf/Makefile
@@ -48,6 +48,9 @@ MAKE_PERF += feature-libbfd=0 HAVE_CPLUS_DEMANGLE_SUPPORT=1
 # an explicit exception.  Override detection of libcrypto.
 MAKE_PERF += NO_LIBCRYPTO=1
 
+# Currently babeltrace support for `perf data' is not automatically detected.
+MAKE_PERF += LIBBABELTRACE=1
+
 all:
 ifdef KERNEL_ARCH_PERF
 # perf changes some default directories depending on whether DESTDIR is
diff --git a/debian/templates/control.source.in b/debian/templates/control.source.in
index 08969a3da9d9..2a1fdf048823 100644
--- a/debian/templates/control.source.in
+++ b/debian/templates/control.source.in
@@ -41,6 +41,8 @@ Standards-Version: 3.9.8
  libperl-dev ,
  libunwind8-dev [amd64 armel armhf arm64 i386] ,
  python-dev ,
+ libbabeltrace-dev ,
+ libbabeltrace-ctf-dev ,
 # used by upstream to build usbip
  autoconf ,
  automake ,
-- 
2.10.2