Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-28 Thread Nicholas Piggin
On Thu, Nov 24, 2016 at 4:40 PM, Nicholas Piggin <npig...@gmail.com> wrote: > > > > > > > > > > Yes, manual "marking" is never going to be a viable solution. > > > > > > I guess it really depends on how exactly you want t

Bug#844530: [1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-21 Thread Nicholas Piggin
On Mon, 21 Nov 2016 19:13:55 + Russell King - ARM Linux wrote: > On Mon, Nov 21, 2016 at 07:46:44PM +0100, Uwe Kleine-König wrote: > > Hello, > > > > On Mon, Oct 24, 2016 at 05:05:26PM +0200, Arnd Bergmann wrote: > > > This adds an asm/asm-prototypes.h header for

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-09 Thread Nicholas Piggin
On Fri, 9 Dec 2016 08:55:51 +0100 Stanislav Kozina wrote: > >> The question is how to provide a similar guarantee if a different way? > > As a tool to aid distro reviewers, modversions has some value, but the > > debug info parsing tools that have been mentioned in this

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-09 Thread Nicholas Piggin
On Fri, 9 Dec 2016 15:36:04 +0100 Stanislav Kozina wrote: > The question is how to provide a similar guarantee if a different way? > >>> As a tool to aid distro reviewers, modversions has some value, but the > >>> debug info parsing tools that have been mentioned in

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-09 Thread Nicholas Piggin
On Fri, 09 Dec 2016 15:21:33 + Ian Campbell <i...@hellion.org.uk> wrote: > On Fri, 2016-12-09 at 13:33 +1000, Nicholas Piggin wrote: > >  > > Well I simply tested the outcome. If you have: > > > > struct blah { > >   int x; > > }; > > in

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-11 Thread Nicholas Piggin
On Sat, 10 Dec 2016 13:41:03 +0100 Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Fri, Dec 09, 2016 at 11:46:54PM +0100, Dodji Seketeli wrote: > > Hello, > > > > Nicholas Piggin <npig...@gmail.com> a écrit: > > > > [...] > >

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-12 Thread Nicholas Piggin
On Mon, 12 Dec 2016 10:48:47 +0100 Stanislav Kozina wrote: > A runtime check is still done, with per-module vermagic which distros > can change when they bump the ABI version. Is it really necessary to > have more than that (i.e., per-symbol versioning)? >

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Nicholas Piggin
On Wed, 14 Dec 2016 15:04:36 +0100 Hannes Frederic Sowa <han...@redhat.com> wrote: > On 09.12.2016 17:03, Greg Kroah-Hartman wrote: > > On Sat, Dec 10, 2016 at 01:56:53AM +1000, Nicholas Piggin wrote: > >> On Fri, 9 Dec 2016 15:36:04 +0100 > >> Stanislav

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-15 Thread Nicholas Piggin
On Thu, 15 Dec 2016 12:19:02 +0100 Hannes Frederic Sowa <han...@redhat.com> wrote: > On 15.12.2016 03:06, Nicholas Piggin wrote: > > On Wed, 14 Dec 2016 15:04:36 +0100 > > Hannes Frederic Sowa <han...@redhat.com> wrote: > > > >> On 09.12.2016 17:03

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-15 Thread Nicholas Piggin
On Thu, 15 Dec 2016 14:15:31 +0100 Hannes Frederic Sowa <han...@redhat.com> wrote: > On 15.12.2016 13:03, Nicholas Piggin wrote: > > On Thu, 15 Dec 2016 12:19:02 +0100 > > Hannes Frederic Sowa <han...@redhat.com> wrote: > > > >> On 15.12.2016 03:06,

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-08 Thread Nicholas Piggin
On Thu, 1 Dec 2016 17:12:41 +0100 Michal Marek <mma...@suse.com> wrote: > On 2016-12-01 04:39, Nicholas Piggin wrote: > > On Thu, 01 Dec 2016 02:35:54 + > > Ben Hutchings <b...@decadent.org.uk> wrote: > >> As I understand it, genksyms incorporates

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-08 Thread Nicholas Piggin
On Thu, 1 Dec 2016 10:20:39 -0500 Don Zickus <dzic...@redhat.com> wrote: > On Thu, Dec 01, 2016 at 03:32:15PM +1100, Nicholas Piggin wrote: > > > Anyway, MODVERSIONS is our way of protecting our kabi for the last 10 > > > years. > > > It isn't perfect and

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-30 Thread Nicholas Piggin
On Tue, 29 Nov 2016 12:35:57 -0800 Linus Torvalds wrote: > On Tue, Nov 29, 2016 at 11:57 AM, Ben Hutchings wrote: > > > > If the modversion is missing then the fallback should be to a full > > vermagic match, i.e. including the release

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-30 Thread Nicholas Piggin
On Wed, 30 Nov 2016 23:13:25 -0500 Don Zickus <dzic...@redhat.com> wrote: > On Wed, Nov 30, 2016 at 10:40:02AM -0800, Linus Torvalds wrote: > > On Wed, Nov 30, 2016 at 10:18 AM, Nicholas Piggin <npig...@gmail.com> > > wrote: > > > > > > Here's

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-30 Thread Nicholas Piggin
On Thu, 01 Dec 2016 02:35:54 + Ben Hutchings <b...@decadent.org.uk> wrote: > On Thu, 2016-12-01 at 12:55 +1100, Nicholas Piggin wrote: > > On Wed, 30 Nov 2016 21:33:01 + > > > Ben Hutchings <b...@decadent.org.uk> wrote: > > > > > On W

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-30 Thread Nicholas Piggin
On Wed, 30 Nov 2016 21:33:01 + Ben Hutchings <b...@decadent.org.uk> wrote: > On Wed, 2016-11-30 at 10:40 -0800, Linus Torvalds wrote: > > > On Wed, Nov 30, 2016 at 10:18 AM, Nicholas Piggin <npig...@gmail.com> > > > wrote: > > > > > > H

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Nicholas Piggin
On Thu, 1 Dec 2016 11:48:09 +0100 Stanislav Kozina wrote: > On 12/01/2016 05:13 AM, Don Zickus wrote: > > ... > > > I think GregKH pointed to one such tool, libabigail? We are working on > > others too. > > I should mention one of the others here: >

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Nicholas Piggin
On Thu, 1 Dec 2016 12:33:02 +0100 Stanislav Kozina <skoz...@redhat.com> wrote: > On 12/01/2016 12:09 PM, Nicholas Piggin wrote: > > On Thu, 1 Dec 2016 11:48:09 +0100 > > Stanislav Kozina <skoz...@redhat.com> wrote: > > > >> On 12/01/2016 05:13 AM, Don

Re: a bug in genksysms/CONFIG_MODVERSIONS w/ __attribute__((foo))?

2019-08-27 Thread Nicholas Piggin
Ben Hutchings's on August 28, 2019 1:34 am: > On Tue, 2019-08-27 at 22:42 +1000, Nicholas Piggin wrote: >> Masahiro Yamada's on August 27, 2019 8:49 pm: >> > Hi. >> > >> > On Tue, Aug 27, 2019 at 6:59 PM Nicholas Piggin wrote: >> > > Nick Desaulnie

Re: a bug in genksysms/CONFIG_MODVERSIONS w/ __attribute__((foo))?

2019-08-27 Thread Nicholas Piggin
Masahiro Yamada's on August 27, 2019 8:49 pm: > Hi. > > On Tue, Aug 27, 2019 at 6:59 PM Nicholas Piggin wrote: >> >> Nick Desaulniers's on August 27, 2019 8:57 am: >> > On Mon, Aug 26, 2019 at 2:22 PM Nick Desaulniers >> > wrote: >> >> >