Bug#1006500: marked as done (Missing bnx2x firmware 7.13.21.0 renders NIC unusable with Linux 5.16)

2022-10-29 Thread Christoph Anton Mitterer
On Sat, 2022-10-29 at 09:44 +0200, Salvatore Bonaccorso wrote:
> We do similar with intel-microcode updates, so maybe this is
> something
> we should consider to. But I think it's to early to think about a
> potential 20220913-1~deb11u1 via a bullseye point release.

It's just that for any bullseye users, this NICs are in principle
broken (at least out of the box) right now.

Anyway... I guess it's not super urgent :-)


Cheers,
Chris.



Bug#1006500: marked as done (Missing bnx2x firmware 7.13.21.0 renders NIC unusable with Linux 5.16)

2022-10-29 Thread Bastian Blank
On Sat, Oct 29, 2022 at 12:31:18AM +0200, Christoph Anton Mitterer wrote:
> Is this going to be backported to bullseye?

First is needs to settle a bit.

But as you can see, in the past we did produce backports:

| firmware-nonfree | 20210818-1~bpo11+1 | bullseye-backports/non-free | source

Bastian

-- 
Power is danger.
-- The Centurion, "Balance of Terror", stardate 1709.2



Bug#1006500: marked as done (Missing bnx2x firmware 7.13.21.0 renders NIC unusable with Linux 5.16)

2022-10-29 Thread Salvatore Bonaccorso
Hi,

On Sat, Oct 29, 2022 at 12:31:18AM +0200, Christoph Anton Mitterer wrote:
> Hey Bastian.
> 
> Thanks for fixing.
> 
> Is this going to be backported to bullseye?

We do similar with intel-microcode updates, so maybe this is something
we should consider to. But I think it's to early to think about a
potential 20220913-1~deb11u1 via a bullseye point release.

(just my personal opinion though).

Regards,
Salvatore



Bug#1006500: marked as done (Missing bnx2x firmware 7.13.21.0 renders NIC unusable with Linux 5.16)

2022-10-28 Thread Christoph Anton Mitterer
Hey Bastian.

Thanks for fixing.

Is this going to be backported to bullseye?

Thanks,
Chris.



Bug#1006500: marked as done (Missing bnx2x firmware 7.13.21.0 renders NIC unusable with Linux 5.16)

2022-10-28 Thread Debian Bug Tracking System
Your message dated Fri, 28 Oct 2022 19:20:40 +
with message-id 
and subject line Bug#1006500: fixed in firmware-nonfree 20220913-1
has caused the Debian Bug report #1006500,
regarding Missing bnx2x firmware 7.13.21.0 renders NIC unusable with Linux 5.16
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1006500: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1006500
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: firmware-bnx2x
Version: 20210818-1
Severity: grave

On Linux 5.16, the bnx2x module requests firmware 7.13.21.0:

# modinfo bnx2x
filename:
/lib/modules/5.16.0-2-amd64/kernel/drivers/net/ethernet/broadcom/bnx2x/bnx2x.ko
firmware:   bnx2x/bnx2x-e2-7.13.21.0.fw
firmware:   bnx2x/bnx2x-e1h-7.13.21.0.fw
firmware:   bnx2x/bnx2x-e1-7.13.21.0.fw

This firmware is not present in the firmware-bnx2x package.

Now, my understanding is that the bnx2x module can fall back to an
earlier version (7.13.15.0) as needed, but in practice that might not
actually help, because update-initramfs only looks for the firmware
version from the module information and doesn't include any other
version:

# update-initramfs -u
W: Possible missing firmware /lib/firmware/bnx2x/bnx2x-e2-7.13.21.0.fw
for module bnx2x
W: Possible missing firmware
/lib/firmware/bnx2x/bnx2x-e1h-7.13.21.0.fw for module bnx2x
W: Possible missing firmware /lib/firmware/bnx2x/bnx2x-e1-7.13.21.0.fw
for module bnx2x

Since no firmware is included in the initramfs, the bnx2x module
unsurprisingly fails to initialize on boot:

kernel: bnx2x :02:00.1: firmware: failed to load
bnx2x/bnx2x-e2-7.13.21.0.fw (-2)
kernel: bnx2x :02:00.1: Direct firmware load for
bnx2x/bnx2x-e2-7.13.21.0.fw failed with error -2
kernel: bnx2x :02:00.1: firmware: failed to load
bnx2x/bnx2x-e2-7.13.15.0.fw (-2)
kernel: bnx2x :02:00.1: Direct firmware load for
bnx2x/bnx2x-e2-7.13.15.0.fw failed with error -2

Adding insult to injury, it doesn't look like it's possible to recover
from this state - as far as I could tell, once bnx2x fails to
initialize, it's game over until the next reboot, even if the module
is unloaded and reloaded, and even if the PCI device is removed and
rescanned.

This basically means that, when booting current Debian Unstable with
Linux 5.16, bnx2x NICs become *permanently unusable*, potentially
locking users and admins out of the system.

My suggested short-term fix would be to update the firmware-bnx2x
package to include the 7.13.21.0 firmware version. There's also a
discussion to be had with regard to update-initramfs, which should
perhaps try harder to find potentially compatible firmware versions -
indeed, if update-initramfs had included 7.13.15.0, I believe this
issue would have been avoided.

For those affected, here's the workaround I used:

1. Manually download the 7.13.21.0 firmware files from
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/bnx2x
2. Put the files in /lib/firmware/bnx2x
3. Run update-initramfs -u
4. Reboot
--- End Message ---
--- Begin Message ---
Source: firmware-nonfree
Source-Version: 20220913-1
Done: Bastian Blank 

We believe that the bug you reported is fixed in the latest version of
firmware-nonfree, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1006...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Blank  (supplier of updated firmware-nonfree package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Format: 1.8
Date: Fri, 28 Oct 2022 20:48:14 +0200
Source: firmware-nonfree
Architecture: source
Version: 20220913-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Kernel Team 
Changed-By: Bastian Blank 
Closes: 999825 1006500 1006638 1009316 1009618 1014651 1015728 1016058 1019847 
1020962
Changes:
 firmware-nonfree (20220913-1) unstable; urgency=medium
 .
   * New upstream version (Closes: #1009316, #1015728)
   * Various new firmware for Intel hardware closes: #1014651, #1020962
   * amd-graphics: Various new firmware closes: #999825, #1019847
   * iwlwifi: Various new firmware closes: #1016058
 .
   [ Philippe Ombredanne ]
   * Update copyright with