Bug#1028565: Acknowledgement (upgrade-reports: Audio breaks between 5.10.0-19-amd64 and 5.10.0-20-amd64)
This audio issue was resolved for me with the SoC updates included in stable linux-image: 5.10.0-21-amd64 5.10.162-1 (2023-01-21) x86_64 For reference, my machine info: Product Name: 20QDCTO1WW Version: ThinkPad X1 Carbon 7th BIOS Version: N2HET68W (1.51) Audio PCI info: 00:1f.3 Audio device [0403]: Intel Corporation Cannon Point-LP High Definition Audio Controller [8086:9dc8] (rev 11) (prog-if 80) Thanks for this bug report, the build info and revert patch for -20, and for rolling in the additional SoC bits to make -21 work properly. Kind regards, Michael
Bug#1028565: Acknowledgement (upgrade-reports: Audio breaks between 5.10.0-19-amd64 and 5.10.0-20-amd64)
Hi Salvatore, Yes, I executed the steps in 4.2.1. These is what I did: ### sudo apt install build-essential fakeroot sudo apt build-dep linux sudo apt install devscripts sudo apt install linux-source-5.10 sudo apt source linux tar xaf /usr/src/linux-source-5.10.tar.xz cd linux-source-5.10 sudo apt install libncurses-dev make menuconfig make ### The first make resulted in the error make[1]: *** No rule to make target 'debian/certs/debian-uefi-certs.pem', needed by 'certs/x509_certificate_list'. Stop which I solved by following https://stackoverflow.com/questions/67530734/no-rule-to-make-target-when-compiling-linux-kernel-when-needed-by-certs-x509-cer Best regards, Markus On Thu, Jan 19, 2023 at 11:34 PM Salvatore Bonaccorso wrote: > > Hi Markus, > > On Thu, Jan 19, 2023 at 10:21:35PM +0100, Markus Kramer wrote: > > Hi Diederik, > > Thank you for > > 0001-Revert-ASoC-soc-pcm-Don-t-zero-TDM-masks-in-__soc_pc.patch > > > > Following chapter 4.2.2 of > > https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html > > > > $sudo apt-get install devscripts > > Reading package lists... Done > > Building dependency tree... Done > > Reading state information... Done > > devscripts is already the newest version (2.21.3+deb11u1). > > 0 upgraded, 0 newly installed, 0 to remove and 67 not upgraded. > > > > Next step would be to execute > > > > bash debian/bin/test-patches > > 0001-Revert-ASoC-soc-pcm-Don-t-zero-TDM-masks-in-__soc_pc.patch > > > > But there is no file test-patches on my client and googled in vain. > > How can I procure test-patches? > > Just to be sure, have you performed the steps preceding 4.2.2 and > fetched the source, in particular 4.2.1 pareparation? When you invoke > apt-get source linux, you will get the source package, unpacked it, > and changing with the next step into the source directory you will > find below debian/bin/test-patches. > > Hope this helps, > > Regards, > Salvatore
Bug#1028565: Acknowledgement (upgrade-reports: Audio breaks between 5.10.0-19-amd64 and 5.10.0-20-amd64)
Hi Markus, On Thu, Jan 19, 2023 at 10:21:35PM +0100, Markus Kramer wrote: > Hi Diederik, > Thank you for 0001-Revert-ASoC-soc-pcm-Don-t-zero-TDM-masks-in-__soc_pc.patch > > Following chapter 4.2.2 of > https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html > > $sudo apt-get install devscripts > Reading package lists... Done > Building dependency tree... Done > Reading state information... Done > devscripts is already the newest version (2.21.3+deb11u1). > 0 upgraded, 0 newly installed, 0 to remove and 67 not upgraded. > > Next step would be to execute > > bash debian/bin/test-patches > 0001-Revert-ASoC-soc-pcm-Don-t-zero-TDM-masks-in-__soc_pc.patch > > But there is no file test-patches on my client and googled in vain. > How can I procure test-patches? Just to be sure, have you performed the steps preceding 4.2.2 and fetched the source, in particular 4.2.1 pareparation? When you invoke apt-get source linux, you will get the source package, unpacked it, and changing with the next step into the source directory you will find below debian/bin/test-patches. Hope this helps, Regards, Salvatore
Bug#1028565: Acknowledgement (upgrade-reports: Audio breaks between 5.10.0-19-amd64 and 5.10.0-20-amd64)
Hi Diederik, Thank you for 0001-Revert-ASoC-soc-pcm-Don-t-zero-TDM-masks-in-__soc_pc.patch Following chapter 4.2.2 of https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html $sudo apt-get install devscripts Reading package lists... Done Building dependency tree... Done Reading state information... Done devscripts is already the newest version (2.21.3+deb11u1). 0 upgraded, 0 newly installed, 0 to remove and 67 not upgraded. Next step would be to execute bash debian/bin/test-patches 0001-Revert-ASoC-soc-pcm-Don-t-zero-TDM-masks-in-__soc_pc.patch But there is no file test-patches on my client and googled in vain. How can I procure test-patches? Best regards, Markus
Bug#1028565: Acknowledgement (upgrade-reports: Audio breaks between 5.10.0-19-amd64 and 5.10.0-20-amd64) Inbox
FTR: There is already an alternative fix committed in the Debian Kernel repo: https://salsa.debian.org/kernel-team/linux/-/commit/4a65ff78c6be9208bfc9232886a7a2d199ebcac7 So what I'll describe below is how you would do it. On Thursday, 19 January 2023 18:46:57 CET Markus Kramer wrote: > How do I boot from this kernel? Using dpkg -i arch/x86/boot/bzImage ? To use `dpkg -i` you'd need a .deb file (ie Debian package) > How could GRUB show this kernel as e.g. "before-patch", or will it > show the creation time? > > Where do I get the .patch file mentioned in > https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s4 > .2.2 ? The 'problematic' commit was c34db0d6b88b and we need a revert of that: diederik@prancing-pony:~/dev/kernel.org/linux$ git revert c34db0d6b88b Auto-merging sound/soc/soc-pcm.c [linux-5.10.y 3ed496982f55] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" 1 file changed, 5 insertions(+) diederik@prancing-pony:~/dev/kernel.org/linux$ git format-patch HEAD~1 -o ../patches/ ../patches/0001-Revert-ASoC-soc-pcm-Don-t-zero-TDM-masks-in-__soc_pc.patch And that's how you'd get the .patch file which I have attached as a convenience. If you then follow the procedure at #s4.2.2 and provide that patch file as an argument, it would build a .deb file of the patched kernel. That .deb file you can then install with `dpkg -i `. Currently, (unfortunately?), it would replace your existing 5.10.0-20-amd64 kernel and there is no (easy) way to see that you would be booting into your new patched kernel from GRUB. HTH, Diederik>From 3ed496982f556d17a87f830acaf5023d4f5d9a9b Mon Sep 17 00:00:00 2001 From: Diederik de Haas Date: Thu, 19 Jan 2023 18:32:38 +0100 Subject: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee. --- sound/soc/soc-pcm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index fb874f924bbe..9a60d62f12fe 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -723,6 +723,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream) ret = snd_soc_dai_startup(dai, substream); if (ret < 0) goto err; + + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) + dai->tx_mask = 0; + else + dai->rx_mask = 0; } /* Dynamic PCM DAI links compat checks use dynamic capabilities */ -- 2.39.0 signature.asc Description: This is a digitally signed message part.
Bug#1028565: Acknowledgement (upgrade-reports: Audio breaks between 5.10.0-19-amd64 and 5.10.0-20-amd64) Inbox
Resending because my email yesterday did not arrive at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028565 Hi, yesterday the `make` command ended without an error. When I run `make` again it returns CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool DESCEND bpf/resolve_btfids CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) $ ls -l arch/x86/boot/bzImage -rw-r--r-- 1 markus markus 6,7M 17. Jan 22:50 arch/x86/boot/bzImage $ file arch/x86/boot/bzImage arch/x86/boot/bzImage: Linux kernel x86 boot executable bzImage, version 5.10.158 (markus@debNXP) #1 SMP Sun Jan 15 21:20:37 CET 2023, RO-rootFS, swap_dev 0x6, Normal VGA How do I boot from this kernel? Using dpkg -i arch/x86/boot/bzImage ? How could GRUB show this kernel as e.g. "before-patch", or will it show the creation time? Where do I get the .patch file mentioned in https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s4.2.2 ? Best regards, Markus
