Bug#926539: rootskel: steal-ctty no longer works on s390x

2020-05-20 Thread John Paul Adrian Glaubitz
On 5/20/20 1:18 PM, Philipp Kern wrote: > But then I keep wondering how representative qemu is. Is VT220 SCLP even > something you get on a real z machine? Not that we shouldn't fix qemu, > of course. But Hercules might be closer to the real thing in this regard. Hercules shows the exact same

Bug#926539: rootskel: steal-ctty no longer works on s390x

2020-05-20 Thread Philipp Kern
On 20.05.20 12:42, Valentin Vidić wrote: > On Wed, May 20, 2020 at 11:19:53AM +0200, John Paul Adrian Glaubitz wrote: >> Ah, sorry. I was seeing the cached version of the thread, refreshing helped. >> >> In any case, the SPARC kernel maintainer (Dave Miller) had the same argument >> that it would

Bug#926539: rootskel: steal-ctty no longer works on s390x

2020-05-20 Thread John Paul Adrian Glaubitz
On 5/20/20 12:42 PM, Valentin Vidić wrote: > It is hard to tell, but it seems the current state is hardcoded > in different places: > > https://www.redhat.com/archives/libguestfs/2017-May/msg00068.html This wouldn't cause breakage as with your change, the console name would actually be ttysclp0.

Bug#926539: rootskel: steal-ctty no longer works on s390x

2020-05-20 Thread Valentin Vidić
On Wed, May 20, 2020 at 11:19:53AM +0200, John Paul Adrian Glaubitz wrote: > Ah, sorry. I was seeing the cached version of the thread, refreshing helped. > > In any case, the SPARC kernel maintainer (Dave Miller) had the same argument > that it would potentially break existing setups but

Bug#926539: rootskel: steal-ctty no longer works on s390x

2020-05-20 Thread John Paul Adrian Glaubitz
On 5/20/20 11:17 AM, John Paul Adrian Glaubitz wrote: > I don't see any discussion in this thread. I would like to know the reasoning > why kernel upstream thinks that this naming inconsistency is correct. It > makes no sense, in my opinion and it can potentially trigger more problems. Ah, sorry.

Bug#926539: rootskel: steal-ctty no longer works on s390x

2020-05-20 Thread John Paul Adrian Glaubitz
Hi! On 5/20/20 11:00 AM, Valentin Vidić wrote: > Similar change for console name on s390x was not accepted: > > https://lkml.org/lkml/2020/5/19/854 > > so please fix in rootskel. I don't see any discussion in this thread. I would like to know the reasoning why kernel upstream thinks that

Bug#926539: rootskel: steal-ctty no longer works on s390x

2020-05-20 Thread Valentin Vidić
Similar change for console name on s390x was not accepted: https://lkml.org/lkml/2020/5/19/854 so please fix in rootskel. -- Valentin