Bug#605844: lintian: Consider pre-sorting keys %{$info-index}

2010-12-03 Thread Niels Thykier
Package: lintian Version: 2.4.4 Hi I examined the source of lintian (pulled from git) and noticed that lintian could probably benefit from looking at common access patterns. In the checks, there are 13 accesses to 'keys %{$info-index}'; 11 of these are 'sort keys %{$info-index}'. This means

Bug#605844: lintian: Consider pre-sorting keys %{$info-index}

2010-12-03 Thread Niels Thykier
Interestingly enough this does not appear to be the current bottle neck of lintian (or I am doing something wrong in my patch). ~Niels $ dpkg --contents eclipse-platform-data_3.5.2-8_all.deb | wc -l 1480 lintian 2.4.3 $ for i in {1..5} ; do time lintian -EI --pedantic

Bug#605844: lintian: Consider pre-sorting keys %{$info-index}

2010-12-03 Thread Raphael Geissert
Hi Niels! [OT but using the opportunity: congrats! :)] Niels Thykier wrote: Interestingly enough this does not appear to be the current bottle neck of lintian (or I am doing something wrong in my patch). Thanks for the analysis and the suggestion (don't know if Russ is going to beat me at

Bug#605844: lintian: Consider pre-sorting keys %{$info-index}

2010-12-03 Thread Russ Allbery
Niels Thykier nthyk...@gmail.com writes: Interestingly enough this does not appear to be the current bottle neck of lintian (or I am doing something wrong in my patch). It's probably a good change regardless, but sorting is generally very fast. -- Russ Allbery (r...@debian.org)