Bug#612610: lintian: should suggest switching to 3.0 (quilt)

2013-03-29 Thread Lucas Nussbaum
On 29/03/13 at 01:28 +0100, Niels Thykier wrote: Hi, I am not sure we can in general promote the use of 3.0 (quilt) over 1.0 via Lintian at the moment[1]. Though I noticed that people are writing their own tools to extract things like what source format is used or what build systems are

Bug#704197: Please review: systemd checks

2013-03-29 Thread Michael Stapelberg
Package: lintian Version: 2.5.10.4 Severity: wishlist Attached you can find my first stab at systemd-related checks for lintian. While some details in parsing the service files are not implemented (see the TODOs in the code), I’d like you to have a look at the checks in general. Is there anything

Bug#704197: Please review: systemd checks

2013-03-29 Thread Niels Thykier
On 2013-03-29 11:11, Michael Stapelberg wrote: Package: lintian Version: 2.5.10.4 Severity: wishlist Attached you can find my first stab at systemd-related checks for lintian. While some details in parsing the service files are not implemented (see the TODOs in the code), I’d like you to

Bug#704197: Please review: systemd checks

2013-03-29 Thread Michael Stapelberg
Hi Niels, Thanks for the super-fast review. New version is attached, I have fixed everything you mentioned, and for the other things I commented inline: Niels Thykier ni...@thykier.net writes: guidelines. I know Lintian's code style is a mess in general, so it describes the style I hope we

[SCM] Debian package checker branch, master, updated. 2.5.11-196-gf399c98

2013-03-29 Thread Niels Thykier
The following commit has been merged in the master branch: commit f399c98ee24cfc18afd72e38af032fb10b977a8b Author: Niels Thykier ni...@thykier.net Date: Fri Mar 29 13:14:12 2013 +0100 L::Util: Introduce {,l,r}strip ... ... to replace uses of s/^\s++//; or/and s/\s++$//;. In void

Bug#704197: Please review: systemd checks

2013-03-29 Thread Russ Allbery
Michael Stapelberg stapelb...@debian.org writes: Niels Thykier ni...@thykier.net writes: guidelines. I know Lintian's code style is a mess in general, so it describes the style I hope we will eventually reach[1]. :) Have you tried using perltidy for Lintian? I loathe manual source code

Stanford IDG internal Perl style

2013-03-29 Thread Russ Allbery
This is the evolution of my original style document, much modified by contact with Perl Best Practices. There are some things here that I'd personally do differently (I prefer omitting the parens around arguments to Perl built-ins, for example), but this was the compromise reached across the

[SCM] Debian package checker branch, master, updated. 2.5.11-197-g69e0ac5

2013-03-29 Thread Niels Thykier
The following commit has been merged in the master branch: commit 69e0ac591bbc9d4a380de37d9ea013bf404cf97e Author: Niels Thykier ni...@thykier.net Date: Fri Mar 29 19:04:47 2013 +0100 *: Replace ad-hoc regexes with {,l,r}strip Signed-off-by: Niels Thykier ni...@thykier.net diff

Re: Stanford IDG internal Perl style

2013-03-29 Thread Niels Thykier
On 2013-03-29 18:24, Russ Allbery wrote: This is the evolution of my original style document, much modified by contact with Perl Best Practices. There are some things here that I'd personally do differently (I prefer omitting the parens around arguments to Perl built-ins, for example), but