On Fri, Jan 06, 2006 at 01:13:05PM +0800, Paul Wise wrote:
> On Thu, 2006-01-05 at 14:59 -0500, Justin Pryzby wrote:
>
> > > > > How about the attached combination check - does my check and also does
> > > > > yours, with the changes that it checks a couple of other words, and
> > > > > checks for
On Thu, 2006-01-05 at 14:59 -0500, Justin Pryzby wrote:
> > > > How about the attached combination check - does my check and also does
> > > > yours, with the changes that it checks a couple of other words, and
> > > > checks for a url in the description too.
> > >
> > > > $description =~ m/(home
On Thu, Jan 05, 2006 at 11:19:03AM +0800, Paul Wise wrote:
> On Wed, 2006-01-04 at 09:33 -0500, Justin Pryzby wrote:
>
> > > > Packages for which this is a false-positive (such as slash, gnudip,
> > > > and bake)
> > >
> > > These can be eliminated by checking for a url in the description too.
>
On Thu, 2006-01-05 at 11:19 +0800, Paul Wise wrote:
> I'll add the "last-para instead of last-line" change and then send an
> updated patch.
Patch attached.
--
bye,
pabs
http://wiki.debian.org/PaulWise
lintian-1.23.14-check-homepage-in-description-field.patch.gz
Description: GNU Zip compress
On Wed, 2006-01-04 at 09:33 -0500, Justin Pryzby wrote:
> > > Packages for which this is a false-positive (such as slash, gnudip,
> > > and bake)
> >
> > These can be eliminated by checking for a url in the description too.
>
> It reduces some true positives also: abcmidi, achims-guestbook,
> air
Hi Paul!
On Wed, Jan 04, 2006 at 01:34:34PM +0800, Paul Wise wrote:
> On Tue, 2006-01-03 at 10:53 -0500, Justin Pryzby wrote:
>
> > I would rather see my original, more aggressive check:
> >
> > $description=~m/homepage/is && $description!~/^ Homepage: [^ ]*$/
>
> Hmm, this misses stuff wher
On Tue, 2006-01-03 at 10:53 -0500, Justin Pryzby wrote:
> But I think it would be more readable as:
> Not this:
> http://..
> But this:
> http://...
I agree. Fixed.
> could be written more simply as
>
> + if( $last_line =~ m/-[0-9]/ ){
Also fixed.
> Also I do
I would ask for a small cosmetic change in the given patch.
Presently it has:
For example:
This: http://...
Not This: http://...
But I think it would be more readable as:
Not this:
http://..
But this:
http://...
Also the following seems to be longer and more complicated th
8 matches
Mail list logo
