Re: more patches

2008-08-30 Thread Frank Lichtenheld
On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: lintian_embedded-php-library: yet another PHP-related check for embedded copies, none making part of PEAR, based on the embedded-code-copies list. Note that there's also another disabled line which is for a package that is also

Re: more patches

2008-08-30 Thread Frank Lichtenheld
On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: lintian_xinha: adds a, currently commented, entry for xinha, which is already packaged but not yet in the archive; so it can be kept as a reminder to enable it as soon as the package reaches the archive. applied -- Frank

Re: more patches

2008-08-30 Thread Raphael Geissert
W: djpig should-not-send-copy-of-message to atomo64 Frank Lichtenheld wrote: On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: lintian_embedded-php-library: yet another PHP-related check for embedded copies, none making part of PEAR, based on the embedded-code-copies list.

Re: more patches

2008-08-30 Thread Frank Lichtenheld
On Sat, Aug 30, 2008 at 05:23:34PM -0500, Raphael Geissert wrote: Frank Lichtenheld wrote: On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: lintian_embedded-php-library: yet another PHP-related check for embedded copies, none making part of PEAR, based on the

Re: more patches

2008-08-30 Thread Raphael Geissert
Frank Lichtenheld wrote: On Sat, Aug 30, 2008 at 05:23:34PM -0500, Raphael Geissert wrote: Frank Lichtenheld wrote: On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: lintian_embedded-php-library: yet another PHP-related check for embedded copies, none making part of

Re: more patches

2008-08-30 Thread Adam D. Barratt
On Sun, 2008-08-31 at 01:04 +0200, Frank Lichtenheld wrote: I've no idea against which tree you make these patches but it certainly is not master. From your patch (checks/files.desc): Please depend on the respective PEAR package providing the module and make sure the library can be

Re: More patches

2008-08-26 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: well, some files do have a string that would be matched, but probably m,/pear[/.], is a better regex. That's the main drawnback: there's no easy way to tell whether it is a PEAR module or not. PHP, the world of inconsistencies

Re: More patches

2008-08-26 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: I suggested m,/pear[/.], as it would also match $Header: /repository/pear/Log/Log.php,v 1.69 2008/01/19 22:20:55 jon Exp $ which is what php-log's Log.php use. Done. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/

Re: More patches

2008-08-25 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: Attached is a git-am-friendly mbox file containing the patches making lintian check for embedded copies of jsjac and jsMath, and adds another tag checking for embedded copies of PHP PEAR modules (there are lots of those in the

Re: More patches

2008-08-25 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: Attached is a git-am-friendly mbox file containing the patches making lintian check for embedded copies of jsjac and jsMath, This part is applied. Thanks! and adds another tag checking for embedded copies of PHP PEAR modules (there are lots of

Re: More patches

2008-08-25 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: and adds another tag checking for embedded copies of PHP PEAR modules (there are lots of those in the wild). I think I'm going to decline to apply this one in its current form, or with m/pear/, since the false positive risk

Re: More patches

2008-08-25 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: That part was done in pourpose (not even /Filename is required on all cases) because some times some people do rename the files and add a comment or two but the code remains intact. Not even as an experimental tag using m,/pear/,? Oh, hey, good

Re: More patches

2008-08-25 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: That part was done in pourpose (not even /Filename is required on all cases) because some times some people do rename the files and add a comment or two but the code remains intact. Not even as an experimental tag using m,/pear/,? Er, this string

Re: More patches

2008-08-25 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: That part was done in pourpose (not even /Filename is required on all cases) because some times some people do rename the files and add a comment or two but the code remains intact. Not even as an experimental tag using

Re: More patches

2008-08-25 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: well, some files do have a string that would be matched, but probably m,/pear[/.], is a better regex. That's the main drawnback: there's no easy way to tell whether it is a PEAR module or not. PHP, the world of inconsistencies :) I'm currently

Re: More patches

2008-08-24 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: Attached is a git-am-friendly mbox file containing the patches making lintian check for embedded copies of jsjac and jsMath, and adds another tag checking for embedded copies of PHP PEAR modules (there are lots of those in the wild). + #

Re: more patches

2008-07-02 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: lintian_maintpatch: Adds a check for maintainer scripts modifying the php.ini file (only checks the preinst script as it is safe if done on the postrm to rollback the changes). I believe the description of the new tag is

Re: more patches

2008-07-02 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: lintian_improvedpatch: I made a couple of changes so it matches bla bla bla at the same time, and to make it catch all of the duplicated lines on the same line. Applied with a few fixes: Thanks! :) ---

Re: more patches

2008-07-02 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: Adds a check for maintainer scripts modifying the php.ini file (only checks the preinst script as it is safe if done on the postrm to rollback the changes). I believe the description of

Re: more patches

2008-07-01 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: lintian_maintpatch: Adds a check for maintainer scripts modifying the php.ini file (only checks the preinst script as it is safe if done on the postrm to rollback the changes). I believe the description of the new tag is clear enough. The

Re: more patches

2008-07-01 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: lintian_improvedpatch: I made a couple of changes so it matches bla bla bla at the same time, and to make it catch all of the duplicated lines on the same line. Applied with a few fixes: --- a/checks/description +++ b/checks/description @@