Re: checks/scripts / checkbashsims updates

2008-02-19 Thread Russ Allbery
Adam D. Barratt [EMAIL PROTECTED] writes: Sorry to be a pain, but we've tightened this further in svn to '(?![\$\(])\(\(.*\)\)' so as not to match constructs such as progress_size=$(((100 - $PROGRESS_STATE) / 3)) What *is* this construct trying to catch, anyway? dash supports

Re: checks/scripts / checkbashsims updates

2008-02-19 Thread Adam D. Barratt
On Tue, 2008-02-19 at 09:07 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: Sorry to be a pain, but we've tightened this further in svn to '(?![\$\(])\(\(.*\)\)' so as not to match constructs such as progress_size=$(((100 - $PROGRESS_STATE) / 3))

Re: checks/scripts / checkbashsims updates

2008-02-18 Thread Russ Allbery
Adam D. Barratt [EMAIL PROTECTED] writes: Please let me know how you'd prefer to handle these, and any such issues that arise in future. I'm more than happy to simply provide a list (as below), send patches to the list or file bugs against lintian with patches. Either patches to the list or

Re: checks/scripts / checkbashsims updates

2008-02-18 Thread Adam D. Barratt
On Mon, 2008-02-18 at 16:33 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: Please let me know how you'd prefer to handle these, and any such issues that arise in future. I'm more than happy to simply provide a list (as below), send patches to the list or file bugs

Re: checks/scripts / checkbashsims updates

2008-02-18 Thread Russ Allbery
Adam D. Barratt [EMAIL PROTECTED] writes: I didn't, but it works better, so I do now. :-) The final [^\s]+ group alwo wants to be [^\s;]+ or . ${sysconfdir}/pop3d-ssl ; \ is still flagged. (Adding ` to that group didn't seem to make any difference to my test expressions). Ah, yes, thanks.

Re: checks/scripts / checkbashsims updates

2008-02-18 Thread Adam D. Barratt
On Mon, 2008-02-18 at 16:33 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: [...] The first issue is from the checkbashisms side: '(?!\$)\(\(', # '((' should be '$((' This will also match constructs such as if ((foo || bar) baz). I've tightened the

checks/scripts / checkbashsims updates

2008-02-10 Thread Adam D. Barratt
Hi, Thanks for adding the set of bashism checks from checkbashisms to lintian recently. As a result of the recent bugs that people have been filing on other packages using checkbashsims output, a few issues have surfaced - one with a check that originated in the patch, and a couple that were