Author: rra Date: 2006-07-15 07:35:58 +0200 (Sat, 15 Jul 2006) New Revision: 699
Modified: trunk/checks/deb-format trunk/checks/deb-format.desc trunk/debian/changelog Log: * checks/deb-format{.desc,}: + [RA] Remove deb-created-with-broken-tar; the bug was actually in dpkg, and the dpkg in stable has been fixed. Thanks Jari Aalto and Thijs Kinkhorst. (Closes: #375638, #376030) Modified: trunk/checks/deb-format =================================================================== --- trunk/checks/deb-format 2006-07-15 05:18:41 UTC (rev 698) +++ trunk/checks/deb-format 2006-07-15 05:35:58 UTC (rev 699) @@ -38,45 +38,8 @@ close LIST; } -open INPUT, "dpkg-deb --fsys-tarfile deb |"; - -my $chunk; -# Previous was a LongLink? -my $is_long = 0; -while (read(INPUT, $chunk, 512)) { - last if length($chunk) != 512; - my ($name, $size, $htype) = unpack "A100x24A12x20A1", $chunk; - $size = oct($size); - - if (!$is_long && length($name) == 100) { - # This should have been a LongLink, as now the filename isn't - # NUL-terminated, as dpkg -i expects. - - # Remove the leading dot - $name =~ s/^\.//; - - tag "deb-created-with-broken-tar", "file: $name"; - } - - $is_long = $htype eq 'L'; - - # eat data - if ($size) { - read(INPUT, $chunk, get_block_size($size)) or last; - } } -close INPUT; - -} # </run> - -sub get_block_size { - my $size = shift; - my $nblocks = int($size / 512); - $nblocks ++ if (($size % 512) > 0); - return 512*$nblocks; -} - 1; # vim: ts=4 sw=4 Modified: trunk/checks/deb-format.desc =================================================================== --- trunk/checks/deb-format.desc 2006-07-15 05:18:41 UTC (rev 698) +++ trunk/checks/deb-format.desc 2006-07-15 05:35:58 UTC (rev 699) @@ -6,16 +6,6 @@ Unpack-Level: 1 Info: This script checks the format of the deb ar archive itself. -Tag: deb-created-with-broken-tar -Type: error -Info: The binary package was created with a broken version of tar. - Some versions of tar contain a bug, which make the resulting .deb broken. On - unpack, some filenames are going to be corrupted. - . - This package was build with such a version of tar, and the mentioned filename - is corrupted. Refer to Debian bug #230910 for more information, or simply - update your tar-version and rebuild. - Tag: deb-data-member-wrongly-compressed Type: error Info: The binary package contains a data member not compressed with gzip. Modified: trunk/debian/changelog =================================================================== --- trunk/debian/changelog 2006-07-15 05:18:41 UTC (rev 698) +++ trunk/debian/changelog 2006-07-15 05:35:58 UTC (rev 699) @@ -1,5 +1,9 @@ lintian (1.23.23) UNRELEASED; urgency=low + * checks/deb-format{.desc,}: + + [RA] Remove deb-created-with-broken-tar; the bug was actually in + dpkg, and the dpkg in stable has been fixed. Thanks Jari Aalto and + Thijs Kinkhorst. (Closes: #375638, #376030) * checks/fields{.desc,}: + [RA] Don't warn virtual-package-depends-without-real-package-depends for Recommends and rewrite the tag description to be more accurate. @@ -13,7 +17,7 @@ + [RA] Warn if the changelog incorrectly indicates an NMU. Thanks to George Danchev for the report. - -- Russ Allbery <[EMAIL PROTECTED]> Fri, 14 Jul 2006 22:17:24 -0700 + -- Russ Allbery <[EMAIL PROTECTED]> Fri, 14 Jul 2006 22:34:10 -0700 lintian (1.23.22) unstable; urgency=low -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]