Re: [SCM] Debian package checker branch, master, updated. ad09f133a313d2ba70328a6a5127edbea1d4b356

2008-07-06 Thread Frank Lichtenheld
On Thu, Jul 03, 2008 at 10:11:36PM +, Adam D. Barratt wrote: The following commit has been merged in the master branch: commit ad09f133a313d2ba70328a6a5127edbea1d4b356 Author: Adam D. Barratt [EMAIL PROTECTED] If you use patches by others without modifying them significantly (which I

Re: [SCM] Debian package checker branch, master, updated. ad09f133a313d2ba70328a6a5127edbea1d4b356

2008-07-06 Thread Adam D. Barratt
On Sun, 2008-07-06 at 11:24 +0200, Frank Lichtenheld wrote: On Thu, Jul 03, 2008 at 10:11:36PM +, Adam D. Barratt wrote: The following commit has been merged in the master branch: commit ad09f133a313d2ba70328a6a5127edbea1d4b356 Author: Adam D. Barratt [EMAIL PROTECTED] If you use

[SCM] Debian package checker branch, master, updated. 38002a14d5e0b494449410efb1d8555ead1cef30

2008-07-06 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 38002a14d5e0b494449410efb1d8555ead1cef30 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sun Jul 6 13:23:01 2008 +0100 Detect unused templates and check all maintainer scripts for issues Merge postrm-purge check

Re: [SCM] Debian package checker branch, master, updated. 38002a14d5e0b494449410efb1d8555ead1cef30

2008-07-06 Thread Adam D. Barratt
On Sun, 2008-07-06 at 12:24 +, Adam D. Barratt wrote: The following commit has been merged in the master branch: commit 38002a14d5e0b494449410efb1d8555ead1cef30 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sun Jul 6 13:23:01 2008 +0100 Detect unused templates and check all

Re: [SCM] Debian package checker branch, master, updated. ad09f133a313d2ba70328a6a5127edbea1d4b356

2008-07-06 Thread Frank Lichtenheld
On Sun, Jul 06, 2008 at 11:16:27AM +0100, Adam D. Barratt wrote: On Sun, 2008-07-06 at 11:24 +0200, Frank Lichtenheld wrote: On Thu, Jul 03, 2008 at 10:11:36PM +, Adam D. Barratt wrote: The following commit has been merged in the master branch: commit

Re: [SCM] Debian package checker branch, master, updated. ad09f133a313d2ba70328a6a5127edbea1d4b356

2008-07-06 Thread Raphael Geissert
Frank Lichtenheld wrote: On Thu, Jul 03, 2008 at 10:11:36PM +, Adam D. Barratt wrote: The following commit has been merged in the master branch: commit ad09f133a313d2ba70328a6a5127edbea1d4b356 Author: Adam D. Barratt [EMAIL PROTECTED] If you use patches by others without modifying

Yet another patch + how to check for stuff in shell scripts

2008-07-06 Thread Raphael Geissert
Hi all, Last time I filed bug reports for the dash RG thanks to the package maintainers I noticed that there's a 'time' package which provides the same functionality of bash's 'time' built-in. So here's a patch which avoids emitting the bashisms tag if the match is 'time' and there's a

Re: [SCM] Debian package checker branch, master, updated. ad09f133a313d2ba70328a6a5127edbea1d4b356

2008-07-06 Thread Russ Allbery
Frank Lichtenheld [EMAIL PROTECTED] writes: Nope. But since the whole SVN history has essentially the same problem, one more commit doesn't really matter that much. I just figured you should know this is possible. I hadn't realized that either. Thank you! -- Russ Allbery ([EMAIL

Re: [SCM] Debian package checker branch, master, updated. 38002a14d5e0b494449410efb1d8555ead1cef30

2008-07-06 Thread Russ Allbery
Adam D. Barratt [EMAIL PROTECTED] writes: -if (not $obsoleteconfmodule and +if (($file eq 'postinst' or $file eq 'config') and +not $obsoleteconfmodule and m,(/usr/share/debconf/confmodule\.sh| Debian::DebConf::Client::ConfModule),x) {

Re: Yet another patch + how to check for stuff in shell scripts

2008-07-06 Thread Russ Allbery
Russ Allbery [EMAIL PROTECTED] writes: --- a/checks/scripts +++ b/checks/scripts @@ -697,9 +697,12 @@ while (SCRIPTS) { $line =~ s/(^|[^\\\'](?:)*)\(?:\\.|[^\\\])+\/$1/g; for my $re (@bashism_regexs) { if ($line =~ m/($re)/) { -

[SCM] Debian package checker branch, master, updated. 7bdebaa97f61aeaca814f0c5a24d7e4f4112e6d7

2008-07-06 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 7bdebaa97f61aeaca814f0c5a24d7e4f4112e6d7 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sun Jul 6 21:19:04 2008 +0100 Replace {config,postinst}-loads-obsolete-confmodule with a generic loads-obsolete-confmodule tag

Re: [SCM] Debian package checker branch, master, updated. 38002a14d5e0b494449410efb1d8555ead1cef30

2008-07-06 Thread Adam D. Barratt
On Sun, 2008-07-06 at 12:29 -0700, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: This could be easily fixed by renaming the postinst variant to maintainer-script-loads-obsolete-confmodule - or just loads-obsolete-confmodule. Does renaming tags cause any major issues?

[SCM] Debian package checker branch, master, updated. 3a0a57ee7b57dd45f9a0409fa0cd97828a7c1d38

2008-07-06 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 3a0a57ee7b57dd45f9a0409fa0cd97828a7c1d38 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sun Jul 6 21:41:17 2008 +0100 Fix potential false-positives in the bashism checks for pushd, popd, ulimit, shopt and dirs diff --git

[SCM] Debian package checker branch, master, updated. 442b6d69cd736082499e9ebb39c1f40d2f3e46d2

2008-07-06 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 442b6d69cd736082499e9ebb39c1f40d2f3e46d2 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sun Jul 6 22:08:25 2008 +0100 Fix false-positives in the echo with backslashes bashism checks diff --git a/checks/scripts

Re: Yet another patch + how to check for stuff in shell scripts

2008-07-06 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: Besides that patch, I'd like to know the opinion of others about how shell scripts should be checked. At the moment checks/scripts now makes use of $LEADIN as a separator/command identifier, but other checks also checking for

Re: Yet another patch + how to check for stuff in shell scripts

2008-07-06 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: Russ Allbery wrote: Given that running invoke-rc.d under time in a Debian maintainer script doesn't seem like sane behavior, I don't think I have a problem with that specific case. However, in general, there are a lot of shell script checks in

Re: Yet another patch + how to check for stuff in shell scripts

2008-07-06 Thread Raphael Geissert
Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: Russ Allbery wrote: Given that running invoke-rc.d under time in a Debian maintainer script doesn't seem like sane behavior, I don't think I have a problem with that specific case. However, in general, there are a lot of

Re: Yet another patch + how to check for stuff in shell scripts

2008-07-06 Thread Russ Allbery
Raphael Geissert [EMAIL PROTECTED] writes: Of course, $LEADIN isn't suitable for every check lintian is doing. My main point was that several checks are actually very prone to false positives and false negatives. Yeah, that's part of the problem and one of the things that makes the code hard