Bug#886343: lintian: missing-notice-file-for-apache-license false positives

[Ferenc Wágner]

Chris Lamb  writes:

> Thanks for the report. I have fixed this in Git:
>   
> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=28028299a402eb8d87176a537facc437ab89b6c6

Wow, that was quick!
-- 
Thanks,
Feri

Jenkins build is back to normal : lintian-tests_buster #460

[jenkins]

See 

Jenkins build is back to normal : lintian-tests_stretch-backports #47

[jenkins]

See 

[lintian] branch master updated (f49665b -> 2df692b)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  f49665b   checks/source-copyright.desc: Be explicit that we check 
NOTICE.txt files too.
   new  2df692b   Rename 
orphaned-package-not-maintained-in-debian-infrastracture -> infrastracture.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/fields.desc| 2 +-
 checks/fields.pm  | 2 +-
 .../tags  | 1 -
 .../debian/debian/changelog.in| 0
 .../debian/debian/control.in  | 0
 .../desc  | 4 ++--
 .../tags  | 1 +
 t/tests/nmu-qa-upload/desc| 2 +-
 8 files changed, 6 insertions(+), 6 deletions(-)
 delete mode 100644 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/tags
 rename t/tests/{files-orphaned-package-not-maintained-in-debian-infrastracture 
=> 
files-orphaned-package-not-maintained-in-debian-infrastructure}/debian/debian/changelog.in
 (100%)
 rename t/tests/{files-orphaned-package-not-maintained-in-debian-infrastracture 
=> 
files-orphaned-package-not-maintained-in-debian-infrastructure}/debian/debian/control.in
 (100%)
 rename t/tests/{files-orphaned-package-not-maintained-in-debian-infrastracture 
=> files-orphaned-package-not-maintained-in-debian-infrastructure}/desc (75%)
 create mode 100644 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/tags

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Rename orphaned-package-not-maintained-in-debian-infrastracture -> infrastracture.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 2df692b284ddc6305d278960b151557155c2fd1b
Author: Chris Lamb 
Date:   Thu Jan 4 22:54:22 2018 +

Rename orphaned-package-not-maintained-in-debian-infrastracture -> 
infrastracture.
---
 checks/fields.desc| 2 +-
 checks/fields.pm  | 2 +-
 .../tags  | 1 -
 .../debian/debian/changelog.in| 0
 .../debian/debian/control.in  | 0
 .../desc  | 4 ++--
 .../tags  | 1 +
 t/tests/nmu-qa-upload/desc| 2 +-
 8 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index 114ef9a..4ca9aa4 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1372,7 +1372,7 @@ Info: The debian/control file contains a Bugs 
field that does
  This is likely to make reportbug(1) unable to report bugs.
 Ref: #740944
 
-Tag: orphaned-package-not-maintained-in-debian-infrastracture
+Tag: orphaned-package-not-maintained-in-debian-infrastructure
 Severity: normal
 Certainty: certain
 Info:
diff --git a/checks/fields.pm b/checks/fields.pm
index 95f17c4..734959c 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -1338,7 +1338,7 @@ sub run {
 $seen_vcs{$vcs}++ if $vcs ne 'browser';
 if ($info->field('maintainer', '') =~ /packages\@qa.debian.org/
 and $uri !~ m/\.debian\.org/) {
-tag 'orphaned-package-not-maintained-in-debian-infrastracture',
+tag 'orphaned-package-not-maintained-in-debian-infrastructure',
   "vcs-$vcs", $uri;
 }
 }
diff --git 
a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/tags 
b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/tags
deleted file mode 100644
index 4683946..000
--- 
a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/tags
+++ /dev/null
@@ -1 +0,0 @@
-W: files-orphaned-package-not-maintained-in-debian-infrastracture source: 
orphaned-package-not-maintained-in-debian-infrastracture vcs-git 
https://github.com/user/project
diff --git 
a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/changelog.in
 
b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/debian/debian/changelog.in
similarity index 100%
rename from 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/changelog.in
rename to 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/debian/debian/changelog.in
diff --git 
a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/control.in
 
b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/debian/debian/control.in
similarity index 100%
rename from 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/debian/debian/control.in
rename to 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/debian/debian/control.in
diff --git 
a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/desc 
b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/desc
similarity index 75%
rename from 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/desc
rename to 
t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/desc
index 63380b0..6f1007f 100644
--- 
a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastracture/desc
+++ 
b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/desc
@@ -1,7 +1,7 @@
-Testname: files-orphaned-package-not-maintained-in-debian-infrastracture
+Testname: files-orphaned-package-not-maintained-in-debian-infrastructure
 Description: Test for orphaned package not maintained in Debian infrastucture
 Version: 1.0
 Test-For:
- orphaned-package-not-maintained-in-debian-infrastracture
+ orphaned-package-not-maintained-in-debian-infrastructure
 Test-Against:
  changelog-should-mention-qa
diff --git 
a/t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/tags 
b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/tags
new file mode 100644
index 000..204a229
--- /dev/null
+++ 
b/t/tests/files-orphaned-package-not-maintained-in-debian-infrastructure/tags
@@ -0,0 +1 @@
+W: files-orphaned-package-not-maintained-in-debian-infrastructure source: 
orphaned-package-not-maintained-in-debian-infrastructure vcs-git 
https://github.com/user/project
diff --git a/t/tests/nmu-qa-upload/desc 

Processed: Re: lintian: warn about non-git Vcs fields

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> retitle 885974 lintian: warn about non-git Vcs fields hosted on Debian 
> infrastructure
Bug #885974 [src:lintian] lintian: warn about non-git Vcs fields
Changed Bug title to 'lintian: warn about non-git Vcs fields hosted on Debian 
infrastructure' from 'lintian: warn about non-git Vcs fields'.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
885974: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885974
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#886343: lintian: missing-notice-file-for-apache-license false positives

[Chris Lamb]

tags 886343 + pending
thanks

Ferenc,

Thanks for the report. I have fixed this in Git:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=28028299a402eb8d87176a537facc437ab89b6c6


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#886343: lintian: missing-notice-file-for-apache-license false positives

[Chris Lamb]

tags 886343 + pending
thanks

Ferenc,

Thanks for the report. I have fixed this in Git:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=28028299a402eb8d87176a537facc437ab89b6c6


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] branch master updated (2802829 -> f49665b)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  2802829   checks/source-copyright.desc: Avoid false positives for 
missing-notice-file-for-apache-license by also looking for files with a .txt 
extension in binary packages. Thanks to Ferenc Wágner for the report. (Closes: 
#886343)
   new  f49665b   checks/source-copyright.desc: Be explicit that we check 
NOTICE.txt files too.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/source-copyright.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: checks/source-copyright.desc: Be explicit that we check NOTICE.txt files too.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit f49665bcaf0a40b00212168466b73d0d0a5f7ba6
Author: Chris Lamb 
Date:   Thu Jan 4 21:52:54 2018 +

checks/source-copyright.desc: Be explicit that we check NOTICE.txt files 
too.
---
 checks/source-copyright.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc
index be46c84..718be30 100644
--- a/checks/source-copyright.desc
+++ b/checks/source-copyright.desc
@@ -330,7 +330,7 @@ Severity: serious
 Certainty: possible
 Info: The package appears to be licensed under the Apache 2.0 license and
  a NOTICE file (or similar) exists in the source tree. However, no
- files called NOTICE (or NOTICE.gz) are installed in any
+ files called NOTICE or NOTICE.txt are installed in any
  of the binary packages.
  .
  The Apache 2.0 license requires distributing of such files:

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: checks/source-copyright.desc: Avoid false positives for missing-notice-file-for-apache-license by also looking for files with a .txt extension in binary packages. Thanks to Ferenc Wá

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 28028299a402eb8d87176a537facc437ab89b6c6
Author: Chris Lamb 
Date:   Thu Jan 4 21:51:41 2018 +

checks/source-copyright.desc: Avoid false positives for 
missing-notice-file-for-apache-license by also looking for files with a .txt 
extension in binary packages. Thanks to Ferenc Wágner for the report. (Closes: 
#886343)
---
 checks/source-copyright.pm | 2 +-
 debian/changelog   | 4 
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/checks/source-copyright.pm b/checks/source-copyright.pm
index 2bf6a3e..c04e82a 100644
--- a/checks/source-copyright.pm
+++ b/checks/source-copyright.pm
@@ -165,7 +165,7 @@ sub _check_apache_notice_files {
 
 foreach my $binpkg (@procs) {
 my @files = $binpkg->info->sorted_index;
-return if any { $_->basename =~ m/^NOTICE(\.gz)?$/} @files;
+return if any { $_->basename =~ m/^NOTICE(\.txt)?(\.gz)?$/} @files;
 }
 
 tag 'missing-notice-file-for-apache-license', join(' ', @notice_files);
diff --git a/debian/changelog b/debian/changelog
index 4a31c54..7d714bf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -32,6 +32,10 @@ lintian (2.5.68) UNRELEASED; urgency=medium
 + [CL] Skip Objective-C libraries for the no-symbols-control-file tag
   as instance/class methods do not appear in the symbol table. Thanks
   to Yavor Doganov for the report and help.  (Closes: #749202)
+  * checks/source-copyright.desc:
++ [CL] Avoid false positives for missing-notice-file-for-apache-license
+  by also looking for files with a .txt extension in binary packages.
+  Thanks to Ferenc Wágner for the report.  (Closes: #886343)
   * checks/standards-version.desc:
 + [CL] Downgrade severity of out-of-date-standards-version from normal
   ("W:") to wishlist ("I:").  (Closes: #886210)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (3c83a65 -> 2802829)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  3c83a65   data/standards-version/ancient-date: Change the policy of 
"ancient-standards-version" to "a release of Policy from the previous stable 
release cycle" and update the value to match. (Closes: #886219)
   new  2802829   checks/source-copyright.desc: Avoid false positives for 
missing-notice-file-for-apache-license by also looking for files with a .txt 
extension in binary packages. Thanks to Ferenc Wágner for the report. (Closes: 
#886343)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/source-copyright.pm | 2 +-
 debian/changelog   | 4 
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#886343: lintian: missing-notice-file-for-apache-license false positives

[Ferenc Wágner]

Package: lintian
Version: 2.5.67
Severity: normal

Dear Maintainer,

My package won the

E: shibboleth-sp2 source: missing-notice-file-for-apache-license doc/NOTICE.txt

Lintian error even though all its binary packages carry NOTICE.txt due to

   dh_installdocs -A doc/NOTICE.txt [...]

Looking at the Lintian code, it checks for ^NOTICE(\.gz)?$ only:
https://sources.debian.org/src/lintian/2.5.67/checks/source-copyright.pm/?hl=168#L168
but my NOTICE.txt is too small to be compressed by dh_compress and has
.txt extension anyway.  Do you agree that this should be relaxed?
-- 
Regards,
Feri.

Bug#886219: lintian should be less pedantic about latest policy version

[Chris Lamb]

tags 886219 + pending
thanks

This has been committed in Git, pending upload within a few days:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=3c83a65d8f4a055eced5c254dac048a61bbdc2bc


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Build failed in Jenkins: lintian-tests_stretch-backports #46

[jenkins]

See 


--
Started by upstream project "lintian-tests_buster" build number 457
originally caused by:
 Started by upstream project "lintian-tests_sid" build number 2375
 originally caused by:
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building on master in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository git://anonscm.debian.org/lintian/lintian.git
 > git init 
 >  # 
 > timeout=10
Fetching upstream changes from git://anonscm.debian.org/lintian/lintian.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anonscm.debian.org/lintian/lintian.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Command "git fetch --tags --progress 
git://anonscm.debian.org/lintian/lintian.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: unable to connect to anonscm.debian.org:
anonscm.debian.org[0: 5.153.231.21]: errno=Connection refused
anonscm.debian.org[1: 2001:41c8:1000:21::21:21]: errno=Network is unreachable


at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1970)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1689)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:71)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:380)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:589)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1083)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1123)
at hudson.scm.SCM.checkout(SCM.java:495)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1202)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:421)
ERROR: Error cloning remote repo 'origin'

Processed: Re: lintian should be less pedantic about latest policy version

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 886219 + pending
Bug #886219 [lintian] lintian should be less pedantic about latest policy 
version
Bug #886210 [lintian] Downgrade "out-of-date-standards-version" to an info
Ignoring request to alter tags of bug #886219 to the same tags previously set
Ignoring request to alter tags of bug #886210 to the same tags previously set
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
886210: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886210
886219: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886219
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#886219: lintian should be less pedantic about latest policy version

[Chris Lamb]

tags 886219 + pending
thanks

This has been committed in Git, pending upload within a few days:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=3c83a65d8f4a055eced5c254dac048a61bbdc2bc


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] branch master updated (20e1dbd -> 3c83a65)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  20e1dbd   debian/changelog: Correct ordering.
   new  3c83a65   data/standards-version/ancient-date: Change the policy of 
"ancient-standards-version" to "a release of Policy from the previous stable 
release cycle" and update the value to match. (Closes: #886219)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/standards-version/ancient-date |  8 ++--
 debian/changelog|  4 ++
 t/scripts/ancient-sv-date.t | 77 -
 3 files changed, 9 insertions(+), 80 deletions(-)
 delete mode 100755 t/scripts/ancient-sv-date.t

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: data/standards-version/ancient-date: Change the policy of "ancient-standards-version" to "a release of Policy from the previous stable release cycle" and update the value to match. (C

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 3c83a65d8f4a055eced5c254dac048a61bbdc2bc
Author: Chris Lamb 
Date:   Thu Jan 4 10:30:45 2018 +

data/standards-version/ancient-date: Change the policy of 
"ancient-standards-version" to "a release of Policy from the previous stable 
release cycle" and update the value to match. (Closes: #886219)
---
 data/standards-version/ancient-date |  8 ++--
 debian/changelog|  4 ++
 t/scripts/ancient-sv-date.t | 77 -
 3 files changed, 9 insertions(+), 80 deletions(-)

diff --git a/data/standards-version/ancient-date 
b/data/standards-version/ancient-date
index 1f1a34a..4ba1100 100644
--- a/data/standards-version/ancient-date
+++ b/data/standards-version/ancient-date
@@ -1,5 +1,7 @@
 # Any Standards Version released before this day is "ancient"
-# That date has to be within 22 and 26 months in the past
-# at release time
+#
+# Since #886219 this is defined as "a release of Policy from the previous
+# stable release cycle."
+#
 # Format is ANCIENT < Date
-ANCIENT < 27 January 2016
+ANCIENT < 25 April 2015
diff --git a/debian/changelog b/debian/changelog
index d985306..4a31c54 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -43,6 +43,10 @@ lintian (2.5.68) UNRELEASED; urgency=medium
   * data/files/fnames:
 + [CL] Warn about packages that ship (non-reproducible) Python
   Hypothesis examples.  (Closes: #886101)
+  * data/standards-version/ancient-date:
++ [CL] Change the policy of "ancient-standards-version" to "a release
+  of Policy from the previous stable release cycle" and update the
+  value to match.  (Closes: #886219)
 
   * reporting/templates/maintainer.tmpl:
 + [CL] Make the previously-hidden package anchor links visible so that
diff --git a/t/scripts/ancient-sv-date.t b/t/scripts/ancient-sv-date.t
deleted file mode 100755
index 8cfecda..000
--- a/t/scripts/ancient-sv-date.t
+++ /dev/null
@@ -1,77 +0,0 @@
-#!/usr/bin/perl
-#
-# Test for keeping "ancient standards version" date
-# recent.
-#
-
-use strict;
-use warnings;
-use autodie;
-
-use Test::More;
-
-# How much out of date the check may be; measured in seconds
-# 2 months
-use constant ERROR_MARGIN => 3600 * 24 * 31 * 2;
-# How long before a SV is considered "Ancient" in seconds.
-# 2 years.
-use constant ANCIENT_AGE  => 3600 * 24 * 365 * 2;
-use Date::Parse qw(str2time);
-
-# STOP! Before you even consider to make this run always
-# remember that this test will fail (causing FTBFS) every
-# "ERROR_MARGIN" seconds!
-#   This check is here to remind us to update ANCIENT_DATE
-# in checks/standards-version every now and then during
-# development cycles!
-plan skip_all => 'Only checked for UNRELEASED versions'
-  if should_skip();
-
-plan tests => 2;
-
-$ENV{'LINTIAN_TEST_ROOT'} //= '.';
-
-my $check = "$ENV{'LINTIAN_TEST_ROOT'}/data/standards-version/ancient-date";
-my $found = 0;
-open(my $fd, '<', $check);
-while (my $line = <$fd>) {
-# We are looking for:
-#   my $ANCIENT_DATE < '20 Aug 2009')
-$line =~ s,\#.*+,,o;
-if (
-$line =~ m/ANCIENT \s* < \s*
-  ([\s\w]+)/ox
-  ) {
-my $date = $1;
-my $and = str2time($date)
-  or die "Cannot parse date ($date, line $.): $!";
-my $time = time - ANCIENT_AGE;
-$found = 1;
-cmp_ok($time, '<', $and + ERROR_MARGIN, 'ANCIENT_DATE is up to date')
-  or diag(' * Please update data/standards-version/ancient-date');
-cmp_ok(
-$time, '>',
-$and - ERROR_MARGIN,
-'ANCIENT_DATE is not too far ahead'
-);
-last;
-}
-}
-close($fd);
-
-die "Cannot find ANCIENT_DATE.\n" unless $found;
-
-sub should_skip {
-my $skip = 1;
-
-open(my $fd, '-|', 'dpkg-parsechangelog', '-c0');
-
-while (<$fd>) {
-$skip = 0 if m/^Distribution: UNRELEASED$/;
-}
-
-close($fd);
-
-return $skip;
-}
-

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#886219: lintian should be less pedantic about latest policy version

[Holger Levsen]

On Wed, Jan 03, 2018 at 11:05:09PM +, Chris Lamb wrote:
> > > - ancient-standards-version should be triggered when S-V contains a
> > >   release of Policy from the previous stable release cycle
> > This sounds good to me.

reading this once again I'm reminded that this feeds the notion that our
current stable release is ancient :-/

But I guess that ship has sailed…

> Same here Is this the consensus view? If so, I can go ahead and make
> the change.

thanks.


-- 
cheers,
Holger


signature.asc
Description: PGP signature

Bug#886297: lintian: false positive: autotools-pkg-config-macro-not-cross-compilation-safe

[Chris Lamb]

tags 886297 + pending
thanks

Hi Theppitak,

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=ca3934004da8170468193c7d57bf17292a78c237


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: false positive: autotools-pkg-config-macro-not-cross-compilation-safe

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 886297 + pending
Bug #886297 [lintian] lintian: false positive: 
autotools-pkg-config-macro-not-cross-compilation-safe
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
886297: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886297
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (ca39340 -> 20e1dbd)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  ca39340   checks/cruft.pm: Avoid a false-positive reported by 
Theppitak Karoonboonyanan when matching 
autotools-pkg-config-macro-not-cross-compilation-safe by skipping comment 
lines. (Closes: #886297)
   new  20e1dbd   debian/changelog: Correct ordering.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: debian/changelog: Correct ordering.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 20e1dbd971f70e6c1716e30a16a1be631bf7780f
Author: Chris Lamb 
Date:   Thu Jan 4 09:09:54 2018 +

debian/changelog: Correct ordering.
---
 debian/changelog | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index b7ab244..d985306 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,18 +6,15 @@ lintian (2.5.68) UNRELEASED; urgency=medium
 + [CL] Avoid a false-positive reported by Theppitak Karoonboonyanan
   when matching autotools-pkg-config-macro-not-cross-compilation-safe
   by skipping comment lines.  (Closes: #886297)
-  * checks/scripts.desc:
-+ [CL] Also mention Recommends and Suggests in the opening paragraph of
-  python-script-but-no-python-dep.  (Closes: #687141)
-  * checks/huge-usr-share.pm:
-+ [CL] Bump arch-dep-package-has-big-usr-share thresholds; they were
-  last set in 2004.  (Closes: #648755)
   * checks/debconf.pm:
 + [CL] Don't warn about unknown template type "entropy" when a package
   depends on cdebconf.  (Closes: #677870)
   * checks/fields.pm:
 + [CL] Warn about orphaned packages that are not maintained in the
   Debian infrastucture.  (Closes: #886057)
+  * checks/huge-usr-share.pm:
++ [CL] Bump arch-dep-package-has-big-usr-share thresholds; they were
+  last set in 2004.  (Closes: #648755)
   * checks/python.{pm,desc}:
 + [CL] Don't warn about django-package-does-not-depend-on-django for
   -doc packages, etc.
@@ -28,6 +25,9 @@ lintian (2.5.68) UNRELEASED; urgency=medium
   * checks/rules.pm:
 + [CL] Also allow $(overridden_command) when checking for the
   override_dh_fixperms-does-not-call-dh_fixperms etc. tags.
+  * checks/scripts.desc:
++ [CL] Also mention Recommends and Suggests in the opening paragraph of
+  python-script-but-no-python-dep.  (Closes: #687141)
   * checks/shared-libs.pm:
 + [CL] Skip Objective-C libraries for the no-symbols-control-file tag
   as instance/class methods do not appear in the symbol table. Thanks

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: checks/cruft.pm: Avoid a false-positive reported by Theppitak Karoonboonyanan when matching autotools-pkg-config-macro-not-cross-compilation-safe by skipping comment lines. (Closes: #

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit ca3934004da8170468193c7d57bf17292a78c237
Author: Chris Lamb 
Date:   Thu Jan 4 09:09:11 2018 +

checks/cruft.pm: Avoid a false-positive reported by Theppitak 
Karoonboonyanan when matching 
autotools-pkg-config-macro-not-cross-compilation-safe by skipping comment 
lines. (Closes: #886297)
---
 checks/cruft.pm   | 1 +
 debian/changelog  | 4 
 .../debian/configure.ac   | 2 ++
 .../debian/configure.in   | 2 ++
 4 files changed, 9 insertions(+)

diff --git a/checks/cruft.pm b/checks/cruft.pm
index 4d27b18..3007a68 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -683,6 +683,7 @@ sub find_cruft {
 && $entry->is_open_ok) {
 my $fd = $entry->open;
 while (my $line = <$fd>) {
+next if $line =~ m{^\s*dnl};
 tag 'autotools-pkg-config-macro-not-cross-compilation-safe',
   $name, "(line $.)"
   if $line=~ m{AC_PATH_PROG\s*\([^,]+,\s*\[?pkg-config\]?\s*,};
diff --git a/debian/changelog b/debian/changelog
index 6aa540f..b7ab244 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,10 @@ lintian (2.5.68) UNRELEASED; urgency=medium
 
   XXX: generate tag summary
 
+  * checks/cruft.pm:
++ [CL] Avoid a false-positive reported by Theppitak Karoonboonyanan
+  when matching autotools-pkg-config-macro-not-cross-compilation-safe
+  by skipping comment lines.  (Closes: #886297)
   * checks/scripts.desc:
 + [CL] Also mention Recommends and Suggests in the opening paragraph of
   python-script-but-no-python-dep.  (Closes: #687141)
diff --git 
a/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.ac
 
b/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.ac
index 0250f9b..5955b08 100644
--- 
a/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.ac
+++ 
b/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.ac
@@ -1 +1,3 @@
 AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
+
+dnl AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
diff --git 
a/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.in
 
b/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.in
index eeb7274..abfcac8 100644
--- 
a/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.in
+++ 
b/t/tests/cruft-autotools-pkg-config-macro-not-cross-compilation-safe/debian/configure.in
@@ -1 +1,3 @@
 AC_PATH_PROG(PKGCONFIG, pkg-config, no, $PATH:/usr/bin:/usr/local/bin)
+
+   dnl AC_PATH_PROG(PKG_CONFIG, pkg-config, no)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Processed: Re: Bug#886303: lintian: python-foo-but-no-python3-foo false positive

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 886303 + wontfix
Bug #886303 [lintian] lintian: python-foo-but-no-python3-foo false positive
Added tag(s) wontfix.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
886303: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886303
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (e00d723 -> 03879d3)

[Paul Wise]

This is an automated email from the git hooks/post-receive script.

pabs pushed a change to branch master
in repository lintian.

  from  e00d723   data/common/dbg-pkg: Identify both python-foo-dbg and 
python3-foo-dbg as known debug packages to avoid a false-positive for the 
former when checking for debian-control-has-obsolete-dbg-package. (Closes: 
#886271)
   new  03879d3   spelling: Add several corrections

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/spelling/corrections | 2 ++
 1 file changed, 2 insertions(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#886303: lintian: python-foo-but-no-python3-foo false positive

[Chris Lamb]

tags 886303 + wontfix
thanks

Hi Scott,
 
> There is no python3-qscintilla2, but there is python3-pyqt4.qsci

Getcha. However, this doesn't seem like a common case and weakening
the general case & making it a little more magic doesn't seem the best
approach IMHO. Indeed, it's almost a feature of the current test that
it is so "dumb" and thus easily understandable and explainable.

This case seems like a perfect case for an override, especially as that
provides a perfect place to explain the names of the package.

Naturally if we find many more examples we can revisit, but I don't think
we should change this right now. :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] 01/01: spelling: Add several corrections

[Paul Wise]

This is an automated email from the git hooks/post-receive script.

pabs pushed a commit to branch master
in repository lintian.

commit 03879d36d81f8a499d8407ae90bef0c91c679f76
Author: Paul Wise 
Date:   Thu Jan 4 16:46:21 2018 +0800

spelling: Add several corrections
---
 data/spelling/corrections | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/data/spelling/corrections b/data/spelling/corrections
index 2598a91..3766e87 100644
--- a/data/spelling/corrections
+++ b/data/spelling/corrections
@@ -883,6 +883,8 @@ connot||cannot
 conrtib||contrib
 consequtive||consecutive
 consequtively||consecutively
+consifer||consider
+consifered||considered
 consisent||consistent
 consisently||consistently
 consistancy||consistency

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git