Bug#892197: lintian: fpos for debian-changelog-line-too-short
Package: lintian Version: 2.5.78 Seen in devscripts: P: devscripts: debian-changelog-line-too-short ltnu: (line 4) P: devscripts: debian-changelog-line-too-short bts: (line 12) P: devscripts: debian-changelog-line-too-short ltnu: (line 15) P: devscripts: debian-changelog-line-too-short ltnu: (line 42) Now, they are all fpos, as that's just a heading containing the name of an existing program, and the lines after explains what's happened to them. I suggest to ignore lines ending with ':' for this tag. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
[lintian] 01/02: checks/cruft.pm: Add comment re. package name matching with package-does-not-install-examples.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit d6a074e3ec2977b31a30931bb8ad7a8897ba5fd3
Author: Chris Lamb
Date: Tue Mar 6 22:08:04 2018 -0800
checks/cruft.pm: Add comment re. package name matching with
package-does-not-install-examples.
---
checks/cruft.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/checks/cruft.pm b/checks/cruft.pm
index fe67d49..db21095 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -1572,6 +1572,7 @@ sub _ships_examples {
return 1 if not @procs;
foreach my $binpkg (@procs) {
my $name = $binpkg->pkg_name;
+# If we have an -examples package, assume we ship examples.
return 1 if $name =~ m{-examples$};
my @files = $binpkg->info->sorted_index;
return 1 if any { m{^usr/share/doc/$name/examples/$} } @files;
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] 02/02: Check all subdirectories under /usr/share/doc/foo to test whether we ship example files, not just /usr/share/doc/foo/examples/.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 9027b8319fb4635355abda605eb1fe929e982f2a
Author: Chris Lamb
Date: Tue Mar 6 22:15:26 2018 -0800
Check all subdirectories under /usr/share/doc/foo to test whether we ship
example files, not just /usr/share/doc/foo/examples/.
---
checks/cruft.pm | 2 +-
debian/changelog | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/checks/cruft.pm b/checks/cruft.pm
index db21095..5a7ef79 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -1575,7 +1575,7 @@ sub _ships_examples {
# If we have an -examples package, assume we ship examples.
return 1 if $name =~ m{-examples$};
my @files = $binpkg->info->sorted_index;
-return 1 if any { m{^usr/share/doc/$name/examples/$} } @files;
+return 1 if any { m{^usr/share/doc/$name/(.+/)?examples/$} } @files;
}
return;
}
diff --git a/debian/changelog b/debian/changelog
index a50b77e..774d88c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ lintian (2.5.79) UNRELEASED; urgency=medium
XXX: generate tag summary
+ * checks/cruft.pm:
++ [CL] Check all subdirectories under /usr/share/doc/foo to test
+ whether we ship example files, not just /usr/share/doc/foo/examples/.
* data/fields/obsolete-packages:
+ [PW] Add exim and apache, replaced by exim4 and apache2
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
[lintian] branch master updated (5ac393f -> 9027b83)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 5ac393f obsolete-packages: Add exim and apache, replaced by exim4 and apache2 new d6a074e checks/cruft.pm: Add comment re. package name matching with package-does-not-install-examples. new 9027b83 Check all subdirectories under /usr/share/doc/foo to test whether we ship example files, not just /usr/share/doc/foo/examples/. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/cruft.pm | 3 ++- debian/changelog | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Bug#892249: lintian: detect broken ftp://ftp.debian.org and ftp://security.debian.org links
Package: lintian Version: 2.5.78 Severity: wishlist Please detect packages that use the following links (or any subdirs): ftp://ftp.debian.org ftp://security.debian.org Debian dropped support for the FTP protocol on these sites last year: https://lists.debian.org/msgid-search/20170425131901.f64ltdn2p6677...@shiraz.lpma-paris.fr A list of packages affected can be found via codesearch: (this URL only works with JavaScript off) https://codesearch.debian.net/search?q=ftp%3A%2F%2F%28security%7Cftp%29%5C.debian%5C.org I assume lintian will not search through all files in the source package, but it could at least do the same as is done for the obsolete-sites tests. -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
[lintian] branch master updated (9027b83 -> a9155a4)
This is an automated email from the git hooks/post-receive script. lamby pushed a change to branch master in repository lintian. from 9027b83 Check all subdirectories under /usr/share/doc/foo to test whether we ship example files, not just /usr/share/doc/foo/examples/. new a9155a4 Ignore entries that end with ":" to avoid false-positives in the debian-changelog-line-too-short. Thanks to Mattia Rizollo for the report. (Closes: #892197) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: checks/changelog-file.pm | 2 +- debian/changelog | 4 t/tests/changelog-file-line-too-short/debian/debian/changelog.in | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
[lintian] 01/01: Ignore entries that end with ":" to avoid false-positives in the debian-changelog-line-too-short. Thanks to Mattia Rizollo for the report. (Closes: #892197)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit a9155a48d209260d3c3377cd45c5bece490c5861
Author: Chris Lamb
Date: Tue Mar 6 22:43:42 2018 -0800
Ignore entries that end with ":" to avoid false-positives in the
debian-changelog-line-too-short. Thanks to Mattia Rizollo for the report.
(Closes: #892197)
---
checks/changelog-file.pm | 2 +-
debian/changelog | 4
t/tests/changelog-file-line-too-short/debian/debian/changelog.in | 3 +++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/checks/changelog-file.pm b/checks/changelog-file.pm
index 7dd61c9..aa5331f 100644
--- a/checks/changelog-file.pm
+++ b/checks/changelog-file.pm
@@ -484,7 +484,7 @@ sub run {
for my $i (0 .. $#lines) {
my $line = $i + $chloff;
tag 'debian-changelog-line-too-short', $1, "(line $line)"
- if $lines[$i] =~ /^ [*]\s(.{1,5})$/;
+ if $lines[$i] =~ /^ [*]\s(.{1,5})$/ and $1 !~ /:$/;
if (length($lines[$i]) > 81
and $lines[$i] !~ /^[\s.o*+-]*(?:[Ss]ee:?\s+)?\S+$/) {
tag 'debian-changelog-line-too-long', "line $line";
diff --git a/debian/changelog b/debian/changelog
index 774d88c..8b74ebd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,10 @@ lintian (2.5.79) UNRELEASED; urgency=medium
XXX: generate tag summary
+ * checks/changelog-file.pm:
++ [CL] Ignore entries that end with ":" to avoid false-positives in the
+ debian-changelog-line-too-short. Thanks to Mattia Rizollo for the
+ report. (Closes: #892197)
* checks/cruft.pm:
+ [CL] Check all subdirectories under /usr/share/doc/foo to test
whether we ship example files, not just /usr/share/doc/foo/examples/.
diff --git a/t/tests/changelog-file-line-too-short/debian/debian/changelog.in
b/t/tests/changelog-file-line-too-short/debian/debian/changelog.in
index 2ba39b5..f268979 100644
--- a/t/tests/changelog-file-line-too-short/debian/debian/changelog.in
+++ b/t/tests/changelog-file-line-too-short/debian/debian/changelog.in
@@ -11,4 +11,7 @@
* dh 11.
* 123456
+ * These are false positives.
+ * 123:
+
-- {$author} {$date}
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/lintian/lintian.git
Processed: Re: lintian: fpos for debian-changelog-line-too-short
Processing commands for cont...@bugs.debian.org: > tags 892197 + pending Bug #892197 [lintian] lintian: fpos for debian-changelog-line-too-short Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 892197: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892197 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#892197: lintian: fpos for debian-changelog-line-too-short
tags 892197 + pending thanks Fixed in Git, pending upload: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=a9155a48d209260d3c3377cd45c5bece490c5861 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Re: [lintian] 02/02: Check all subdirectories under /usr/share/doc/foo to test whether we ship example files, not just /usr/share/doc/foo/examples/.
Chris Lamb:
> This is an automated email from the git hooks/post-receive script.
>
> lamby pushed a commit to branch master
> in repository lintian.
>
> commit 9027b8319fb4635355abda605eb1fe929e982f2a
> Author: Chris Lamb
> Date: Tue Mar 6 22:15:26 2018 -0800
>
> Check all subdirectories under /usr/share/doc/foo to test whether we ship
> example files, not just /usr/share/doc/foo/examples/.
> ---
> checks/cruft.pm | 2 +-
> debian/changelog | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/checks/cruft.pm b/checks/cruft.pm
> index db21095..5a7ef79 100644
> --- a/checks/cruft.pm
> +++ b/checks/cruft.pm
> @@ -1575,7 +1575,7 @@ sub _ships_examples {
> # If we have an -examples package, assume we ship examples.
> return 1 if $name =~ m{-examples$};
> my @files = $binpkg->info->sorted_index;
> -return 1 if any { m{^usr/share/doc/$name/examples/$} } @files;
> +return 1 if any { m{^usr/share/doc/$name/(.+/)?examples/$} } @files;
^
While you are updating that code path, could you add the missing the \Q
\E around that $name (or quotemeta)? Otherwise we get incorrect results
for packages like "g++" (interpreted as "1 or more instances of the
letter g" rather than "literally g++").
I believe this is a reoccurring problem in the code base, so you will
probably notice it elsewhere as well.
Thanks,
~Niels
