[lintian] branch unique created (now 642508b)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch unique
in repository lintian.

at  642508b   Detect if license-short-name are unique in source 
copyright

This branch includes the following new commits:

   new  642508b   Detect if license-short-name are unique in source 
copyright

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch utf8fix created (now c163818)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch utf8fix
in repository lintian.

at  c163818   read_dpkg_control using utf8

This branch includes the following new commits:

   new  7c1c056   Read file as a whole for utf8 testing
   new  c163818   read_dpkg_control using utf8

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpmaster2 created (now 87eafe4)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpmaster2
in repository lintian.

at  87eafe4   Correct grammar of fixme-placeholders test.

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpy created (now e60c9ad)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpy
in repository lintian.

at  e60c9ad   Warn if debian/watch uses deprecated 
githubredir.debian.net scraper

This branch includes the following new commits:

   new  e60c9ad   Warn if debian/watch uses deprecated 
githubredir.debian.net scraper

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpmove created (now 1a1cbf9)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpmove
in repository lintian.

at  1a1cbf9   export $COMPRESS_FILE_EXTENSIONS_OR_ALL a list of all 
compressed extension.

This branch includes the following new commits:

   new  1a1cbf9   export $COMPRESS_FILE_EXTENSIONS_OR_ALL a list of all 
compressed extension.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpmaster created (now aaa7841)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpmaster
in repository lintian.

at  aaa7841   Add github icons as privacy breach logo

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpjs created (now aef82ec)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpjs
in repository lintian.

at  aef82ec   Fix a flase positive in missing dir handling

This branch includes the following new commits:

   new  aef82ec   Fix a flase positive in missing dir handling

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpj created (now 88b05b7)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpj
in repository lintian.

at  88b05b7   Improve description of 
dep5-copyright-license-name-not-unique

This branch includes the following new commits:

   new  88b05b7   Improve description of 
dep5-copyright-license-name-not-unique

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpjj created (now 139ed0b)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpjj
in repository lintian.

at  139ed0b   Warn if debian/watch uses deprecated 
githubredir.debian.net scraper

This branch includes the following new commits:

   new  139ed0b   Warn if debian/watch uses deprecated 
githubredir.debian.net scraper

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmph created (now 1c0ffac)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmph
in repository lintian.

at  1c0ffac   Check also arch:all config script

This branch includes the following new commits:

   new  1c0ffac   Check also arch:all config script

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmpe created (now 3bc2cdc)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmpe
in repository lintian.

at  3bc2cdc   Improve speed of privacy check

This branch includes the following new commits:

   new  88732a9   test
   new  3bc2cdc   Improve speed of privacy check

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmp5 created (now a68519b)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmp5
in repository lintian.

at  a68519b   Detect package shipping apt sources

This branch includes the following new commits:

   new  bbac77c   Raise severity of package-contains-timestamped-gzip.
   new  a68519b   Detect package shipping apt sources

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmp4 created (now 921060b)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmp4
in repository lintian.

at  921060b   Detect oui db in source file

This branch includes the following new commits:

   new  2115c4e   Detect embdedded ieee-data package
   new  921060b   Detect oui db in source file

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch test2 created (now fe27e04)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch test2
in repository lintian.

at  fe27e04   Detect files pointing to builddir

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmp2 created (now 15f161d)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmp2
in repository lintian.

at  15f161d   Release Lintian/2.5.23.1 into unstable

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmp3 created (now 784250e)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmp3
in repository lintian.

at  784250e   Fix False positive for 
space-in-std-shortname-in-dep5-copyright with alternative licenses

This branch includes the following new commits:

   new  784250e   Fix False positive for 
space-in-std-shortname-in-dep5-copyright with alternative licenses

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/02: Merge branch 'master' of git://git.debian.org/git/lintian/lintian

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch test
in repository lintian.

commit b7d7d3c77139f0cc34fa3b8f48324009a57e0494
Merge: 4c5f38f 98b6760
Author: Tomasz Buchert 
Date:   Mon Jul 14 14:41:52 2014 +0200

Merge branch 'master' of git://git.debian.org/git/lintian/lintian

Signed-off-by: Bastien ROUCARIÈS 


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tmp created (now 5c1211a)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tmp
in repository lintian.

at  5c1211a   Detect -dbgsym file in control file

This branch includes the following new commits:

   new  5c1211a   Detect -dbgsym file in control file

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch temp2 created (now 715c4cc)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch temp2
in repository lintian.

at  715c4cc   Raise to error some warnings

This branch includes the following new commits:

   new  715c4cc   Raise to error some warnings

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch temp created (now 482bc90)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch temp
in repository lintian.

at  482bc90   Raise to error some warnings

This branch includes the following new commits:

   new  482bc90   Raise to error some warnings

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch symlink created (now 5e4bb9c)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch symlink
in repository lintian.

at  5e4bb9c   t/tests/java-*: Require a recent enough java version

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch pre2.6.25 created (now c9f7a41)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch pre2.6.25
in repository lintian.

at  c9f7a41   Fix another false positive for minified source-is-missing

This branch includes the following new commits:

   new  c9f7a41   Fix another false positive for minified source-is-missing

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch searchindex.js created (now 5c1d6bb)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch searchindex.js
in repository lintian.

at  5c1d6bb   Add myself as author of cruft

No new revisions were added by this update.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch tagrename created (now ab1af5d)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch tagrename
in repository lintian.

at  ab1af5d   Warn about renamed tag

This branch includes the following new commits:

   new  f7dbaff   Allow tag to be renamed
   new  8fc290d   Rename variable $tag to $rawtag in order to clarify code
   new  ab1af5d   Warn about renamed tag

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch sl created (now c5ab10b)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch sl
in repository lintian.

at  c5ab10b   Use a sliding window match for pkg-config file

This branch includes the following new commits:

   new  c5ab10b   Use a sliding window match for pkg-config file

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch patchdep3template created (now 11a689c)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch patchdep3template
in repository lintian.

at  11a689c   Detect templated text on quilt patch

This branch includes the following new commits:

   new  11a689c   Detect templated text on quilt patch

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch newbranch created (now b161d2b)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch newbranch
in repository lintian.

at  b161d2b   check all

This branch includes the following new commits:

   new  3260233   Word wrap mail template
   new  b161d2b   check all

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch pedanticgfdlvariant created (now 14c7b6d)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch pedanticgfdlvariant
in repository lintian.

at  14c7b6d   Warm about non official wording of gfdl

This branch includes the following new commits:

   new  14c7b6d   Warm about non official wording of gfdl

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch php created (now 14e20b3)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch php
in repository lintian.

at  14e20b3   php

This branch includes the following new commits:

   new  14e20b3   php

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/02: Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless as obsolete (See #720911).

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch masterold
in repository lintian.

commit 5593d2c88f7c546c156f14341910bc3216c94400
Author: Sylvestre Ledru 
Date:   Tue Nov 26 16:17:28 2013 +0100

Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless as obsolete 
(See #720911).

Detect when the package build dep on java-compiler.

[BR] Improve wordings of checks/java.desc
[BR] Move description to checks/fields.desc
---
 checks/fields.desc   | 6 ++
 checks/fields.pm | 5 +
 data/fields/obsolete-packages| 5 +
 debian/changelog | 5 +
 t/tests/fields-java/debian/debian/control.in | 2 +-
 t/tests/fields-java/tags | 4 
 6 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index 8751018..0989add 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -587,6 +587,12 @@ Info: The package declares a build-depends on an essential 
package, e.g. dpkg,
  is if you need a particular version of that package, in which case the
  version should be given in the dependency.
 
+Tag: build-depends-on-an-obsolete-java-package
+Severity: normal
+Certainty: certain
+Info: The package build-depends on an obsolete java dependency.
+ It should built-depends on default-jdk instead.
+
 Tag: build-depends-on-non-build-package
 Severity: important
 Certainty: certain
diff --git a/checks/fields.pm b/checks/fields.pm
index 2d103fb..e41cccf 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -974,6 +974,11 @@ sub run {
   $d_pkg;
 }
 
+if (   $d_pkg =~ m/^java-compiler$/o){
+tag 'build-depends-on-an-obsolete-java-package',
+  $d_pkg;
+}
+
 if ($d_pkg =~ m/^libdb\d+\.\d+.*-dev$/o
 and &$is_dep_field($field)) {
 tag 'build-depends-on-versioned-berkeley-db',
diff --git a/data/fields/obsolete-packages b/data/fields/obsolete-packages
index c70a2a0..64595de 100644
--- a/data/fields/obsolete-packages
+++ b/data/fields/obsolete-packages
@@ -80,3 +80,8 @@ automake1.7
 automake1.8
 automake1.9
 automake1.10
+
+# Deprecated in Jessie (#720911)
+openjdk-6-jdk
+openjdk-6-jre
+openjdk-6-jre-headless
diff --git a/debian/changelog b/debian/changelog
index 272c4d8..5a3090c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,9 @@ lintian (2.5.20) UNRELEASED; urgency=low
   license.  (Closes: #724930)
 + [BR] Abstract sliding window algorithm and use it for
   license check.  (Closes: #720348)
+  * checks/fields.pm:
++ [SL] Returns a warning when a package build-deps on java-compiler
+  instead of default-jdk.
   * checks/files.desc
 + [BR] Improve description of pkg-config-multi-arch-wrong-dir
   tag. Add debhelper > 9 on non multi-arched package as a likely
@@ -20,6 +23,8 @@ lintian (2.5.20) UNRELEASED; urgency=low
   * data/fields/obsolete-packages:
 + [NT] Apply patch from Eric Dorland to mark various versions
   of automake as obsolete.
++ [SL] Tag openjdk-6-jdk, openjdk-6-jre and openjdk-6-jre-headless
+  as obsolete (See ##720911)
   * data/fields/virtual-packages:
 + [NT] Refresh against sid.  Thanks to Nicholas Breen for the
   reminder.  (Closes: #724866)
diff --git a/t/tests/fields-java/debian/debian/control.in 
b/t/tests/fields-java/debian/debian/control.in
index 2b8801d..5125554 100644
--- a/t/tests/fields-java/debian/debian/control.in
+++ b/t/tests/fields-java/debian/debian/control.in
@@ -3,7 +3,7 @@ Priority: extra
 Section: java
 Maintainer: {$author}
 Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 9), openjdk-6-doc
+Build-Depends: debhelper (>= 9), openjdk-6-doc, openjdk-6-jdk, java-compiler
 
 Package: lib{$source}-java
 Architecture: all
diff --git a/t/tests/fields-java/tags b/t/tests/fields-java/tags
index 7080a0f..77ba9af 100644
--- a/t/tests/fields-java/tags
+++ b/t/tests/fields-java/tags
@@ -1,4 +1,8 @@
+E: fields-java source: build-depends-on-obsolete-package build-depends: 
openjdk-6-jdk
 I: libfields-java-java: javalib-but-no-public-jars
+I: libfields-java-java: ored-depends-on-obsolete-package depends: openjdk-6-jre
+W: fields-java source: build-depends-on-an-obsolete-java-package java-compiler
 W: fields-java source: build-depends-on-specific-java-doc-package openjdk-6-doc
+W: fields-java source: virtual-package-depends-without-real-package-depends 
build-depends: java-compiler
 W: libfields-java-java-doc: depends-on-specific-java-doc-package recommends
 W: libfields-java-java: needless-dependency-on-jre

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch masterold created (now 5593d2c)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch masterold
in repository lintian.

at  5593d2c   Tag openjdk-6-jdk, openjdk-6-jre and 
openjdk-6-jre-headless as obsolete (See #720911).

This branch includes the following new commits:

   new  c7f4741   Add supress => suppress in the list of spelling mistakes
   new  5593d2c   Tag openjdk-6-jdk, openjdk-6-jre and 
openjdk-6-jre-headless as obsolete (See #720911).

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch gfdlrevision created (now 87949c6)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch gfdlrevision
in repository lintian.

at  87949c6   Add a few new path forbidden

This branch includes the following new commits:

   new  7ba4c3a   Improve cruft license check by using a sliding window and 
detect gfdl
   new  87949c6   Add a few new path forbidden

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch cc-by-sa created (now ad3e62b)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch cc-by-sa
in repository lintian.

at  ad3e62b   Detect cc-by-nc-sa

This branch includes the following new commits:

   new  ad3e62b   Detect cc-by-nc-sa

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch gfdlfixup created (now b64b28a)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch gfdlfixup
in repository lintian.

at  b64b28a   Improve specificity of gfdl tagging of example

This branch includes the following new commits:

   new  b64b28a   Improve specificity of gfdl tagging of example

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch fonthint created (now ffd2c0c)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch fonthint
in repository lintian.

at  ffd2c0c   Add detecting of adobe proprietary font hinting

This branch includes the following new commits:

   new  ffd2c0c   Add detecting of adobe proprietary font hinting

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch fixlintian created (now 01435bc)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch fixlintian
in repository lintian.

at  01435bc   Fix lintian spurious warning

This branch includes the following new commits:

   new  01435bc   Fix lintian spurious warning

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch autogen created (now 973a7f9)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch autogen
in repository lintian.

at  973a7f9   Detect autogenerated microsoft visual c++ file

This branch includes the following new commits:

   new  973a7f9   Detect autogenerated microsoft visual c++ file

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch binariesPIC created (now 402a964)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch binariesPIC
in repository lintian.

at  402a964   Try to get static binaries

This branch includes the following new commits:

   new  402a964   Try to get static binaries

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (8c41c05 -> 221f36d)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch master
in repository lintian.

  from  8c41c05   Node- package should go to section javascript
   new  60fc451   Add a statistic tag for script interpreter
   new  221f36d   Bump ancient time

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/scripts.desc   | 5 +
 checks/scripts.pm | 3 +++
 data/standards-version/ancient-date   | 2 +-
 debian/changelog  | 1 +
 t/tests/scripts-does-not-start-with-shebang/tags  | 3 +++
 t/tests/scripts-maintainer-script-classification/desc | 1 +
 t/tests/scripts-maintainer-script-classification/tags | 1 +
 7 files changed, 15 insertions(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Warn if debian/watch uses deprecated githubredir.debian.net scraper

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch tmpy
in repository lintian.

commit e60c9ad0259cced3aed5a0984258fa475268bd29
Author: Chris Lamb 
Date:   Sun Jan 3 14:30:20 2016 +0100

Warn if debian/watch uses deprecated githubredir.debian.net scraper

Signed-off-by: Chris Lamb 
---
 checks/watch-file.desc | 13 +
 checks/watch-file.pm   |  4 
 debian/changelog   |  8 ++--
 t/tests/watch-file-general/debian/debian/watch |  5 -
 t/tests/watch-file-general/desc|  1 +
 t/tests/watch-file-general/tags|  2 ++
 6 files changed, 30 insertions(+), 3 deletions(-)

diff --git a/checks/watch-file.desc b/checks/watch-file.desc
index 1b66da7..1ae2a8a 100644
--- a/checks/watch-file.desc
+++ b/checks/watch-file.desc
@@ -116,6 +116,19 @@ Info: The watch file specifies a SourceForge page or 
download server
  project and tar-name with the name of the tarball
  distributed within that project.  Adjust the filename regex as necessary.
 
+Tag: debian-watch-file-uses-deprecated-githubredir
+Severity: important
+Certainty: certain
+Ref: https://lists.debian.org/debian-devel-announce/2014/10/msg0.html
+Info: The watch file specifies a githubredir.debia.net URL, which is deprecated
+ Instead, use direct links to the tags page:
+ .
+  version=3
+  https://github.com/user/project/tags .*/(.*)\.tar\.gz
+ .
+ replacing user and project with the Github
+ username and project respectfully.
+
 Tag: debian-watch-file-specifies-wrong-upstream-version
 Severity: normal
 Certainty: certain
diff --git a/checks/watch-file.pm b/checks/watch-file.pm
index 46ab633..737c25b 100644
--- a/checks/watch-file.pm
+++ b/checks/watch-file.pm
@@ -122,6 +122,10 @@ sub run {
 if (m,\b\Qhttp://pypi.python.org/\E,) {
 tag 'debian-watch-file-accesses-pypi-over-http', "line $.";
 }
+if (m%githubredir\.debian\.net%) {
+tag 'debian-watch-file-uses-deprecated-githubredir',
+  "line $.";
+}
 
 if (
 m{ (?:https?|ftp)://
diff --git a/debian/changelog b/debian/changelog
index 60eafe9..69c6892 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,12 +10,16 @@ lintian (2.5.40) UNRELEASED; urgency=medium
   checks.  Thanks to Aurelien Jarno for the bug report.  (Closes:
   #809262)
 + [BR] Detect old style config script and detect Mutli-arch error.
-  * checks/source-copyright.desc:
+  * checks/source-copyright.{desc,pm}:
 + [JW] Apply patch from Mattia Rizzolo to update the machine-readable
   copyright format specification URL.  (Closes: #809248)
 + [BR] Improve description text of tag
-   dep5-copyright-license-name-not-unique.
+  dep5-copyright-license-name-not-unique.
   (Closes: #809651).
+   * checks/watch-file.{desc,pm}:
++ [BR] Apply patch from Chris Lamb ,
+  warn if debian/watch uses deprecated
+  githubredir.debian.net scraper (Closes: #803106).
 
   * data/spelling/corrections*:
 + [JW] Add more corrections.
diff --git a/t/tests/watch-file-general/debian/debian/watch 
b/t/tests/watch-file-general/debian/debian/watch
index 71b4717..e322710 100644
--- a/t/tests/watch-file-general/debian/debian/watch
+++ b/t/tests/watch-file-general/debian/debian/watch
@@ -26,4 +26,7 @@ http://pypi.python.org/foo scripts\.([\d.]+)\.tar\.gz debian 
uupdate
 # Unsupported PyPI URL.
 https://pypi.python.org/packages/source/p/pip/ pip-(\S+)\.tar\.gz
 
-# without any pgpsigurlmangle
\ No newline at end of file
+# Deprecated githubredir
+http://githubredir.debian.net/github/username/project /(.*).tar.gz
+
+# without any pgpsigurlmangle
diff --git a/t/tests/watch-file-general/desc b/t/tests/watch-file-general/desc
index 64d09c9..0e7a20e 100644
--- a/t/tests/watch-file-general/desc
+++ b/t/tests/watch-file-general/desc
@@ -15,5 +15,6 @@ Test-For:
  debian-watch-file-unknown-version
  debian-watch-file-unsupported-pypi-url
  debian-watch-file-uses-deprecated-sf-redirector-method
+ debian-watch-file-uses-deprecated-githubredir
  debian-watch-may-check-gpg-signature
 References: Debian Bug#510398
diff --git a/t/tests/watch-file-general/tags b/t/tests/watch-file-general/tags
index a80f45b..1c54f22 100644
--- a/t/tests/watch-file-general/tags
+++ b/t/tests/watch-file-general/tags
@@ -1,4 +1,5 @@
 E: watch-file-general source: debian-watch-file-unsupported-pypi-url line 27
+E: watch-file-general source: debian-watch-file-uses-deprecated-githubredir 
line 30
 I: watch-file-general source: debian-watch-file-accesses-pypi-over-http line 24
 I: watch-file-general source: 
debian-watch-file-should-dversionmangle-not-uversionmangle line 5
 P: watch-file-general source: debian-watch-may-check-gpg-signature
@@ -8,6 +9,7 @@ W: watch-file-general source: 

[lintian] 01/01: Warn if debian/watch uses deprecated githubredir.debian.net scraper

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch tmpjj
in repository lintian.

commit 139ed0bef309b9a59c21a503727609731c06d797
Author: Chris Lamb 
Date:   Sun Jan 3 14:30:20 2016 +0100

Warn if debian/watch uses deprecated githubredir.debian.net scraper

Signed-off-by: Chris Lamb 
---
 checks/watch-file.desc | 13 +
 checks/watch-file.pm   |  4 
 debian/changelog   |  2 +-
 t/tests/watch-file-general/debian/debian/watch |  5 -
 t/tests/watch-file-general/desc|  1 +
 t/tests/watch-file-general/tags|  2 ++
 6 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/checks/watch-file.desc b/checks/watch-file.desc
index 1b66da7..1ae2a8a 100644
--- a/checks/watch-file.desc
+++ b/checks/watch-file.desc
@@ -116,6 +116,19 @@ Info: The watch file specifies a SourceForge page or 
download server
  project and tar-name with the name of the tarball
  distributed within that project.  Adjust the filename regex as necessary.
 
+Tag: debian-watch-file-uses-deprecated-githubredir
+Severity: important
+Certainty: certain
+Ref: https://lists.debian.org/debian-devel-announce/2014/10/msg0.html
+Info: The watch file specifies a githubredir.debia.net URL, which is deprecated
+ Instead, use direct links to the tags page:
+ .
+  version=3
+  https://github.com/user/project/tags .*/(.*)\.tar\.gz
+ .
+ replacing user and project with the Github
+ username and project respectfully.
+
 Tag: debian-watch-file-specifies-wrong-upstream-version
 Severity: normal
 Certainty: certain
diff --git a/checks/watch-file.pm b/checks/watch-file.pm
index 46ab633..737c25b 100644
--- a/checks/watch-file.pm
+++ b/checks/watch-file.pm
@@ -122,6 +122,10 @@ sub run {
 if (m,\b\Qhttp://pypi.python.org/\E,) {
 tag 'debian-watch-file-accesses-pypi-over-http', "line $.";
 }
+if (m%githubredir\.debian\.net%) {
+tag 'debian-watch-file-uses-deprecated-githubredir',
+  "line $.";
+}
 
 if (
 m{ (?:https?|ftp)://
diff --git a/debian/changelog b/debian/changelog
index 60eafe9..15bf199 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,7 +14,7 @@ lintian (2.5.40) UNRELEASED; urgency=medium
 + [JW] Apply patch from Mattia Rizzolo to update the machine-readable
   copyright format specification URL.  (Closes: #809248)
 + [BR] Improve description text of tag
-   dep5-copyright-license-name-not-unique.
+  dep5-copyright-license-name-not-unique.
   (Closes: #809651).
 
   * data/spelling/corrections*:
diff --git a/t/tests/watch-file-general/debian/debian/watch 
b/t/tests/watch-file-general/debian/debian/watch
index 71b4717..e322710 100644
--- a/t/tests/watch-file-general/debian/debian/watch
+++ b/t/tests/watch-file-general/debian/debian/watch
@@ -26,4 +26,7 @@ http://pypi.python.org/foo scripts\.([\d.]+)\.tar\.gz debian 
uupdate
 # Unsupported PyPI URL.
 https://pypi.python.org/packages/source/p/pip/ pip-(\S+)\.tar\.gz
 
-# without any pgpsigurlmangle
\ No newline at end of file
+# Deprecated githubredir
+http://githubredir.debian.net/github/username/project /(.*).tar.gz
+
+# without any pgpsigurlmangle
diff --git a/t/tests/watch-file-general/desc b/t/tests/watch-file-general/desc
index 64d09c9..0e7a20e 100644
--- a/t/tests/watch-file-general/desc
+++ b/t/tests/watch-file-general/desc
@@ -15,5 +15,6 @@ Test-For:
  debian-watch-file-unknown-version
  debian-watch-file-unsupported-pypi-url
  debian-watch-file-uses-deprecated-sf-redirector-method
+ debian-watch-file-uses-deprecated-githubredir
  debian-watch-may-check-gpg-signature
 References: Debian Bug#510398
diff --git a/t/tests/watch-file-general/tags b/t/tests/watch-file-general/tags
index a80f45b..1c54f22 100644
--- a/t/tests/watch-file-general/tags
+++ b/t/tests/watch-file-general/tags
@@ -1,4 +1,5 @@
 E: watch-file-general source: debian-watch-file-unsupported-pypi-url line 27
+E: watch-file-general source: debian-watch-file-uses-deprecated-githubredir 
line 30
 I: watch-file-general source: debian-watch-file-accesses-pypi-over-http line 24
 I: watch-file-general source: 
debian-watch-file-should-dversionmangle-not-uversionmangle line 5
 P: watch-file-general source: debian-watch-may-check-gpg-signature
@@ -8,6 +9,7 @@ W: watch-file-general source: 
debian-watch-file-should-mangle-version line 12
 W: watch-file-general source: debian-watch-file-should-mangle-version line 14
 W: watch-file-general source: debian-watch-file-should-mangle-version line 15
 W: watch-file-general source: debian-watch-file-should-mangle-version line 27
+W: watch-file-general source: debian-watch-file-should-mangle-version line 30
 W: watch-file-general source: debian-watch-file-should-use-sf-redirector line 
12
 W: watch-file-general source: 

Re: debian/upstream/signing-key.asc in policy 4.1.0

[Osamu Aoki]

Hi,

On Wed, Aug 23, 2017 at 09:27:25AM -0700, Russ Allbery wrote:
> Osamu Aoki  writes:
> > The updated uscan will support debian/upstream/signing-key.asc only and
> > internally convert it /signing-key.gpg.  I will make uscan to
> > convert other formats to this policy compliant *.asc.  Also make noise
> > to the maintainer to push them to policy 4.1.0
> 
> Note that this Policy language is carefully written to make it perfectly
> fine for uscan to support all the things it currently supports, since it
> only talks about what Policy recommends the maintainer does.  So don't
> feel any obligation to change what uscan is doing on Policy's account
> here.

Maybe I should have been a bit careful with my words:

The updated uscan will support debian/upstream/signing-key.asc only as
the recommended keyring.  It will accept other historic keyrings but
also internally converts them to /signing-key.gpg to guide
people to the new recommended format with some reminder noise.

> That said, as discussed elsewhere, I'm a huge fan of there being only one
> way to do something like this, with some easy tools to convert other
> methods into that one method.  It reduces everyone's cognitive load in the
> future.

Yes.

Osamu

Bug#873323: lintian -- False positives on copyright-year-in-future

[Thorsten Alteholz]

Package: lintian
Version: 2.5.52
Severity: normal


The license of package oysttyer contains an example, which gives a false 
positive for "copyright-year-in-future":

* If you choose to create and distribute a derivative work based on
   this package, your derivative work must clearly make reference to
   this package, any other packages your work or the original work
   might be based on, and all applicable copyrights, either in your
   documentation, your work's standard human-readable output, or both.
   A suggested method might be

 Contains or is based on the Foo software package.
 Copyright (C) 2112 D. Original Author. All rights reserved.
 http://their.web.site.invalid/

 Thorsten

Jenkins build is back to normal : lintian-tests_sid #1873

[jenkins]

See 

[lintian] branch master updated (64e679b -> 8c41c05)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch master
in repository lintian.

  from  64e679b   Tidy gramma of some changelog entries.
   new  f03634d   Revert "Node- package should go to section javascript"
   new  c64a1f8   Revert "Use Lintian::Data for section/name mapping"
   new  bc97e6c   Add storage qualifier to Lintian::Data
   new  988b493   Allow ordered type for Lintian::Data
   new  d0f7559   Move to Lintian::Data section name mapping
   new  8c41c05   Node- package should go to section javascript

The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/fields.pm  | 14 --
 data/fields/name_section_mappings |  8 +---
 debian/control|  2 ++
 lib/Lintian/Data.pm   | 27 ---
 4 files changed, 39 insertions(+), 12 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_sid #1872

[jenkins]

See 


Changes:

[lamby] Tidy gramma of some changelog entries.

--
[...truncated 254.27 KB...]
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u144-b01-1) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/xjc to provide 
/usr/bin/xjc (xjc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/schemagen to 
provide /usr/bin/schemagen (schemagen) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jps to provide 
/usr/bin/jps (jps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/extcheck to 
provide /usr/bin/extcheck (extcheck) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jmap to 
provide /usr/bin/jmap (jmap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstatd to 
provide /usr/bin/jstatd (jstatd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdb to provide 
/usr/bin/jdb (jdb) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/serialver to 
provide /usr/bin/serialver (serialver) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsgen to 
provide /usr/bin/wsgen (wsgen) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jcmd to 
provide /usr/bin/jcmd (jcmd) in auto mode
update-alternatives: using 

Re: [lintian] 01/02: Use Lintian::Data for section/name mapping

[Bastien Roucaries]

Le 26 août 2017 08:59:00 GMT+02:00, Niels Thykier  a écrit :
>Bastien Roucariès:
>> This is an automated email from the git hooks/post-receive script.
>> 
>> rouca pushed a commit to branch master
>> in repository lintian.
>> 
>> commit f71f3901fcc23db666d3de176526e91fd4f228a2
>> Author: Bastien ROUCARIÈS 
>> Date:   Fri Aug 25 22:22:39 2017 +0200
>> 
>> Use Lintian::Data for section/name mapping
>
>
>Hi,
>
>This change causes a regression that need to be fixed (or the commit
>reverted)

will fix: what do you prefer : fix regex or fix lintian data to keep ordoring ?

>The problem being that @NAME_SECTION_MAPPINGS is an /ordered/ list with
>a "first match and we are done"-rule.  When migrated to L::Data, this
>order is lost because L::Data does not have an order guarantee.
>
>Therefore, when multiple rules match (see [1] for an example), the
>previous code would give a well-defined result (first rule listed)
>whereas the new code gives a non-deterministic result.
>
>Thanks,
>~Niels
>
>[1]
>
>libfoo-ocaml-dev matches the following two rules
>
>[qr/^lib.*-(?:ocaml|camlp4)-dev$/ => 'ocaml'],
>[qr/^lib.*-dev$/  => 'libdevel'],
>
>> ---
>>  checks/fields.pm  | 34
>+-
>>  data/fields/name_section_mappings | 16 
>>  debian/changelog  |  1 +
>>  3 files changed, 30 insertions(+), 21 deletions(-)
>> 
>> diff --git a/checks/fields.pm b/checks/fields.pm
>> index cb91491..4ad96ad 100644
>> --- a/checks/fields.pm
>> +++ b/checks/fields.pm
>> @@ -96,23 +96,14 @@ our @known_java_pkg = map { qr/$_/ } (
>>  );
>>  
>>  # Mapping of package names to section names
>> -my @NAME_SECTION_MAPPINGS = (
>> -[qr/-docs?$/  => 'doc'],
>> -[qr/-dbg(?:sym)?$/=> 'debug'],
>> -[qr/^(?:python-)?zope/=> 'zope'],
>> -[qr/^python3?-/   => 'python'],
>> -[qr/^r-(?:cran|bioc|other)-/  => 'gnu-r'],
>> -[qr/^lib.*-perl$/ => 'perl'],
>> -[qr/^lib.*-cil(?:-dev)?$/ => 'cli-mono'],
>> -[qr/^lib.*-(?:java|gcj)$/ => 'java'],
>> -[qr/^(?:lib)php-/ => 'php'],
>> -[qr/^lib(?:hugs|ghc6?)-/  => 'haskell'],
>> -[qr/^lib.*-ruby(?:1\.\d)?$/   => 'ruby'],
>> -[qr/^lib.*-(?:ocaml|camlp4)-dev$/ => 'ocaml'],
>> -[qr/^lib.*-dev$/  => 'libdevel'],
>> -[qr/^gir\d+\.\d+-.*-\d+\.\d+$/=> 'introspection'],
>> -[qr/^libjs-/  => 'javascript'],
>> -);
>> +my $NAME_SECTION_MAPPINGS = Lintian::Data->new(
>> +'fields/name_section_mappings',
>> +qr/\s*=>\s*/,
>> +sub {
>> +my $regex = qr/$_[0]/x;
>> +$_[0] = $_[1];
>> +return $regex;
>> +});
>>  
>>  my %VCS_EXTRACT = (
>>  browser => sub { return @_;},
>> @@ -547,14 +538,15 @@ sub run {
>>  # Check package name <-> section.  oldlibs is a special
>case; let
>>  # anything go there.
>>  if ($parts[-1] ne 'oldlibs') {
>> -foreach my $map (@NAME_SECTION_MAPPINGS) {
>> -next unless ($pkg =~ $map->[0]);
>> +foreach my $section ($NAME_SECTION_MAPPINGS->all())
>{
>> +my $regex =
>$NAME_SECTION_MAPPINGS->value($section);
>> +next unless ($pkg =~ m{$regex});
>>  
>>  my $area = '';
>>  $area = "$parts[0]/" if (scalar @parts == 2);
>>  tag 'wrong-section-according-to-package-name',
>> -  "$pkg => ${area}$map->[1]"
>> -  unless $parts[-1] eq $map->[1];
>> +  "$pkg => ${area}$section"
>> +  unless $parts[-1] eq $section;
>>  last;
>>  }
>>  }
>> diff --git a/data/fields/name_section_mappings
>b/data/fields/name_section_mappings
>> new file mode 100644
>> index 000..ca9c1de
>> --- /dev/null
>> +++ b/data/fields/name_section_mappings
>> @@ -0,0 +1,16 @@
>> +# map between regex (x) of package => section
>> +-docs?$  => doc
>> +-dbg(?:sym)?$=> debug
>> +^(?:python-)?zope=> zope
>> +^python3?-   => python
>> +^r-(?:cran|bioc|other)-  => gnu-r
>> +^lib.*-perl$ => perl
>> +lib.*-cil(?:-dev)?$  => cli-mono
>> +^lib.*-(?:java|gcj)$ => java
>> +^(?:lib)php- => php
>> +^lib(?:hugs|ghc6?)-  => haskell
>> +^lib.*-ruby(?:1\.\d)?$   => ruby
>> +^lib.*-(?:ocaml|camlp4)-dev$ => ocaml
>> +^lib.*-dev$  => libdevel
>> +^gir\d+\.\d+-.*-\d+\.\d+$=> introspection
>> +^libjs-  => javascript
>> \ No newline at end of file
>> diff --git a/debian/changelog b/debian/changelog
>> index e7cbe8d..af300a8 100644
>> --- a/debian/changelog
>> +++ b/debian/changelog

Re: [lintian] 01/02: Use Lintian::Data for section/name mapping

[Niels Thykier]

Bastien Roucaries:
> 
> 
> Le 26 août 2017 08:59:00 GMT+02:00, Niels Thykier  a écrit 
> :
>> Bastien Roucariès:
>>> This is an automated email from the git hooks/post-receive script.
>>>
>>> rouca pushed a commit to branch master
>>> in repository lintian.
>>>
>>> commit f71f3901fcc23db666d3de176526e91fd4f228a2
>>> Author: Bastien ROUCARIÈS 
>>> Date:   Fri Aug 25 22:22:39 2017 +0200
>>>
>>> Use Lintian::Data for section/name mapping
>>
>>
>> Hi,
>>
>> This change causes a regression that need to be fixed (or the commit
>> reverted)
> 
> will fix: what do you prefer : fix regex or fix lintian data to keep ordoring 
> ?
> 
> [...]

Do'er decides.

That said, I am happy to discuss the options if you would like input and
want to talk about pros/cons on the options.

Thanks,
~Niels

Re: [lintian] 01/02: Use Lintian::Data for section/name mapping

[Niels Thykier]

Bastien Roucariès:
> This is an automated email from the git hooks/post-receive script.
> 
> rouca pushed a commit to branch master
> in repository lintian.
> 
> commit f71f3901fcc23db666d3de176526e91fd4f228a2
> Author: Bastien ROUCARIÈS 
> Date:   Fri Aug 25 22:22:39 2017 +0200
> 
> Use Lintian::Data for section/name mapping


Hi,

This change causes a regression that need to be fixed (or the commit
reverted)

The problem being that @NAME_SECTION_MAPPINGS is an /ordered/ list with
a "first match and we are done"-rule.  When migrated to L::Data, this
order is lost because L::Data does not have an order guarantee.

Therefore, when multiple rules match (see [1] for an example), the
previous code would give a well-defined result (first rule listed)
whereas the new code gives a non-deterministic result.

Thanks,
~Niels

[1]

libfoo-ocaml-dev matches the following two rules

[qr/^lib.*-(?:ocaml|camlp4)-dev$/ => 'ocaml'],
[qr/^lib.*-dev$/  => 'libdevel'],

> ---
>  checks/fields.pm  | 34 +-
>  data/fields/name_section_mappings | 16 
>  debian/changelog  |  1 +
>  3 files changed, 30 insertions(+), 21 deletions(-)
> 
> diff --git a/checks/fields.pm b/checks/fields.pm
> index cb91491..4ad96ad 100644
> --- a/checks/fields.pm
> +++ b/checks/fields.pm
> @@ -96,23 +96,14 @@ our @known_java_pkg = map { qr/$_/ } (
>  );
>  
>  # Mapping of package names to section names
> -my @NAME_SECTION_MAPPINGS = (
> -[qr/-docs?$/  => 'doc'],
> -[qr/-dbg(?:sym)?$/=> 'debug'],
> -[qr/^(?:python-)?zope/=> 'zope'],
> -[qr/^python3?-/   => 'python'],
> -[qr/^r-(?:cran|bioc|other)-/  => 'gnu-r'],
> -[qr/^lib.*-perl$/ => 'perl'],
> -[qr/^lib.*-cil(?:-dev)?$/ => 'cli-mono'],
> -[qr/^lib.*-(?:java|gcj)$/ => 'java'],
> -[qr/^(?:lib)php-/ => 'php'],
> -[qr/^lib(?:hugs|ghc6?)-/  => 'haskell'],
> -[qr/^lib.*-ruby(?:1\.\d)?$/   => 'ruby'],
> -[qr/^lib.*-(?:ocaml|camlp4)-dev$/ => 'ocaml'],
> -[qr/^lib.*-dev$/  => 'libdevel'],
> -[qr/^gir\d+\.\d+-.*-\d+\.\d+$/=> 'introspection'],
> -[qr/^libjs-/  => 'javascript'],
> -);
> +my $NAME_SECTION_MAPPINGS = Lintian::Data->new(
> +'fields/name_section_mappings',
> +qr/\s*=>\s*/,
> +sub {
> +my $regex = qr/$_[0]/x;
> +$_[0] = $_[1];
> +return $regex;
> +});
>  
>  my %VCS_EXTRACT = (
>  browser => sub { return @_;},
> @@ -547,14 +538,15 @@ sub run {
>  # Check package name <-> section.  oldlibs is a special case; let
>  # anything go there.
>  if ($parts[-1] ne 'oldlibs') {
> -foreach my $map (@NAME_SECTION_MAPPINGS) {
> -next unless ($pkg =~ $map->[0]);
> +foreach my $section ($NAME_SECTION_MAPPINGS->all()) {
> +my $regex = $NAME_SECTION_MAPPINGS->value($section);
> +next unless ($pkg =~ m{$regex});
>  
>  my $area = '';
>  $area = "$parts[0]/" if (scalar @parts == 2);
>  tag 'wrong-section-according-to-package-name',
> -  "$pkg => ${area}$map->[1]"
> -  unless $parts[-1] eq $map->[1];
> +  "$pkg => ${area}$section"
> +  unless $parts[-1] eq $section;
>  last;
>  }
>  }
> diff --git a/data/fields/name_section_mappings 
> b/data/fields/name_section_mappings
> new file mode 100644
> index 000..ca9c1de
> --- /dev/null
> +++ b/data/fields/name_section_mappings
> @@ -0,0 +1,16 @@
> +# map between regex (x) of package => section
> +-docs?$  => doc
> +-dbg(?:sym)?$=> debug
> +^(?:python-)?zope=> zope
> +^python3?-   => python
> +^r-(?:cran|bioc|other)-  => gnu-r
> +^lib.*-perl$ => perl
> +lib.*-cil(?:-dev)?$  => cli-mono
> +^lib.*-(?:java|gcj)$ => java
> +^(?:lib)php- => php
> +^lib(?:hugs|ghc6?)-  => haskell
> +^lib.*-ruby(?:1\.\d)?$   => ruby
> +^lib.*-(?:ocaml|camlp4)-dev$ => ocaml
> +^lib.*-dev$  => libdevel
> +^gir\d+\.\d+-.*-\d+\.\d+$=> introspection
> +^libjs-  => javascript
> \ No newline at end of file
> diff --git a/debian/changelog b/debian/changelog
> index e7cbe8d..af300a8 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -43,6 +43,7 @@ lintian (2.5.53) UNRELEASED; urgency=medium
>  + [CL] Ensure that python3-foo packages have "Section: python", not
>just python2-foo.  (Closes: #870272)
>  + [RG] Do no longer require debug packages to be priority extra.
> ++ [BR] Use Lintian::Data 

[lintian] 01/01: Tidy gramma of some changelog entries.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 64e679bc7e9221ca3e68eef5ee1088950f4eb5ec
Author: Chris Lamb 
Date:   Sat Aug 26 07:35:40 2017 +0100

Tidy gramma of some changelog entries.
---
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 86ce822..92dec58 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -45,8 +45,8 @@ lintian (2.5.53) UNRELEASED; urgency=medium
 + [RG] Do no longer require debug packages to be priority extra.
 + [BR] Use Lintian::Data for name/section mapping
   * checks/files.pm:
-+ [BR] Avoid false positive privacy-breach-generic for legal.xml.
-+ [BR] Detect install to node package under /usr/lib/nodejs/[^/]*$
++ [BR] Avoid privacy-breach-generic false positives for legal.xml.
++ [BR] Detect install of node package under /usr/lib/nodejs/[^/]*$
   * checks/init.d.desc:
 + [RG] Do not recommend a versioned dependency on lsb-base in
   init.d-script-needs-depends-on-lsb-base.  (Closes: #847144)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (c7387c3 -> 64e679b)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  c7387c3   Detect installation of nodejs pacakge under naked root
   new  64e679b   Tidy gramma of some changelog entries.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git