Build failed in Jenkins: lintian-tests_buster #1441

2019-06-26 Thread jenkins 
See 

--
[...truncated 251.47 KB...]
t/scripts/01-critic/checks.t ... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 35/57 subtests 
t/scripts/Lintian/Relation/06-build-profiles.t . ok
t/scripts/03-strict/private.t .. ok
t/scripts/Lintian/Util/run_cmd.t ... ok
t/scripts/Lintian/Util/dctrl-parser.t .. ok
t/scripts/Lintian/Relation/05-invalid.t  ok
t/scripts/03-strict/collection.t ... ok

#   Failed test 'Test::Perl::Critic for "lib/Test/Lintian.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Test/Lintian.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Lab.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Lab.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Tags.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Tags.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Util.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Util.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Tag/Override.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Tag/Override.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Check.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Check.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Relation.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Relation.pm:1:1:Code is not tidy
t/scripts/01-critic/lib.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 7/44 subtests 
t/scripts/Lintian/Util/parse_bool.t  ok
t/scripts/Lintian/Util/path.t .. ok
t/scripts/Lintian/Relation/04-multiarch.t .. ok
t/scripts/Lintian/Relation/07-implies.t  ok
t/scripts/changelog-format.t ... ok
t/scripts/check-load.t . ok
t/scripts/version.t  ok
t/scripts/needs-info-exists.t .. ok
t/scripts/needs-info-missing.t . ok
t/scripts/unpack-level.t ... ok
t/scripts/pod-coverage.t ... ok
t/scripts/03-strict/lib.t .. ok
t/scripts/implemented-tags.t ... ok
t/scripts/pod.t  ok
t/scripts/profiles-coverage.t .. ok
t/scripts/static-lab.t . ok
t/scripts/pod-synopsis.t ... ok
t/scripts/profile-load.t ... ok
t/scripts/02-minimum-version/test-scripts.t  ok
t/scripts/spellintian.t  ok
t/scripts/02-minimum-version/commands.t  ok
t/scripts/check-descs.t  ok
t/scripts/pod-spelling.t ... ok
t/scripts/03-strict/checks.t ... ok
t/scripts/02-minimum-version/lib.t . ok
t/scripts/03-strict/test-scripts.t . ok
t/scripts/02-minimum-version/checks.t .. ok

Test Summary Report
---
t/scripts/01-critic/helpers.t(Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
t/scripts/01-critic/collection.t (Wstat: 256 Tests: 14 Failed: 
4)
  Failed tests:  7, 9, 12-13
  Non-zero exit status: 1
t/scripts/01-critic/private.t(Wstat: 256 Tests: 13 Failed: 
2)
  Failed tests:  4, 11
  Non-zero exit status: 1
t/scripts/01-critic/test-scripts.t   (Wstat: 256 Tests: 78 Failed: 
2)
  Failed tests:  4, 52
  Non-zero exit status: 1
t/scripts/01-critic/commands.t   (Wstat: 256 Tests: 8 Failed: 3)
  Failed tests:  6-8
  Non-zero exit status: 1
t/scripts/ancient-sv-date.t  (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/scripts/01-critic/checks.t (Wstat: 256 Tests: 57 Failed: 
35)
  Failed tests:  2-4, 6-7, 10-13, 15-18, 20, 23-24, 26, 28
30, 34, 37, 39-46, 49, 51, 54-57
  Non-zero exit status: 1
t/scripts/01-critic/lib.t(Wstat: 256 Tests: 44 Failed: 
7)
  Failed tests:  8, 10, 12-13, 17, 19-20
  Non-zero exit status: 1
Files=72, Tests=19604, 59 wallclock secs ( 2.85 usr  0.33 sys + 382.30 cusr 
24.36 csys = 409.84 CPU)
Result: FAIL

..S..S...T..T...
S.
tests::binaries-from-other-arch: diff -u t/tests/binaries-from-other-arch/tags

Bug#928283: lintian: false positive pkg-js-tools-test-is-missing for openjk: assumes variables contain --with=nodejs

2019-06-26 Thread Christoph Berg 
Re: Chris Lamb 2019-05-02 
<30f34bfa-050d-4966-856d-2cce9da3b...@www.fastmail.com>
> Indeed, how common even is this false-positive? It might be even more
> sensible to add a Lintian override until upstream accepts the package;
> it's meant to be temporary until upstream reviews/accepts some change,
> after all.

Same problem in postgresql-common:

W: postgresql-common source: pkg-js-tools-test-is-missing

WITH_SYSTEMD=--with systemd

%:
dh $@ $(WITH_SYSTEMD)

(It's written that way to make disabling it on older distributions using `sed` 
easier.)

Christoph

Bug#930700: Re: Bug#930700: Re: Bug#930700: lintian: support "suppress-tags-from-file" in configuration file

2019-06-26 Thread Dmitry Bogatov 


[2019-06-24 13:53] "Chris Lamb" 
> > Some of tags have too much false-positive rate, and some of them are not
> > worth spending time. Here is incomplete list:
>
> Neat. So, I think there are three categories here.

Well, I would divide only into two categories: "don't care" and
"false-positive".

Most (all?) "don't care" tags are pedantic, but not all pedantic are
"don't care".

For example, currently "debian-watch-does-not-check-gpg-signature" is
pedantic, but I consider it error, unless it is false-positive.

I'd prefer opt-out approach to opt-in, to not miss something useful.
This bug is about making it simplier.

> Lastly, there are ones with too many false-positives. These seem the
> easy ones to address actually -- if you have a concrete example of
> false-positives, please file away.

Just filed.
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.

Bug#931112: lintian: false-positives of harndening-no-fortify-functions

2019-06-26 Thread Dmitry Bogatov 

Package: lintian
Version: 2.15.0
Severity: wishlist

Dear Maintainer,

"hardening-no-fortify-functions" has extermely high false-positive rate.
From reading of its description, I can see two groups of packages.

First group of false-positives consists of packages that use little or
none of standard library /directly/:

 - bcron
 - ftpcopy
 - runit
 - djbdns
 - ...

You can check, these packages use CFLAGS/CPPFLAGS/LDFLAGS, provided by
dpkg-buildflags via /usr/share/dpkg/default.mk (While I was writing this
bug, I notices that in "runit" package I forgot LDFLAGS, but fix to
include them changes nothing.)

Secondly, even "gdbm" library (but not binary), which is conventional
user of libc as whole and stdio in particular, triggers this tag.

I believe, blhc(1) does everything this tag was supposed to do.
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.


pgpaTZsyJ4V1T.pgp
Description: PGP signature