Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Adam D. Barratt
On Sat, 2008-06-14 at 05:20 +0200, Frank Lichtenheld wrote: On Fri, Jun 13, 2008 at 03:09:18PM +0100, Adam D. Barratt wrote: --- checks/scripts.orig 2008-06-13 14:51:32.0 +0100 +++ checks/scripts 2008-06-13 15:00:57.0 +0100 @@ -542,6 +542,11 @@ if ($cat_string

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Adam D. Barratt
On Fri, 2008-06-20 at 18:24 +0100, Adam D. Barratt wrote: As I suspected, the original patch didn't apply cleanly on top of the three earlier patches; I've attached an updated patch against lintian trunk which uses qr. and, predictably, immediately spotted a small typo I'd made when updating

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Frank Lichtenheld
On Fri, Jun 20, 2008 at 06:45:46PM +0100, Adam D. Barratt wrote: On Fri, 2008-06-20 at 18:24 +0100, Adam D. Barratt wrote: As I suspected, the original patch didn't apply cleanly on top of the three earlier patches; I've attached an updated patch against lintian trunk which uses qr. and,

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Adam D. Barratt
On Fri, 2008-06-20 at 21:03 +0200, Frank Lichtenheld wrote: On Fri, Jun 20, 2008 at 06:45:46PM +0100, Adam D. Barratt wrote: On Fri, 2008-06-20 at 18:24 +0100, Adam D. Barratt wrote: As I suspected, the original patch didn't apply cleanly on top of the three earlier patches; I've attached

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Frank Lichtenheld
On Fri, Jun 20, 2008 at 10:45:42PM +0100, Adam D. Barratt wrote: A quick query relating to committing - if I've produced patches for or fixed things that don't fall under the bashisms umbrella, would you prefer that I sent them to the list (or relevant bug, if any) or would you be happy for me

[checks/scripts] [PATCH 4/4] bashisms update

2008-06-13 Thread Adam D. Barratt
Hi,  This is the fourth of a series of patches updating checks/scripts bashisms checks with some changes that have been made to checkbashisms over the past few months. It's possible that some hunks of this patch may fail to apply as-is due to conflicts with earlier patches; if this turns out to

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-13 Thread Frank Lichtenheld
On Fri, Jun 13, 2008 at 03:09:18PM +0100, Adam D. Barratt wrote: --- checks/scripts.orig 2008-06-13 14:51:32.0 +0100 +++ checks/scripts2008-06-13 15:00:57.0 +0100 @@ -542,6 +542,11 @@ if ($cat_string eq and $checkbashisms and !$within_another_shell) {