[lintian] 01/02: Factor out call to _ships_examples to avoid excessive looping over $sorted_index.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit dcef40cc19184fee46db85f1378bff679e2bad25
Author: Chris Lamb <la...@debian.org>
Date:   Sun Feb 4 22:45:37 2018 +0000

    Factor out call to _ships_examples to avoid excessive looping over 
$sorted_index.
---
 checks/cruft.pm  | 3 ++-
 debian/changelog | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/checks/cruft.pm b/checks/cruft.pm
index 7ebf4bf..2a12c8f 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -571,6 +571,7 @@ sub find_cruft {
     my ($source_pkg, $info, $warned, $ltinbd, $group) = @_;
     my $prefix = ($info->native ? 'diff-contains' : 'source-contains');
     my @worklist;
+    my $ships_examples = _ships_examples($group);
 
     # start with the top-level dirs
     push(@worklist, $info->index('')->children);
@@ -609,7 +610,7 @@ sub find_cruft {
                     }
                 }
                 tag 'package-does-not-install-examples', $entry
-                  if $basename eq 'examples' and not _ships_examples($group);
+                  if $basename eq 'examples' and not $ships_examples;
             }
 
             push(@worklist, $entry->children);
diff --git a/debian/changelog b/debian/changelog
index 472f81f..dde7387 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,8 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 
   * checks/cruft.desc:
     + [BR] Check for wasm files.  (Closes: #889102)
+    + [CL] Factor out call to _ships_examples to avoid excessive looping
+      over $sorted_index.
   * checks/fields.pm:
     + [CL] Avoid false positives when checking binary packages depending on
       toolchain packages by ignoring packages starting with "dh-" or ending

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git