Bug#704197: Please review: systemd checks

that needs to be improved before these can be shipped with lintian? Thanks! Check-Script: systemd Author: Michael Stapelberg stapelb...@debian.org Abbrev: systemd Type: binary Info: Checks various systemd policy things Needs-Info: scripts, index, unpacked, file-info Tag: systemd-service-file

Bug#704197: Please review: systemd checks

Hi Niels, Thanks for the super-fast review. New version is attached, I have fixed everything you mentioned, and for the other things I commented inline: Niels Thykier ni...@thykier.net writes: guidelines. I know Lintian's code style is a mess in general, so it describes the style I hope we

Bug#704197: Please review: systemd checks

Hi Niels, Niels Thykier ni...@thykier.net writes: sub check_init_script { my ($pkg, $info, $file) = @_; my $lsb_source_seen; my $path = $info-index ($file); fail $file is neither a regular file nor a resolvable symlink unless ($path-is_regular_file ||

Bug#704197: Please review: systemd checks

Hi Niels, Niels Thykier ni...@thykier.net writes: I think you are missing a return here? Indeed, thanks. New files are attached, here is the list of things that I know need to be fixed: 1) We don’t have any documentation references in the .desc file yet. 2) I need to switch to lab_data_path in

Bug#704197: Please review: systemd checks

eb5c8b33019e1b838f675bd455052b3d1347fe75 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg mich...@stapelberg.de Date: Sat, 13 Apr 2013 23:14:31 +0200 Subject: [PATCH 1/2] add systemd checks --- checks/systemd | 252 +++ checks/systemd.desc | 76 2 files

Bug#704197: Please review: systemd checks

still work. Find the updated patches attached (rebased against current master). -- Best regards, Michael From ceb4afecf02c6c1a1277ad69bb2d3430baed6fa9 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg mich...@stapelberg.de Date: Sat, 13 Apr 2013 23:14:31 +0200 Subject: [PATCH 1/3] add systemd

Bug#718404: [PATCH] Don’t generate statically-linked-binary for golang packages

05208d99ddb0afb68ae8affa1a7552231ed6276d Mon Sep 17 00:00:00 2001 From: Michael Stapelberg mich...@stapelberg.de Date: Wed, 31 Jul 2013 10:28:10 +0200 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20generate=20statically-linked-bina?= =?UTF-8?q?ry=20for=20binary=20packages=20built=20with=20golang-go?= MIME-Version: 1.0 Content-Type: text

Bug#795667: Suppress hardening-{no-relro,no-fortify-functions}

libhtml-parser-perl3.71-2 ii libtext-template-perl 1.46-1 pn libyaml-perl none -- no debconf information From 87e1d19a9cb2dfdfd1b23108bdff89d264102a3c Mon Sep 17 00:00:00 2001 From: Michael Stapelberg stapelb...@debian.org Date: Sun, 16 Aug 2015 09:52:24 +0200 Subject: [PATCH] Suppress

Bug#795614: [PATCH] fix false-positive spelling-error-in-binary affecting many Go binaries

On Sun, Aug 16, 2015 at 10:11 AM, Niels Thykier ni...@thykier.net wrote: On 2015-08-15 21:59, Michael Stapelberg wrote: Package: lintian Version: 2.5.33 Severity: normal Tags: patch From the patch description: [PATCH] spelling-error-in-binary: ignore ang/and The Go stdlib html/ package

Bug#795614: [PATCH] fix false-positive spelling-error-in-binary affecting many Go binaries

-multiarch none ii dpkg-dev 1.18.1 ii libhtml-parser-perl3.71-2 ii libtext-template-perl 1.46-1 pn libyaml-perl none -- no debconf information From 9e94af4f6d4bc0169fd3de6073707e4ce4e94c04 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg stapelb...@debian.org

Bug#857656: [PATCH] c/binaries: amend go whitelist to cover all errors

00:00:00 2001 From: Michael Stapelberg <stapelb...@debian.org> Date: Mon, 13 Mar 2017 20:30:40 +0100 Subject: [PATCH 3/3] c/binaries: amend go whitelist to cover all errors --- checks/binaries.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/checks/binaries.pm b/checks/binaries

Bug#857654: [PATCH] c/binaries: whitelist go spelling false-positives

00:00:00 2001 From: Michael Stapelberg <stapelb...@debian.org> Date: Mon, 13 Mar 2017 20:29:48 +0100 Subject: [PATCH 1/3] c/binaries: whitelist go spelling false-positives --- checks/binaries.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/checks/binaries.pm b/checks/binaries

Bug#857655: [PATCH] c/binaries: fix go whitelist by moving variable

00:00:00 2001 From: Michael Stapelberg <stapelb...@debian.org> Date: Mon, 13 Mar 2017 20:30:24 +0100 Subject: [PATCH 2/3] c/binaries: fix go whitelist by moving variable --- checks/binaries.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/checks/bina

Bug#870829: Contradicting warnings/errors: useless-autoreconf-build-depends vs. missing-build-dependency-for-dh-addon

On Sat, Aug 5, 2017 at 6:25 PM, Mattia Rizzolo <mat...@debian.org> wrote: > On Sat, Aug 05, 2017 at 05:47:39PM +0200, Michael Stapelberg wrote: > > build-dependency was unnecessary with debhelper ≥ 10 and should be > removed: > > > > W: mdocml source: useless-auto

Bug#870829: Contradicting warnings/errors: useless-autoreconf-build-depends vs. missing-build-dependency-for-dh-addon

Package: lintian Version: 2.5.52 Severity: normal When packaging mdocml 1.14.3, lintian noted that the autotools-dev build-dependency was unnecessary with debhelper ≥ 10 and should be removed: W: mdocml source: useless-autoreconf-build-depends autotools-dev After doing that, lintian noted that

Bug#877802: include file name and line number in output

Sorry for not being more clear: when I run lintian (notably, without -i), I get output such as: % lintian dunst_1.2.0-1_amd64.changes I: dunst source: testsuite-autopkgtest-missing P: dunst source: debian-watch-may-check-gpg-signature I: dunst: dbus-session-service-wrong-name

Bug#877802: include file name and line number in output

Package: lintian Version: 2.5.54 Severity: wishlist It would be great if lintian could include the relevant file name and line number in each line of output. That way, users could easily jump to the issue at hand by using their editor’s “compilation mode” (Emacs), quickfix (Vim) or similar

Bug#891072: [PATCH] Add golang-missing-built-using and golang-built-using-on-arch-all

suggests: pn binutils-multiarch ii dpkg-dev 1.19.0.5 ii libhtml-parser-perl3.72-3+b2 ii libtext-template-perl 1.47-1 -- no debconf information >From 7318d47e2caff903267d0235d7ef3069d74041a5 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg <stapelb...@debian.org

Bug#891072: [PATCH] Add golang-missing-built-using and golang-built-using-on-arch-all

le-" as that's the > name of checks/foo.pm. > Done. > > Are we missing a Test-Depends in the "desc" file too? :) > Not sure what you mean? > > Thanks again! > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lam

Bug#891072: [PATCH] Add golang-missing-built-using and golang-built-using-on-arch-all

this case, you can use: Test-Depends: --- I don’t think that applies to this change. > > > Best wishes, > > -- > ,''`. > : :' : Chris Lamb > `. `'`

Bug#891184: [PATCH] Add missing-xs-go-import-path-for-golang-package

suggests: pn binutils-multiarch ii dpkg-dev 1.19.0.5 ii libhtml-parser-perl3.72-3+b2 ii libtext-template-perl 1.47-1 -- no debconf information >From 17d3d7cfde705c91b39d09aef556705f340fbd05 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg <stapelb...@debian.org

Bug#891072: Please add golang-missing-built-using and golang-built-using-on-arch-all tags

Thank you for the quick turnaround on this! On Thu, Feb 22, 2018 at 2:55 PM, Chris Lamb wrote: > tags 891072 + pending > thanks > > Dear Michael, > > I've applied this in git with a few (extremely minor) changes. Thanks! > >