Bug#368206: lintian: Should not warn for writing style in untranslatable templates
reopen 368206 thanks Hi, When trying to resolve some lintian warnings of a package, I encountered this same situation: the template is for internal use and thus has no description, however I still get a warning: E: dbconfig-common: no-template-description dbconfig-common/internal/reconfiguring W: dbconfig-common: malformed-question-in-templates dbconfig-common/internal/reconfiguring Lintian suggests to put the text for internal use in the description to satisfy lintian, but we don't agree that this is a good thing: the description was omitted on purpose because it serves no use and would only end up in the .po files as an extra translatable string. Adding 'for internal use' will indeed silence lintian but adds an extra string to translate for all languages while that string is not useful at all, meaning more cruft and more work for all involved. I suggest not to complain about templates with no description at all, since these can be assumed to be internal. Thijs signature.asc Description: This is a digitally signed message part
Bug#368206: lintian: Should not warn for writing style in untranslatable templates
Thijs Kinkhorst [EMAIL PROTECTED] writes: When trying to resolve some lintian warnings of a package, I encountered this same situation: the template is for internal use and thus has no description, however I still get a warning: E: dbconfig-common: no-template-description dbconfig-common/internal/reconfiguring W: dbconfig-common: malformed-question-in-templates dbconfig-common/internal/reconfiguring Lintian suggests to put the text for internal use in the description to satisfy lintian, but we don't agree that this is a good thing: the description was omitted on purpose because it serves no use and would only end up in the .po files as an extra translatable string. Only if you mark it translatable. So don't do that. (In other words, omit the _ in front of Description.) -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#368206: lintian: Should not warn for writing style in untranslatable templates
Package: lintian Version: 1.23.21 Severity: minor CC'ing Thomas as I know he's the one who sent the patch. Lintian currently warns for writing style in some templates it shouldn't: W: passwd: malformed-prompt-in-templates passwd/root-password-crypted The offending template is: # This template is for D-I purposes and should allow # preseeding the root password with a crypted password rather than cleartext Template: passwd/root-password-crypted Type: password Description: For internal use only So, I hereby suggest that lintian does NOT check the wording of strings that are contained in an untranslatable template, because this is most of the time meant for not being displayed. In any case, thanks a lot for the work on lintian and thanks A LOT for incorporating Thomas suggested changes. -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.16-1-686 Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to fr_FR.UTF-8) Versions of packages lintian depends on: ii binutils 2.16.1cvs20060413-1 The GNU assembler, linker and bina ii diffstat 1.41-1 produces graph of changes introduc ii dpkg-dev 1.13.19 package building tools for Debian ii file 4.17-1 Determines file type using magic ii gettext 0.14.5-4GNU Internationalization utilities ii intltool-debian 0.34.2+20060512 Help i18n of RFC822 compliant conf ii libparse-debianchang 1.0-1 parse Debian changelogs and output ii man-db 2.4.3-3 The on-line manual pager ii perl [libdigest-md5- 5.8.8-4 Larry Wall's Practical Extraction lintian recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#368206: lintian: Should not warn for writing style in untranslatable templates
Christian Perrier [EMAIL PROTECTED] (20/05/2006): Lintian currently warns for writing style in some templates it shouldn't: W: passwd: malformed-prompt-in-templates passwd/root-password-crypted The offending template is: # This template is for D-I purposes and should allow # preseeding the root password with a crypted password rather than cleartext Template: passwd/root-password-crypted Type: password Description: For internal use only So, I hereby suggest that lintian does NOT check the wording of strings that are contained in an untranslatable template, because this is most of the time meant for not being displayed. There is no way to find in a binary package if the strings are marked as translatable. Using the source package is also a bad idea, as these templates may be modified at build time. I'd suggest maintainers to try to follow the developers reference even for unstranslatable templates, for example Type: password Description: For internal use only: As they are not displayed to the users, it doesn't change anything. I let the lintian maintainers mark this bug as wontfix if they agree with me. Cheers, -- Thomas Huriaux signature.asc Description: Digital signature
Bug#368206: lintian: Should not warn for writing style in untranslatable templates
Thomas Huriaux [EMAIL PROTECTED] writes: There is no way to find in a binary package if the strings are marked as translatable. Oh, hm, yes. I hadn't realized that, but that makes sense. Using the source package is also a bad idea, as these templates may be modified at build time. Yeah, and with all the weird build systems out there (yada comes to mind), trying to find the templates in the source package can be quite hard. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#368206: lintian: Should not warn for writing style in untranslatable templates
Quoting Russ Allbery ([EMAIL PROTECTED]): Thomas Huriaux [EMAIL PROTECTED] writes: There is no way to find in a binary package if the strings are marked as translatable. Oh, hm, yes. I hadn't realized that, but that makes sense. Using the source package is also a bad idea, as these templates may be modified at build time. Yeah, and with all the weird build systems out there (yada comes to mind), trying to find the templates in the source package can be quite hard. Some intermediate way would be to exclude templates with For internal use only and actually amend the DevRef to specifically request developers to use this exact description as short description for templates that do not need translation (and otpionnally add more stuff in the long description) signature.asc Description: Digital signature
Bug#368206: lintian: Should not warn for writing style in untranslatable templates
I let the lintian maintainers mark this bug as wontfix if they agree with me. I actually don't exactly agree with this. Mostly not because it hurts me, but because I fear this can turn some developers mad at these lintian checks (I guess some are already anyway with this attempt to enforce writing style which I take a lot of respnsibility for). So, if there is a code solution to this, please consider it...:-) signature.asc Description: Digital signature
Bug#368206: lintian: Should not warn for writing style in untranslatable templates
Christian Perrier [EMAIL PROTECTED] (20/05/2006): Quoting Russ Allbery ([EMAIL PROTECTED]): Thomas Huriaux [EMAIL PROTECTED] writes: There is no way to find in a binary package if the strings are marked as translatable. Oh, hm, yes. I hadn't realized that, but that makes sense. Using the source package is also a bad idea, as these templates may be modified at build time. Yeah, and with all the weird build systems out there (yada comes to mind), trying to find the templates in the source package can be quite hard. Some intermediate way would be to exclude templates with For internal use only and actually amend the DevRef to specifically request developers to use this exact description as short description for templates that do not need translation (and otpionnally add more stuff in the long description) Indeed, that would be a good solution. Sorry for being too fast at willing to mark bug as wontfix :-) Here is the list of the strings having nternal in the various templates: --- (for internal use only) (for internal use) Codename for the selected suite (internal use) Debian version to install (internal use) Do you wish to backup popfile's internal data? For internal use (Is a User Mode Linux console in use?) For internal use (Is a serial console in use?) For internal use (keyboard chosen by user) For internal use only Internal holding result of scan Internal use Internal use by partman-newworld and yaboot-installer Internal use by partman-prep, yaboot- and prep-installer Internal value only N/A Internal use Suite to install (internal use) This is an internal option This is an internal template. No need for translation. Use nuauth internal cache or not [Internal] makepasswd generated password [internal] Whether the DB plus user is created [internal] what db_version is currently setup codename for the selected suite (internal use) country code or enter information manually (internal use) default retriever (internal use only) for internal use host to use for security updates (internal use) internal item, question mark for lintian? internal use only --- This list seems quite too random to extract a correct regexp to skip only the internal templates, so the dev-ref should probably be amended. Cheers, -- Thomas Huriaux signature.asc Description: Digital signature
