Bug#904522: lintian: Should detect misspellings of Rules-Requires-Root

2018-07-25 Thread Axel Beckert
Hi Chris!

Chris Lamb wrote:
> > Files to be checked at least: debian/control and debian/changelog.
> 
> Fixed in Git,

Thanks for the very prompt implementation!

Sorry for not having implemented it myself, but I was too tired last
night (obviously, why would I have run into that issue else? :-) to do
that properly.

> although not to check debian/changelog as (at the very least) it
> would lead to false-positives in entries such as "Correcting
> 'Rules-Require-Root' misspelling." :)

Granted.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#904522: lintian: Should detect misspellings of Rules-Requires-Root

2018-07-24 Thread Chris Lamb
tags 904522 + pending
thanks

> Files to be checked at least: debian/control and debian/changelog.

Fixed in Git, although not to check debian/changelog as (at the very
least) it would lead to false-positives in entries such as "Correcting
'Rules-Require-Root' misspelling." :)

See:

  
https://salsa.debian.org/lintian/lintian/commit/d24597c4a45aff3a257c86aa01b27b97635bc1d5

  checks/control-file.desc   | 8 
  checks/control-file.pm | 5 +
  debian/changelog   | 2 ++
  t/tests/fields-unknown-fields/debian/debian/control.in | 1 +
  t/tests/fields-unknown-fields/desc | 1 +
  t/tests/fields-unknown-fields/tags | 1 +
  6 files changed, 18 insertions(+)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#904522: lintian: Should detect misspellings of Rules-Requires-Root

2018-07-24 Thread Axel Beckert
Package: lintian
Version: 2.5.93
Severity: wishlist

Hi,

I just made a commit with a "Rules-Require-Root" field and the according
changelog entry. I just noticed the typo (missing "s") because of a
dpkg-source warning. Lintian was silent about this, not even an unknown
field or such has been reported.

It would be nice if lintian would detect any obviously misspelled
variant of Rules-Requires-Root, i.e. those which are just a permutation
of which of the three words ends in "s" and which not.

Suggested pseudo code:

if ($field_name =~ /^Rules?-Requires?-Roots?$/ and
$field_name ne 'Rules-Requires-Root') {
tag 'misspelled-rules-requires-root-field-name'
}

Files to be checked at least: debian/control and debian/changelog.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), 
(500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 
'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.17.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils   2.31.1-1
ii  bzip2  1.0.6-8.1
ii  diffstat   1.61-1+b1
ii  dpkg   1.19.0.5+b1
ii  file   1:5.33-3
ii  gettext0.19.8.1-6+b1
ii  intltool-debian0.35.0+20060710.4
ii  libapt-pkg-perl0.1.34
ii  libarchive-zip-perl1.60-1
ii  libclass-accessor-perl 0.51-1
ii  libclone-perl  0.39-1
ii  libdigest-sha-perl 6.02-1
ii  libdpkg-perl   1.19.0.5
ii  libemail-valid-perl1.202-1
ii  libfile-basedir-perl   0.08-1
ii  libipc-run-perl20180523.0-1
ii  liblist-moreutils-perl 0.416-1+b3
ii  libparse-debianchangelog-perl  1.2.0-12
ii  libtext-levenshtein-perl   0.13-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.74-1
ii  libxml-simple-perl 2.25-1
ii  libyaml-libyaml-perl   0.72+repack-1
ii  man-db 2.8.3-2
ii  patchutils 0.3.4-2
ii  perl [libdigest-sha-perl]  5.26.2-6
ii  t1utils1.41-2
ii  xz-utils   5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
ii  binutils-multiarch 2.31.1-1
ii  dpkg-dev   1.19.0.5
ii  libhtml-parser-perl3.72-3+b2
ii  libtext-template-perl  1.53-1

-- no debconf information