Bug#887278: live-build should depend on e2fsprogs explicitly
On Wed, 14 Feb 2018, Andreas Henriksson wrote: > > /sbin/mkfs.ntfs is a path to an existing program > > Agreed, but that's not what the source code uses. > Please read the source again. You'll spot it. ;) Duh, indeed. Fixed in git. Thanks to Stefan who also showed me the typo. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Bug#887278: live-build should depend on e2fsprogs explicitly
Am 14.02.2018 um 15:46 schrieb Raphael Hertzog: >> Would likely be better if we file separate bug reports for separate >> issues, for example this typo will likely always make the ntfs check >> fail but that's offtopic for this bug report: >> https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_hdd/#L53 > What typo ? > > ntfs-3g is a valid package > /sbin/mkfs.ntfs is a path to an existing program Yes, /sbin/mkfs.ntfs is. But, /sbin/mkfs.nfts is not. And that's what that source looks for. Kind Regards, Stefan Baur
Bug#887278: live-build should depend on e2fsprogs explicitly
Hello, On Wed, 14 Feb 2018, Andreas Henriksson wrote: > The source of live-build might well need improvements to deal with > what's inside the chroot it works with, but I don't think that's > the main focus of this bug report. A package relationship of live-build, > could not influence what's available in the chroot (unless I'm > mistaken), so the chroot is out of scope I'd say. Ack. But as you noticed afterwards, with LB_BUILD_WITH_CHROOT=false it would use the binary from the host system. > debootstrapped it'll still have e2fsprogs installed. The main question > for this bug report is 'if e2fsprogs is uninstalled, does live-build > also have to be uninstalled on the same system because of that?'. Clearly, no. But it might be a good idea to add it to Recommends or Suggests. > Looking again, for places where mkfs is used *outside* the chroot > it seems cases looking at LB_BUILD_WITH_CHROOT being false > and then using mkfs is relevant, like for example this one: > https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_rootfs/#L187 This one is fine as we have a Check_package here: https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_rootfs/#L84 So if the package is not installed, it would fail and tell the user to install the missing package. Ideally we would not give such error messages to the user but LB_BUILD_WITH_CHROOT defaults to true and it doesn't seem a good idea to add all those packages into Depends or Recommends when they are usually not needed on the host. > I'm confused about the current status and if we agree or not. I believe this bug can be closed by adding a Suggests dependency. I will do that in git. > Would likely be better if we file separate bug reports for separate > issues, for example this typo will likely always make the ntfs check > fail but that's offtopic for this bug report: > https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_hdd/#L53 What typo ? ntfs-3g is a valid package /sbin/mkfs.ntfs is a path to an existing program > Would be happy to hear more about if maintainers thinks we need a (I'm basically the de-facto maintainer nowadays) Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Bug#887278: live-build should depend on e2fsprogs explicitly
Hello Raphael Hertzog,
thanks for your feedback on the issue
On Thu, Jan 25, 2018 at 04:49:37PM +0100, Raphael Hertzog wrote:
> On Mon, 22 Jan 2018, Andreas Henriksson wrote:
[...]
> > My conclusion is thus that this is a false positive and the bug report
> > should simply be closed.
[...]
> There are multiple calls to mkfs.${MKFS} that have not been detected.
> Some of them are already adequately protected by a "Check_package" call
> but I believe that scripts/build/binary_hdd and scripts/build/source_hdd
> have to be updated.
The source of live-build might well need improvements to deal with
what's inside the chroot it works with, but I don't think that's
the main focus of this bug report. A package relationship of live-build,
could not influence what's available in the chroot (unless I'm
mistaken), so the chroot is out of scope I'd say.
Please also note that e2fsprogs will still be installed on *any* system
where it has not explicitly been removed, even after it's no longer
marked 'Essential: yes'. Thus if the chroot live-build works with is
debootstrapped it'll still have e2fsprogs installed. The main question
for this bug report is 'if e2fsprogs is uninstalled, does live-build
also have to be uninstalled on the same system because of that?'.
Looking again, for places where mkfs is used *outside* the chroot
it seems cases looking at LB_BUILD_WITH_CHROOT being false
and then using mkfs is relevant, like for example this one:
https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_rootfs/#L187
... but at the same time, the same happens for parted usage
and there's no package relationship specified against parted:
https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_hdd/#L183
or mkfs.jffs2:
https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_hdd/#L183
I'm confused about the current status and if we agree or not.
Would likely be better if we file separate bug reports for separate
issues, for example this typo will likely always make the ntfs check
fail but that's offtopic for this bug report:
https://sources.debian.org/src/live-build/1:20171207/scripts/build/binary_hdd/#L53
Would be happy to hear more about if maintainers thinks we need a
dependency or not. It still looks to me like *if* a dependency on
e2fsprogs is warranted, it should come with lots of other dependencies
at the same time (like parted, mtd-utils, etc., etc.).
(I'm happy to help out with work on that, but I'm not going to pick up
live-build maintenance and fix every possible bug in it. My interest is
limited to making e2fsprogs non-essential.)
Regards,
Andreas Henriksson
Bug#887278: live-build should depend on e2fsprogs explicitly
Hello,
On Mon, 22 Jan 2018, Andreas Henriksson wrote:
> I can only find mke2fs mentioned in a comment:
> https://sources.debian.org/src/live-build/1:20171207/functions/losetup.sh/#L64
>
> My conclusion is thus that this is a false positive and the bug report
> should simply be closed.
>
> Would be great to hear from maintainers about what they think of
> potential relationship between live-build and e2fsprogs.
There are multiple calls to mkfs.${MKFS} that have not been detected.
Some of them are already adequately protected by a "Check_package" call
but I believe that scripts/build/binary_hdd and scripts/build/source_hdd
have to be updated.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Bug#887278: live-build should depend on e2fsprogs explicitly
On Sun, Jan 14, 2018 at 08:07:38PM +0100, Helmut Grohne wrote: > Package: live-build [...] > /usr/share/live/build/functions/losetup.sh contains mke2fs. According to file > it is a POSIX shell script, ASCII text executable [...] I can only find mke2fs mentioned in a comment: https://sources.debian.org/src/live-build/1:20171207/functions/losetup.sh/#L64 My conclusion is thus that this is a false positive and the bug report should simply be closed. Would be great to hear from maintainers about what they think of potential relationship between live-build and e2fsprogs. Regards, Andreas Henriksson
Bug#887278: live-build should depend on e2fsprogs explicitly
Package: live-build Version: 1:20171207 User: helm...@debian.org Usertags: nonessentiale2fsprogs Dear maintainer, We want to make removing e2fsprogs from installations possible. For standard installations this is not useful, but embedded applications and chroots benefit from such an option. For getting there all packages that use e2fsprogs must be identified and gain a dependency on it as e2fsprogs currently is essential. live-build was identified as potentially needing such a dependency, because it mentions tool names from e2fsprogs in the following files: /usr/share/live/build/functions/losetup.sh contains mke2fs. According to file it is a POSIX shell script, ASCII text executable Please investigate whether these cases are actually uses of a tool from e2fsprogs. Care has been taken to shrink the number of candidates as much as possible, but a few false positives will remain. After doing so, do one of the following: * Add e2fsprogs to Depends. * Add e2fsprogs to Recommends. * Close this bug explaining why e2fsprogs is not used by this package. Once e2fsprogs drops the "Essential: yes" flag, this bug will be upgraded to RC severity. Please note that lintian will warn about such a dependency before lintian 2.5.56. Thanks for your help Helmut
