Re: Bug#672361: Bug#934502: lsb-base: avoid '\r' in logging functions

[Vincent Lefevre]

On 2019-08-14 19:21:01 +, Dmitry Bogatov wrote:
> [2019-08-13 16:48] Thorsten Glaser 
> > > Please, change format to following:
> >
> > just run:
> >
> > sudo sh -c 'echo FANCYTTY=0 >>/etc/lsb-base-logging.sh'
> 
> 
> > (On the other hand, now that “most” people, and especially the target
> > group of “fancy” logging, is using systemd instead, perhaps it’s time
> > to remove the fancy code entirely and go back to the classical output
> > entirely?)
> 
> I support this proposal. Any objections, collegues?

I think that there are no big issues with colors (all terminals and
"less" can handle them) and they can be useful to see failures more
easily. Thus I think that they shoud be kept.

/lib/lsb/init-functions.d/20-left-info-blocks is what should be
dropped actually since it involves cursor movements and is not
much useful. Moreover, the output can be wrong when the program
outputs warnings or error messages.

Then bootlogd should not do any filtering.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Bug#934502: lsb-base: avoid '\r' in logging functions

[Dmitry Bogatov]

[2019-08-13 16:48] Thorsten Glaser 
> > Please, change format to following:
>
> just run:
>
>   sudo sh -c 'echo FANCYTTY=0 >>/etc/lsb-base-logging.sh'


> (On the other hand, now that “most” people, and especially the target
> group of “fancy” logging, is using systemd instead, perhaps it’s time
> to remove the fancy code entirely and go back to the classical output
> entirely?)

I support this proposal. Any objections, collegues?
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.

Bug#934502: lsb-base: avoid '\r' in logging functions

[Dmitry Bogatov]

Package: lsb-base
Version: 10.2019051400
Severity: wishlist
File: /lib/lsb/init-functions


Dear Maintainer,

please change output format of logging functions, provided by
`/lib/lsb/init-functions'.

Currently, status marker -- green [ok], red [FAIL], blue [warn], etc. -- is
printed at the start of terminal line.

It causes numerous glitches. Here is incomplete list of them.  For sake of
brevity, I will talk about [ok] marker only. Other markers behave in same way.

 * If message contains newline, [ok] marker will displace message text.
   Before:

 [..] This is
 very important message

   After:

 [..] This is
 [ok] important message

   Expected:
 [ok] This is
 very important message

 * If message is longer then terminal width, it will be span several terminal
   lines, causing problem described above.

Please, change format to following:

  Before:

  This is very important message...

  After:

  This is very important message... ok

If message spans several lines, it will look like following:

  This is
  very important message... ok

Aligning markers on right border of terminal will cause glitches when message
length is equal to terminal width, so please don't.

  Before:

  This is long message ...

  After:

  This is long message .ok


pgpF8BxJDxkCS.pgp
Description: PGP signature