Re: Attempt to upgrade sra-sdk

2023-12-10 Thread Andreas Tille
Hi Aaron, Am Sun, Dec 10, 2023 at 06:30:01PM -0500 schrieb Aaron M. Ucko: > > Because env/common.cmake doesn't actually try to use a system > installation: > > #check_include_file_cxx(mbedtls/md.h HAVE_MBEDTLS_H) > set(HAVE_MBEDTLS_H 0) # TODO: disabling system mbedtls since it may be > out

Re: Attempt to upgrade sra-sdk

2023-12-10 Thread Aaron M. Ucko
Andreas Tille writes: > No mbedtls libs found installed in the system, using local copy... Because env/common.cmake doesn't actually try to use a system installation: #check_include_file_cxx(mbedtls/md.h HAVE_MBEDTLS_H) set(HAVE_MBEDTLS_H 0) # TODO: disabling system mbedtls since it may be

Re: Attempt to upgrade sra-sdk

2023-12-10 Thread Andreas Tille
Hi Aaron, Am Sat, Dec 09, 2023 at 08:23:26PM -0500 schrieb Aaron M. Ucko: > > AFAICT, the immediate problem is that label_online_tests.patch refers to > at least one removed or renamed test: > > CMake Error at test/internal/vdb-diff/CMakeLists.txt:42 > (set_tests_properties): > set_tests_

Re: Attempt to upgrade sra-sdk

2023-12-09 Thread Aaron M. Ucko
Andreas Tille writes: > I've spent some time into the new version of sra-sdk and tried to adapt > the patches to the new upstream version. Hi, Andreas, and thanks! AFAICT, the immediate problem is that label_online_tests.patch refers to at least one removed or renamed test: CMake Error at te

Attempt to upgrade sra-sdk

2023-12-09 Thread Andreas Tille
Hi Aaron, I've spent some time into the new version of sra-sdk and tried to adapt the patches to the new upstream version. Salsa CI was not working at the time of pushing so there is no build log but if you might like to try on your side you will notice that my attempt failed. I'd be super happy