Re: CI for fastx-toolkit [Outreachy]

Hi Nadiya, On Tue, Jun 06, 2017 at 02:18:01PM -0700, Nadiya Sitdykova wrote: > 1) Sorry, there were some typos in run-unit-test, somehow I missed it. Now > I fixed it and made some additional tests. > > 2) Also I added patch to explain -Q option Thanks a lot - the package is uploaded. Kind

Re: CI for fastx-toolkit [Outreachy]

Hello Andreas, 1) Sorry, there were some typos in run-unit-test, somehow I missed it. Now I fixed it and made some additional tests. 2) Also I added patch to explain -Q option Regards, Nadiya Sitdykova On Tue, Jun 6, 2017 at 12:57 AM, Andreas Tille wrote: > Hi Nadiya, > > I

Re: CI for fastx-toolkit [Outreachy]

Hi Nadiya, I tried the run-unit-test script and got: $ . /usr/share/doc/fastx-toolkit/run-unit-test testing fastq_to_fasta testing fastx_quality_stats testing fastx_clipper testing fastx_renamer testing fastx_trimmer testing fastx_collapser testing fastx_artifacts_filter testing

Re: CI for fastx-toolkit [Outreachy]

Hi Nadiya, On Mon, Jun 05, 2017 at 10:53:41PM -0700, Nadiya Sitdykova wrote: > Thank you, Charles, +1 > this helped me a lot, I added test for > fastq_quality_filter. Although it's sad that this option is undocumented Definitely. The manpage is created using help2man. We could fix this by

Re: CI for fastx-toolkit [Outreachy]

Thank you, Charles, this helped me a lot, I added test for fastq_quality_filter. Although it's sad that this option is undocumented Regards, Nadiya Sitdykova On Mon, Jun 5, 2017 at 5:21 PM, Charles Plessy wrote: > Le Mon, Jun 05, 2017 at 04:35:37PM -0700, Nadiya Sitdykova a

Re: CI for fastx-toolkit [Outreachy]

Le Mon, Jun 05, 2017 at 04:35:37PM -0700, Nadiya Sitdykova a écrit : > > When I run > > fastq_quality_filter -i galaxy/test-data/fastq_qual_filter1.fastq -q 33 -p > 100 > > I've got: > > fastq_quality_filter: bug: got empty array at fastq_quality_filter.c:97 Hi Nadiya, FASTX-toolkit has an

CI for fastx-toolkit [Outreachy]

Hello Andreas, I added test suite for fastx-toolkit package. But I left test for fastq_quality_filter commented for now, because it doesn't work. When I run fastq_quality_filter -i galaxy/test-data/fastq_qual_filter1.fastq -q 33 -p 100 I've got: fastq_quality_filter: bug: got empty array at