Re: Please review ncbi-vdb

2022-03-16 Thread Aaron M. Ucko
Andreas Tille writes: > Ahhh, good catch. I admit I did not stumbled upon any dpkg-source errors > but I absolutely agree that we should drop VS files from upstream source. Thanks! To be clear, I mean to drop the convenience googletest copy altogether. > Ups, thanks a lot for the review. No

Re: Please review ncbi-vdb

2022-03-16 Thread Andreas Tille
Hi Aaron, Am Mon, Mar 14, 2022 at 11:13:37PM -0400 schrieb Aaron M. Ucko: > > If you think the package structure is OK I might upload to new. > > Any other fine tuning that might be needed could be done in some > > source-only upload. > > Good point, but I did already find two other things that w

Re: Please review ncbi-vdb

2022-03-14 Thread Aaron M. Ucko
Andreas Tille writes: > If you think the package structure is OK I might upload to new. > Any other fine tuning that might be needed could be done in some > source-only upload. Good point, but I did already find two other things that would be best to fix before any upload: - dpkg-source errors

Re: Please review ncbi-vdb

2022-03-14 Thread Andreas Tille
Hi Aaron, Am Sat, Feb 26, 2022 at 10:48:29PM -0500 schrieb Aaron M. Ucko: > Andreas Tille writes: > > > I managed the packaging now at the state where it builds binary packages > > that are technically basically OK from a Debian point of view (one RPATH > > issue left). Aaron, I would love if y

Re: Please review ncbi-vdb

2022-02-26 Thread Aaron M. Ucko
Andreas Tille writes: > I managed the packaging now at the state where it builds binary packages > that are technically basically OK from a Debian point of view (one RPATH > issue left). Aaron, I would love if you could give it a review with > your specialist hat on. Great, thanks! I'll review

Please review ncbi-vdb (Was: Cmake help needed for ncbi-vdb)

2022-02-25 Thread Andreas Tille
Hi, Am Thu, Feb 24, 2022 at 09:14:31AM +0100 schrieb Mathieu Malaterre: > I've pushed 25ca2396895c15afe738b9209b1c350da18847ca > > If I understand the original upstream code, this should be the right fix. Thanks a lot Mathieu. This was extremely helpful! I managed the packaging now at the stat