On Sun, Dec 16, 2012 at 5:07 AM, Dmitry Shachnev <mity...@gmail.com> wrote: > On Fri, Dec 7, 2012 at 9:36 PM, Andrew Starr-Bochicchio <a...@debian.org> > wrote: >> I'll try to get around to looking at this sometime in the next few days. > > Are you still going to look at this?
Sorry about taking so long to get around to this. I got a bit caught up with other things. Let's look at mathjax first. In no particular order... 1) The debian/watch file doesn't seem to find any releases: $ uscan --report --verbose -- Scanning for watchfiles in . -- Found watchfile in ./debian -- In debian/watch, processing watchfile line: opts=filenamemangle=s/.*v(.*)/mathjax_$1.orig.tar.gz/ http://github.com/mathjax/MathJax/tags .*/tarball/v(.*) uscan warning: In debian/watch, no matching hrefs for watch line http://github.com/mathjax/MathJax/tags .*/tarball/v(.*) -- Scan finished According to the PTS, a working one can be found here: http://qa.debian.org/cgi-bin/watchfile.cgi?package=mathjax 2) The debian/copyright file has a few small issues with the spec. - SIL Open Font License (OFL), Version 1.1. should just use the short name OFL-1.1 in the License field. - As it isn't among the common-licenses, you need to include the full text of the OFL-1.1. - Optionally, you can use stand-alone license paragraphs for a given license once, instead of repeating it in each Files paragraph that refers to it. Also, you could combine the Files paragraphs for the files that share the same license and copyright holder. I.e. Files: fonts/HTML-CSS/TeX/eot fonts/HTML-CSS/TeX/otf 3) Speaking of fonts... Are they useful outside of MathJax? If so, you might want to consider putting them into a separate package and installing them system-wide. 4) Might it make more sense to revert the original compressed files in the clean target rather than the install one? But all that's a bit nit-picky. Now lets look at the doc package: 1) Again, in debian/copyright you could optionally clean it up a bit by using stand-alone license paragraphs. 2) In debian/control, you have: Maintainer: Dmitry Shachnev <mity...@gmail.com> Uploaders: Debian Javascript Maintainers <pkg-javascript-de...@lists.alioth.debian.org> In the mathjax source package, you have the reverse, the team is the maintainer and you're the uploader. I don't know if the pkg-javascript team has a policy on which is right or not, but it seems to me that it should at least be consistent. 3) You have no debian/watch file. 4) Even though AFAIK you don't need an ITP for this, it would make sense to mention in the changelog entry that you are splitting this off of the main package. That way the ftp-masters don't need to spend time figuring out why it doesn't close an ITP. Again, mostly nitpicking... I'd be happy to upload both packages after the watch files are fixed/provided. Everything else can just be considered for a future upload. Thanks! -- Andrew Starr-Bochicchio Ubuntu Developer <https://launchpad.net/~andrewsomething> Debian Developer <http://qa.debian.org/developer.php?login=asb> PGP/GPG Key ID: D53FDCB1 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAL6k_AzPAcRdu7fAX5BMdv9wJiLw22VMts=k2k_oepqw2ad...@mail.gmail.com