Re: Newbie question about compiler warnings.

2007-01-15 Thread Justin Pryzby
On Sun, Jan 14, 2007 at 01:17:02PM -0800, Tyler MacDonald wrote: Brandon Barnes [EMAIL PROTECTED] wrote: Are we allowed to disable compiler warnings? What is the preferred method, if the code is fine, and would require a huge overhaul to fix? IANADD However, my feeling is, the less

Newbie question about compiler warnings.

2007-01-14 Thread Brandon Barnes
Are we allowed to disable compiler warnings? What is the preferred method, if the code is fine, and would require a huge overhaul to fix? Specifically, I am thinking of trigraphs. If you know what they are, you probably know exactly how I feel. If you don't, they are a seldom used feature, and

Re: Newbie question about compiler warnings.

2007-01-14 Thread Tyler MacDonald
Brandon Barnes [EMAIL PROTECTED] wrote: Are we allowed to disable compiler warnings? What is the preferred method, if the code is fine, and would require a huge overhaul to fix? IANADD However, my feeling is, the less change to a package you have to do to get it working, the better. If the

Re: Newbie question about compiler warnings.

2007-01-14 Thread Neil Williams
On Sun, 14 Jan 2007 12:54:17 -0800 Brandon Barnes [EMAIL PROTECTED] wrote: Are we allowed to disable compiler warnings? What is the preferred method, if the code is fine, and would require a huge overhaul to fix? Warnings are only a problem if -Werror is also set. If upstream don't use

Re: Newbie question about compiler warnings.

2007-01-14 Thread Darren Salt
I demand that Neil Williams may or may not have written... On Sun, 14 Jan 2007 12:54:17 -0800 Brandon Barnes [EMAIL PROTECTED] wrote: Are we allowed to disable compiler warnings? What is the preferred method, if the code is fine, and would require a huge overhaul to fix? Warnings are only a

Re: Newbie question about compiler warnings.

2007-01-14 Thread Brandon Barnes
Thanks for the input. I guess the answer is, no official policy beyond standard good programming practice. I thought maybe somewhere it was written Thou shalt not suppress any warnings! Wanted to make sure before I did anything like that. In my own projects, I make sure they don't give off any