Re: RFR: chromaprint (Adoption)

2012-01-10 Thread Simon Chopin
On Mon, Jan 09, 2012 at 02:07:42PM +0100, Jakub Wilk wrote: * Simon Chopin chopin.si...@gmail.com, 2012-01-09, 13:38: As a side note, for extra safety it'd be good to make sure that if ever these symbols are used, the generated dependency is either unsatisfiable or strictly versioned.

Re: RFR: chromaprint (Adoption)

2012-01-09 Thread Simon Chopin
On Sun, Jan 08, 2012 at 06:01:39PM +0100, Jakub Wilk wrote: [...] As a side note, for extra safety it'd be good to make sure that if ever these symbols are used, the generated dependency is either unsatisfiable or strictly versioned. Unfortunately, the latter option is currently a bit

Re: RFR: chromaprint (Adoption)

2012-01-09 Thread Jakub Wilk
* Simon Chopin chopin.si...@gmail.com, 2012-01-09, 13:38: As a side note, for extra safety it'd be good to make sure that if ever these symbols are used, the generated dependency is either unsatisfiable or strictly versioned. Unfortunately, the latter option is currently a bit difficult to

Re: RFR: chromaprint (Adoption)

2012-01-08 Thread Jakub Wilk
* Simon Chopin chopin.si...@gmail.com, 2012-01-07, 10:10: But anyway, on i386 I get this lintian error: E: libchromaprint0: symbols-file-contains-current-version-with-debian-revision on symbol _ZNSt6vectorIdSaIdEE14_M_fill_insertEN9__gnu_cxx17__normal_iteratorIPdS1_EEjRKd@Base and 2 others I

Re: RFR: chromaprint (Adoption)

2012-01-07 Thread Simon Chopin
On Wed, Jan 04, 2012 at 01:53:02AM +0100, Jakub Wilk wrote: * Simon Chopin chopin.si...@gmail.com, 2012-01-03, 16:38: +libchromaprint.so.0 libchromaprint0 #MINVER# [c++ symbols] It's slightly worrisome that these symbols are exported in the first place. OTOH I don't know if there's a simple

Re: RFR: chromaprint (Adoption)

2012-01-03 Thread Simon Chopin
Hi Jakub, Thanks for taking the time to review my work. On Thu, Dec 29, 2011 at 11:22:08AM +0100, Jakub Wilk wrote: * Simon Chopin chopin.si...@gmail.com, 2011-12-26, 15:19: http://mentors.debian.net/package/chromaprint Alternatively, one can download the package with dget using this

Re: RFR: chromaprint (Adoption)

2012-01-03 Thread Jakub Wilk
* Simon Chopin chopin.si...@gmail.com, 2012-01-03, 16:38: +libchromaprint.so.0 libchromaprint0 #MINVER# [c++ symbols] It's slightly worrisome that these symbols are exported in the first place. OTOH I don't know if there's a simple and upstreamable way to hide them. (Upstream is using cmake.)

Re: RFR: chromaprint (Adoption)

2011-12-29 Thread Jakub Wilk
* Simon Chopin chopin.si...@gmail.com, 2011-12-26, 15:19: http://mentors.debian.net/package/chromaprint Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/chromaprint/chromaprint_0.6-1.dsc Here's my review: +

RFR: chromaprint (Adoption)

2011-12-26 Thread Simon Chopin
Dear mentors, I am looking for reviews of my package chromaprint. * Package name: chromaprint Version : 0.6-1 Upstream Author : Lukas Lalinsky * URL : http://wiki.acoustid.org/wiki/Chromaprint * License : LGPL-2.1+ Section : libs It builds