Re: Request for peer review of clamav-unofficial-sigs

2018-11-26 Thread Brent Clark
On 2018/11/26 10:58, Paul Wise wrote: On Mon, Nov 26, 2018 at 2:04 PM Brent Clark wrote: I have moved this action to install the man and cron in debian/postinst. This isn't appropriate for packages in Debian, so an alternative mechanism should be used. Perhaps upstream could skip the

Re: Request for peer review of clamav-unofficial-sigs

2018-11-26 Thread Paul Wise
On Mon, Nov 26, 2018 at 2:04 PM Brent Clark wrote: > I have moved this action to install the man and cron in debian/postinst. This isn't appropriate for packages in Debian, so an alternative mechanism should be used. Perhaps upstream could skip the configuration check when the man/cron options

Re: Request for peer review of clamav-unofficial-sigs

2018-11-25 Thread Brent Clark
Good day Paul On 2018/11/23 03:34, Paul Wise wrote: The eXtremeSHOK version doesn't have a clamav-unofficial-sigs.8 so debian/manpages will cause dh_installman to fail. Thats correct. eXtremeSHOK wants you to run "/usr/local/sbin/clamav-unofficial-sigs.sh --install-man" Which creates

Re: Request for peer review of clamav-unofficial-sigs

2018-11-22 Thread Paul Wise
On Thu, Nov 22, 2018 at 8:15 PM Brent Clark wrote: > Im still unclear of what I need to do here. It is completely up to you how to represent your packaging in git. Personally, if I have to use git at all, I like to use a Debian packaging repository that contains only the Debian packaging and

Re: Request for peer review of clamav-unofficial-sigs

2018-11-22 Thread Adam Borowski
On Thu, Nov 22, 2018 at 03:07:36PM +0800, Paul Wise wrote: > I'm not sure how you want to use git for packaging. I used gbp and > pristine-tar. These days I would personally remove all upstream code > from git and store only the debian/ directory. A more popular option > is to use the DEP14

Re: Request for peer review of clamav-unofficial-sigs

2018-11-22 Thread Brent Clark
Good day Paul Thanks so much for your help and mentoring. Please see my replies below. Regards Brent On 2018/11/22 09:07, Paul Wise wrote: On Thu, Nov 22, 2018 at 2:34 PM Brent Clark wrote: I am new to packaging and I would like to ask if someone could please peer review my work. Some

Re: Request for peer review of clamav-unofficial-sigs

2018-11-21 Thread Paul Wise
On Thu, Nov 22, 2018 at 2:34 PM Brent Clark wrote: > I am new to packaging and I would like to ask if someone could please > peer review my work. Some comments: I'm not sure how you want to use git for packaging. I used gbp and pristine-tar. These days I would personally remove all upstream

Request for peer review of clamav-unofficial-sigs

2018-11-21 Thread Brent Clark
Good day Guys I am new to packaging and I would like to ask if someone could please peer review my work. https://salsa.debian.org/brentclark-guest/clamav-unofficial-sigs my work is in the branch bc_packaging_extremeshoks_clamav_unofficial_sigs Basically whats happened is the shipped version