Re: dh: default cmake options overridden

2014-06-12 Thread Rebecca N. Palmer
Ubuntu has some of its security flags enabled by default in the compiler itself, so explicit hardening CFLAGS are unnecessary (but harmless): https://wiki.ubuntu.com/Security/Features To check that this has worked, you can use https://wiki.debian.org/Hardening#Validation However, that's the

Re: dh: default cmake options overridden

2014-06-11 Thread Nico Schlömer
I had an upstream that was not handling the case when it was set to None properly and I guess you have the same issue. And indeed that was the case. Now fixed upstream. Thanks for the hint! --Nico On Wed, Jun 11, 2014 at 5:44 AM, Paul Wise p...@debian.org wrote: On Wed, Jun 11, 2014 at

Re: dh: default cmake options overridden

2014-06-11 Thread Nico Schlömer
As a follow-up on this, when I do MESSAGE($ENV{CFLAGS}) in a CMakeLists.txt, I'm getting different results on different Debian/Ubuntu distros. On Precise (12.04), I'm seeing ``` -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security ``` on Trusty (14.04), I'm seeing ```

dh: default cmake options overridden

2014-06-10 Thread Nico Schlömer
Hi all, if I understand correctly from [1], the default CMAKE_BUILD_TYPE used by dh should be RelWithDebInfo. I found that, when override_dh_auto_configure is not empty in debian/rules, e.g, override_dh_auto_configure: dh_auto_configure -- \ -DCMAKE_SKIP_RPATH:BOOL=ON

Re: dh: default cmake options overridden

2014-06-10 Thread Nico Schlömer
It seems that, instead of the suggestion originally posted in [1], Debian's default CMake setting is `-DCMAKE_BUILD_TYPE=None`, and the specific flags are controlled by the environment variables (CFLAGS and friends). Now, Debian policy [2] advocates `-O2 -g -Wall` for compiling. Somehow, though,

Re: dh: default cmake options overridden

2014-06-10 Thread Paul Wise
On Wed, Jun 11, 2014 at 2:16 AM, Nico Schlömer wrote: How could I best debug this (through debian/rules, maybe)? grep through the upstream cmake files looking for CMAKE_BUILD_TYPE, I had an upstream that was not handling the case when it was set to None properly and I guess you have the same