Re: r-cran-git2r uses private header files of libgit2 (Was: Help with libgit2 needed to strip code copy from r-cran-git2r)

2018-01-12 Thread Andreas Tille
Hi Dirk, On Thu, Jan 11, 2018 at 10:51:45AM -0600, Dirk Eddelbuettel wrote: > > I had some friendly emails with Stefan (git2r upstream) when he started the R > package git2r (as I needed some features in my drat R package) and he > expressed quite some frustration at working with libgit2 as it

Re: r-cran-git2r uses private header files of libgit2 (Was: Help with libgit2 needed to strip code copy from r-cran-git2r)

2018-01-11 Thread Dirk Eddelbuettel
I had some friendly emails with Stefan (git2r upstream) when he started the R package git2r (as I needed some features in my drat R package) and he expressed quite some frustration at working with libgit2 as it changed so much upstream. I know we collectively really hate embedding copies, but

r-cran-git2r uses private header files of libgit2 (Was: Help with libgit2 needed to strip code copy from r-cran-git2r)

2018-01-11 Thread Andreas Tille
Hi again, On Thu, Jan 11, 2018 at 08:34:09AM +0100, Andreas Tille wrote: > > # Add include paths for git2r > > -CPPFLAGS="-I. -Ilibgit2/src -Ilibgit2/include -Ilibgit2/deps/http-parser > > ${CPPFLAGS}" > > -+CPPFLAGS="-I. -I/usr/include/git2 ${CPPFLAGS}" > > ++CPPFLAGS="-I. -idirafter