Bug#776885: RFS: manuel/1.8.0-1 [ITP] -- Python library for documented tests
Hello Daniel, On 02/02/2015 10:22 PM, Daniel Stender wrote: I'm looking for a sponsor for my package of Manuel 1.8.0 [1]. I cannot yet act as a sponsor just yet, as I'm still in the NM process. However, I can provide some immediate feedback, now. Once I become a DD, I'm happy to sponsor this package. It builds those binary packages: python-manuel - Python library for testable documents and documented tests python3-manuel - Python3 library for testable documents and documented tests Mentors upload: http://mentors.debian.net/package/manuel http://mentors.debian.net/debian/pool/main/m/manuel/manuel_1.8.0-1.dsc Buildlog: http://www.danielstender.com/buildlogs/manuel_1.8.0-1_amd64-20150202-2204.build I've made everything ready for a injection into the DPMT repository (SVN fields and Uploaders present). Cool, thanks. The upstream tarball is okay, the license appropriate for distribution by Debian. And copyright information is properly tracked in debian/copyright. debian/changelog: the file I got from mentors.d.o has stable-proposed-updates as a target. That's very unlikely to happen. Please change this to unstable (or leave it at UNRELEASED as in the subversion repository and your sponsor will switch it to unstable). debian/control: As per the advice of my AM, you don't need the X-Python-Version: = 2.6 line, as even oldstable provides python-2.6. Same applies to the B-D on python-all (= 2.6.6-3~). Please remove those in the context of an upload to unstable (or experimental). debian/rules: handling of nodocs looks good and works for me. Docs get installed and registered with doc-base. However, please consider bundling the documentation in a separate -doc package, as it's relatively big compared to the python files. And it's good to avoid the duplication, there. debian/watch: looks fine and works for me. debian/source/*, debian/compat: just a very minor nitpick: I miss a trailing newline on these files. Not that this breaks anything, but I think it's common practice. Thank you for your contribution. Regads Markus Wanner signature.asc Description: OpenPGP digital signature
Bug#781609: sponsorship-requests: RFS: noweb 2.11b-9 (Fixes #781099, unblock #781529)
Package: sponsorship-requests Severity: wishlist (Cc: TeX team, since noweb is somewhat TeX-related) I've updated noweb to fix bug #781099, which has already been unblocked by the release team (#781529), but I am unable to upload because I no longer have a key in the keyring, due to my 1024D being disabled and my 4096R not being connected enough. So I'm looking for someone to sponsor this upload. The package is in otherwise good shape, and will hopefully I will have my 4096R key enabled before another upload is needed. The diff is just a one-line change (not including changelog): diff -u noweb-2.11b/debian/changelog noweb-2.11b/debian/changelog --- noweb-2.11b/debian/changelog +++ noweb-2.11b/debian/changelog @@ -1,3 +1,10 @@ +noweb (2.11b-9) unstable; urgency=low + + * debian/patches/99_touch.dpatch: Add src/shell/noweave to the list of touched +files. (Closes: #781099) + + -- Hubert Chathi uho...@debian.org Fri, 27 Mar 2015 22:06:25 -0400 + noweb (2.11b-8) unstable; urgency=low * debian/control: diff -u noweb-2.11b/debian/patches/99_touch.dpatch noweb-2.11b/debian/patches/99_touch.dpatch --- noweb-2.11b/debian/patches/99_touch.dpatch +++ noweb-2.11b/debian/patches/99_touch.dpatch @@ -12,6 +12,7 @@ -patch) sleep 1 # so that we have at least a second difference in timestaps for x in src/shell/tmac.w \ + src/shell/noweave \ src/shell/noroff \ src/shell/toroff \ src/xdoc/notangle.1 \ Thanks, Hubert -- System Information: Debian Release: 7.2 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.17-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/87zj6tush1@desiato.home.uhoreg.ca
Bug#779377: RFS: classified-ads/0.03-1 / ITP
Control: owner -1 ! Control: tags -1 pending # (above means: I will sponsor you) Am Samstag, den 28.03.2015, 23:34 +0200 schrieb Antti Järvinen: Tobias Frost writes: Am Donnerstag, den 26.03.2015, 01:19 +0200 schrieb Antti Järvinen: E: classified-ads source: depends-on-build-essential-package-without-using-version dpkg-dev so the version numbers remain. You probably do not need the dpkg-dev dependency at all, do you? I was under impression that dpkg-shlibdeps comes from dpkg-dev. pbuilder seems to happily build without and lintian is not complaining - away it goes.. dpkg-dev pulled in by build-essential and therefore you do not need to exclitly state it, except if you have a version constraint. (need a minimum version of dpkg-dev; (read the description on the above quoted lintian error; this also points you to Policy §4.2) You need to add -b debian then to VCS-Git (Refer to Policy 5.6.26) Yes. Well, you should not copy the license *text* into d/copyright, but you still need to put the license *grant* into it. The license grant is the header of your source files. So, you'd write License: LGPL-2.1+ Classified Ads is free software; you can redistribute it and/or ... Ok, I'll try restructuring. Software aside, this seems like complexiest thing ever.. No doubt, Copyright is complex; and this also very usual that sponsorees don't get it right the few first times :) But looking at the repository it looks fine now. (Though I will do a final copyright check just before uploading -- because this topic is complex and it is easy to overlook something.) general: - Huge high-resolution bitmaps removed from source Not checked in the code, but this raises a flag: In Debian you need to have the source in the preferred form for modifications and for images this is the _best_ resolution. (And as said earlier, you need to compute the lower resolution at build time) Bitmaps are not modified at build-time, only wrapped into qt-format resource file. The binary .deb contains actually exactly same bits in bitmaps that are in orig.tar.gz. I was thinking about keeping the high-resolution gimp files in upstream repo anyway but not in source package as there is no transform done.. No, you've got me wrong... In Debian we build *everything* from source. Spoken in source code analogy: Your high resolution file is the source (like a cpp file) code, the bitmap is the object code: As like you need to compile your cpp file, you must regenerate the bitmap during the build from the highres image. Debian sees the (high-res image) as part of the source code, the preferred form of the source actually. So you should include it into your tarball and create the actual bitmaps at build-time. Did not check the code, but you also ensure that the RAM is not swapped out? Yes and no. For actual key handling the task is outsourced to OpenSSL and I hope it is doing the Right Thing (starting from 1.0.1g it actually might, seems..). For content no, it is all over the place and goes through qt code also so I think easiest would be to flag the whole process out of swap if possible. After the heartbleed episode I marked a future development task of moving all key-handling into separate process, away from process where networking happens. ..the paranoid operators will have no swap or encrypted swap. ..but I've tried to keep things simple also for end-users. Here you get automatic content signing+encryption always whenever possible. Still I wouldn't like to start adding a manpage section about setting up encrypted swap. Fine with me, just wanted to know if you put some thoughts into this aspect. Regarding my question regarding your plans for involvement into Debian -- Do you want to share your thoughts about this? I've been trying to get involved into group things, as I was thinking this is kind of soft-landing into debian process. I've been in discussion with openssl team but then received no definite yes/no answer from them, nor any concrete work items to start working with. In the meantime I've been trying to do reviews on tickets that no-one has yet checked. Yes I saw it; thank you a lot. I noticed you had been marketing qemuctl in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780270 so if I say that I know qt and qemu in advance (I do) and after half-hour study about understand the qemuctl behaviour, you think I could ITA this package? Sure, just follow the ITa procedure. (I will also sponsor you on this) .. the part that I'm worried about is the mechanics of actual releasing (done in collab-maint?) so that I won't wreck the whole distro.. Its just a git repository ;-) No big risk to ruin everything. You could also move the repository somewhere else, if you don't like collab-maint. I'm not lazy, but this qemuctl looks like a low-maintenance work-item to me. ..isn't the
Bug#781609: sponsorship-requests: RFS: noweb 2.11b-9 (Fixes #781099, unblock #781529)
Hi Hubert, I can upload. Can you sign this message? Cheers, Eriberto 2015-03-31 11:55 GMT-03:00 Hubert Chathi uho...@debian.org: Package: sponsorship-requests Severity: wishlist (Cc: TeX team, since noweb is somewhat TeX-related) I've updated noweb to fix bug #781099, which has already been unblocked by the release team (#781529), but I am unable to upload because I no longer have a key in the keyring, due to my 1024D being disabled and my 4096R not being connected enough. So I'm looking for someone to sponsor this upload. The package is in otherwise good shape, and will hopefully I will have my 4096R key enabled before another upload is needed. The diff is just a one-line change (not including changelog): diff -u noweb-2.11b/debian/changelog noweb-2.11b/debian/changelog --- noweb-2.11b/debian/changelog +++ noweb-2.11b/debian/changelog @@ -1,3 +1,10 @@ +noweb (2.11b-9) unstable; urgency=low + + * debian/patches/99_touch.dpatch: Add src/shell/noweave to the list of touched +files. (Closes: #781099) + + -- Hubert Chathi uho...@debian.org Fri, 27 Mar 2015 22:06:25 -0400 + noweb (2.11b-8) unstable; urgency=low * debian/control: diff -u noweb-2.11b/debian/patches/99_touch.dpatch noweb-2.11b/debian/patches/99_touch.dpatch --- noweb-2.11b/debian/patches/99_touch.dpatch +++ noweb-2.11b/debian/patches/99_touch.dpatch @@ -12,6 +12,7 @@ -patch) sleep 1 # so that we have at least a second difference in timestaps for x in src/shell/tmac.w \ + src/shell/noweave \ src/shell/noroff \ src/shell/toroff \ src/xdoc/notangle.1 \ Thanks, Hubert -- System Information: Debian Release: 7.2 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.17-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/87zj6tush1@desiato.home.uhoreg.ca -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAP+dXJdMGx=twf2fc2yxdevpmcws1pq2t8xddbvkhq1rsqj...@mail.gmail.com
Bug#781609: sponsorship-requests: RFS: noweb 2.11b-9 (Fixes #781099, unblock #781529)
On Tue, 31 Mar 2015 12:44:49 -0300, Eriberto Mota eribe...@debian.org said: Hi Hubert, I can upload. Can you sign this message? Thanks. If it works properly, this message should be signed with both my old 1024D and my new 4096R key. I just noticed that I forgot to post the download location for my package (though you'll obviously want to rebuild it yourself). You can download the packages that I built at: https://debian.uhoreg.ca/experimental/noweb/ Cheers, Eriberto 2015-03-31 11:55 GMT-03:00 Hubert Chathi uho...@debian.org: Package: sponsorship-requests Severity: wishlist (Cc: TeX team, since noweb is somewhat TeX-related) I've updated noweb to fix bug #781099, which has already been unblocked by the release team (#781529), but I am unable to upload because I no longer have a key in the keyring, due to my 1024D being disabled and my 4096R not being connected enough. So I'm looking for someone to sponsor this upload. The package is in otherwise good shape, and will hopefully I will have my 4096R key enabled before another upload is needed. The diff is just a one-line change (not including changelog): diff -u noweb-2.11b/debian/changelog noweb-2.11b/debian/changelog --- noweb-2.11b/debian/changelog +++ noweb-2.11b/debian/changelog @@ -1,3 +1,10 @@ +noweb (2.11b-9) unstable; urgency=low + + * debian/patches/99_touch.dpatch: Add src/shell/noweave to the list of touched + files. (Closes: #781099) + + -- Hubert Chathi uho...@debian.org Fri, 27 Mar 2015 22:06:25 -0400 + noweb (2.11b-8) unstable; urgency=low * debian/control: diff -u noweb-2.11b/debian/patches/99_touch.dpatch noweb-2.11b/debian/patches/99_touch.dpatch --- noweb-2.11b/debian/patches/99_touch.dpatch +++ noweb-2.11b/debian/patches/99_touch.dpatch @@ -12,6 +12,7 @@ -patch) sleep 1 # so that we have at least a second difference in timestaps for x in src/shell/tmac.w \ + src/shell/noweave \ src/shell/noroff \ src/shell/toroff \ src/xdoc/notangle.1 \ Thanks, Hubert -- System Information: Debian Release: 7.2 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.17-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/87zj6tush1@desiato.home.uhoreg.ca -- Hubert Chathi uho...@debian.org -- Jabber: hub...@uhoreg.ca PGP/GnuPG key: 1024D/124B61FA http://www.uhoreg.ca/ Fingerprint: 96C5 012F 5F74 A5F7 1FF7 5291 AF29 C719 124B 61FA signature.asc Description: PGP signature
Bug#780096: RFS: dyfi/1.2.0-1 [ITP #779708]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There is no if statement in d/config. Did you mean one in d/postinst? It is needed to run only at the package configuration phase. Ok, actually, according to http://www.fifi.org/doc/debconf-doc/tutorial.html it seems like the options for $1 are configure and reconfigure so in your case it is quite ok to do all actions in both cases. I've myself run into surprises somehow if I've not conditioned.. Thanks for comments, My pleasure, - -- Antti -BEGIN PGP SIGNATURE- Version: GnuPG v1 Comment: Processed by Mailcrypt 3.5.8 http://mailcrypt.sourceforge.net/ iD8DBQFVGu6UUTdja+nNMWMRAtsTAKCHnaW7eQ6KNjoAuDCKfkXGvr46TACfaHp/ +Zj1dQ9obhPGu2Sh7RvJhu4= =Z7K9 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/21786.61093.955707.487...@muikku.katiska.org
Bug#781609: marked as done (sponsorship-requests: RFS: noweb 2.11b-9 (Fixes #781099, unblock #781529))
Your message dated Tue, 31 Mar 2015 16:24:16 -0300 with message-id cap+dxjd9l1w+q4bor9or3-val7y3ym8-wjyj5vtdohtstfl...@mail.gmail.com and subject line Re: Bug#781609: sponsorship-requests: RFS: noweb 2.11b-9 (Fixes #781099, unblock #781529) has caused the Debian Bug report #781609, regarding sponsorship-requests: RFS: noweb 2.11b-9 (Fixes #781099, unblock #781529) to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 781609: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781609 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- Package: sponsorship-requests Severity: wishlist (Cc: TeX team, since noweb is somewhat TeX-related) I've updated noweb to fix bug #781099, which has already been unblocked by the release team (#781529), but I am unable to upload because I no longer have a key in the keyring, due to my 1024D being disabled and my 4096R not being connected enough. So I'm looking for someone to sponsor this upload. The package is in otherwise good shape, and will hopefully I will have my 4096R key enabled before another upload is needed. The diff is just a one-line change (not including changelog): diff -u noweb-2.11b/debian/changelog noweb-2.11b/debian/changelog --- noweb-2.11b/debian/changelog +++ noweb-2.11b/debian/changelog @@ -1,3 +1,10 @@ +noweb (2.11b-9) unstable; urgency=low + + * debian/patches/99_touch.dpatch: Add src/shell/noweave to the list of touched +files. (Closes: #781099) + + -- Hubert Chathi uho...@debian.org Fri, 27 Mar 2015 22:06:25 -0400 + noweb (2.11b-8) unstable; urgency=low * debian/control: diff -u noweb-2.11b/debian/patches/99_touch.dpatch noweb-2.11b/debian/patches/99_touch.dpatch --- noweb-2.11b/debian/patches/99_touch.dpatch +++ noweb-2.11b/debian/patches/99_touch.dpatch @@ -12,6 +12,7 @@ -patch) sleep 1 # so that we have at least a second difference in timestaps for x in src/shell/tmac.w \ + src/shell/noweave \ src/shell/noroff \ src/shell/toroff \ src/xdoc/notangle.1 \ Thanks, Hubert -- System Information: Debian Release: 7.2 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.17-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash ---End Message--- ---BeginMessage--- 2015-03-31 15:40 GMT-03:00 Hubert Chathi uho...@debian.org: On Tue, 31 Mar 2015 12:44:49 -0300, Eriberto Mota eribe...@debian.org said: Hi Hubert, I can upload. Can you sign this message? Thanks. If it works properly, this message should be signed with both my old 1024D and my new 4096R key. I think that we have 1024D only. No problem. I just noticed that I forgot to post the download location for my package (though you'll obviously want to rebuild it yourself). You can download the packages that I built at: https://debian.uhoreg.ca/experimental/noweb/ Ah, ok. Before, I applied your patch to test the package. Now, I uploaded the version gotten from your site. Call me if you need more help. Cheers, Eriberto---End Message---
Bug#781609: sponsorship-requests: RFS: noweb 2.11b-9 (Fixes #781099, unblock #781529)
2015-03-31 15:40 GMT-03:00 Hubert Chathi uho...@debian.org: On Tue, 31 Mar 2015 12:44:49 -0300, Eriberto Mota eribe...@debian.org said: Hi Hubert, I can upload. Can you sign this message? Thanks. If it works properly, this message should be signed with both my old 1024D and my new 4096R key. I think that we have 1024D only. No problem. I just noticed that I forgot to post the download location for my package (though you'll obviously want to rebuild it yourself). You can download the packages that I built at: https://debian.uhoreg.ca/experimental/noweb/ Ah, ok. Before, I applied your patch to test the package. Now, I uploaded the version gotten from your site. Call me if you need more help. Cheers, Eriberto -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cap+dxjd9l1w+q4bor9or3-val7y3ym8-wjyj5vtdohtstfl...@mail.gmail.com
Bug#780096: RFS: dyfi/1.2.0-1 [ITP #779708]
On Tue, Mar 31, 2015 at 8:42 PM, Antti Järvinen antti.jarvi...@katiska.org wrote: [...] So, the comments: about debian/config: - Is it necessary to have condition if [ $1 = configure ]; then .. fi around db_input/db_go -commands? I'm under impression that this config-script might be run also on other situations than config ; or is this intentional? There is no if statement in d/config. Did you mean one in d/postinst? It is needed to run only at the package configuration phase. about debian/copyright: - According to https://lists.debian.org/debian-devel-announce/2006/03/msg00023.html you should have, among other things in the copyright file the authors name and year of the copyright. Year is missing for Files: * and then I'm not sure if dy.fi admins count as name of author ; I understand that there may be real organization of human behind dy.fi that have developed the sw but .. naming a person, a company or other entity that may be recognized by rule of law (in Finland?) might be a jolly good idea? - There are Files-Excluded mentioned in copyright ; it might be required to explicitly state that they may be distributed anyway, for example using permissive license, if the files fall into such category. Thanks, I'll try to address these issues. about debian/po/templates.pot Minor whining: When username is queried, would it be nice to indicate that this is exactly dy.fi system username and not just username or is this going to be very clear in advance to person doing the installation? I understood that the user account needs to exists beforehand.. about debian/postinst What is going to be file permission of /etc/dyfi-update.conf ? It may contain user account + password to remote box? Restricted to dyfi user, but true it can be accessed by others. general: There is no documentation of any kind. Maybe a short manpage might be in order? Well, it's not really a binary, it's a daemon so you can only check it's state. Thanks for comments, Eugene -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/capqgmfjx7jd0wyozdpqxar+28qxbhoh3ek-xsbng-a7qk3o...@mail.gmail.com
Bug#781622: RFS: opentyrian/2.1.20130907-1 [ITP]
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package opentyrian * Package name: opentyrian Version : 2.1.20130907-1 Upstream Author : The OpenTyrian Development Team * URL : https://bitbucket.org/opentyrian/opentyrian/wiki/Home * License : GPL-2+ Section : games It builds those binary packages: opentyrian - open-source port of the DOS shoot-em-up Tyrian OpenTyrian (ITP #553035) is a free engine for non-free game tyrian, whose assets are downloaded by game-data-packager. I uploaded a package on mentors and it is dgettable at the following URL: dget -x http://mentors.debian.net/debian/pool/contrib/o/opentyrian/opentyrian_2.1.20130907-1.dsc Alternatively, you may access the git repository at: git+ssh://git.debian.org/git/pkg-games/opentyrian.git I'm happy to hear your remarks about this package. Also, please note that I'm a Debian Maintainer, so once this clears NEW I'm interested in uploading the next revisions myself. Thanks! -- Etienne Millon signature.asc Description: Digital signature
Bug#780096: RFS: dyfi/1.2.0-1 [ITP #779708]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Eugene, I noticed your RFS ticket and made a short review about the package. I'm not a DD so I can't sponsor your package but hopefully this is useful for someone considering sponsorship. So, the comments: about debian/config: - Is it necessary to have condition if [ $1 = configure ]; then .. fi around db_input/db_go -commands? I'm under impression that this config-script might be run also on other situations than config ; or is this intentional? about debian/copyright: - According to https://lists.debian.org/debian-devel-announce/2006/03/msg00023.html you should have, among other things in the copyright file the authors name and year of the copyright. Year is missing for Files: * and then I'm not sure if dy.fi admins count as name of author ; I understand that there may be real organization of human behind dy.fi that have developed the sw but .. naming a person, a company or other entity that may be recognized by rule of law (in Finland?) might be a jolly good idea? - There are Files-Excluded mentioned in copyright ; it might be required to explicitly state that they may be distributed anyway, for example using permissive license, if the files fall into such category. about debian/po/templates.pot Minor whining: When username is queried, would it be nice to indicate that this is exactly dy.fi system username and not just username or is this going to be very clear in advance to person doing the installation? I understood that the user account needs to exists beforehand.. about debian/postinst What is going to be file permission of /etc/dyfi-update.conf ? It may contain user account + password to remote box? general: There is no documentation of any kind. Maybe a short manpage might be in order? The perl-script itself seems to start and start doing its job (I could not really verify as I do not have dy.fi user account), also the daemon is stopped upon uninstall (that is going to happen to a lot of users who install this and then notice that service is available in finland only..). - -- Antti Järvinen -BEGIN PGP SIGNATURE- Version: GnuPG v1 Comment: Processed by Mailcrypt 3.5.8 http://mailcrypt.sourceforge.net/ iD8DBQFVGtyNUTdja+nNMWMRAoT7AJ46cYaIve87oib+T9YDeZWKPU6rzwCfQyL0 fHf3Hs2owx9VKKalPym6RTo= =wzro -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/21786.56474.712657.884...@muikku.katiska.org
Bug#781622: RFS: opentyrian/2.1.20130907-1 [ITP]
On Tue, 31 Mar 2015 19:35:12 Etienne Millon wrote: I am looking for a sponsor for my package opentyrian That is very nice. I was looking forward to see opentyrian in Debian for a while. Thanks for packaging. I'm happy to hear your remarks about this package. First thing to improve is to add more DEP-3 [1] headers to patches. Specifically the following (missing) headers would be useful: Forwarded Last-Update Origin Applied-Upstream Working with upstream is important part of package maintenance. From looking at patch headers I need to see whether it was Forwarded, when Last-Update happened, where patch was taken from (Origin, if it was borrowed from upstream or from another distro) and sometimes Applied-Upstream status. If you did not forward patches yet I'd recommend to wait no further and document progress as described. Also there are some remarks about packaging: * There should be versioned Depends on game-data-packager which actually support tyrian-data (i.e. tyrian-data | game-data-packager (= 40)). * Package should install icon (there are some in linux/icons). Icon is referenced from installed .desktop file. * Repository do not match package uploaded to Mentors. There are differences in control (Standards-Version) and in README.Debian. * Why not enable full hardening? (e.g. export DEB_BUILD_MAINT_OPTIONS = hardening=+all) * Re-distribution of pre-built binary macosx/tyrian.icns in source archive may be a bit of concern. * There is a comma , which is not present in the original copyright statement after copyright year in Files: ./src/video_scale_hqNx.c Copyright: 2003, MaxSt ( ma...@hiend3d.com ) IMHO it should be just 2003, not 2003,. Other than this debian/copyright looks good. Also, please note that I'm a Debian Maintainer, so once this clears NEW I'm interested in uploading the next revisions myself. Thanks! Great attitude. :) [1]: http://dep.debian.net/deps/dep3/ -- Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B --- The truth is incontrovertible, malice may attack it, ignorance may deride it, but in the end; there it is. -- Winston Churchill signature.asc Description: This is a digitally signed message part.
