Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Yangfl]

2018-03-01 4:37 GMT+08:00 Tobias Frost :
> Hi Yangfl,
>
> the package has now been accepted.
> However, I noticed that it targets "experimental", something I missed
> in the last review. Can you prepare another upload for unstable?
>
> And please tag the release on salsa! TIA!
>
> --
> tobi

Uploaded to https://salsa.debian.org/pkg-deepin-team/granite . Thanks
for your reminder.

Bug#891813: RFS: i2pd/2.18.0-1 [ITP]

[Yangfl]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "i2pd"

 * Package name: i2pd
   Version : 2.18.0-1
   Upstream Author : R4SAS
 * URL : https://github.com/PurpleI2P/i2pd
 * License : BSD
   Section : net


  It builds those binary packages:

i2pd  - Full-featured C++ implementation of I2P client

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/i2pd


  Alternatively, one can download the package with dget using this command:

dget -x https://mentors.debian.net/debian/pool/main/i/i2pd/i2pd_2.18.0-1.dsc

  Git repo:

https://salsa.debian.org/yangfl-guest/i2pd

Regards,
Yangfl

Bug#886399: RFS: opencascade/7.2.0-1 [ITP]

[Kurt Kremitzki]

On 02/27/2018 12:02 PM, Tobias Frost wrote:

Hi,

just to avoid a dead-lock: you're still working on the package, nothing to
review atm?
Just let us know (and remove the moreinfo tag as sign) when ready for
the next round of review. (I'd like to avoid reviewing when not everything
has been implemented)

--
tobi



Yep, I'm still working on it--I got stuck for quite a while by the issue 
I mentioned in my reply to Anton (the dpkg-shlibdeps errors.) I just 
fixed this a couple of days ago (missing *.substvars files) so hopefully 
I should be able to wrap up the rest of your suggestions soon.


I do have a question regarding the naming of everything, though. 
According to `objdump -p lib*.so | grep SONAME`, where * is any of the 
objects provided by OpenCASCADE 7.2.0, the SONAME is just 7, although 
lib*.so and lib*.so.7 are both just symlinks to lib*.so.7.2.0. This 
creates some uncertainty...


To summarize:
1. When the OCC was in Debian previously, and its current form in the 
Ubuntu PPA, we had e.g. libopencascade-foundation-7.1.0

2. Anton suggested e.g. libopencascade-foundation-7.2
3. Appendix A of the Debian New Maintainer's Guide [1] suggests 
libopencascade-foundation7 is correct
4. Some packages also use the form libopencascade7-foundation, and this 
seems most correct to me


But which one should be used here? In the case of 4, would the -dev 
files just be e.g. libopencascade-foundation-dev? or libopencascade7-*-dev?


I suppose, also, that I should split opencascade-draw into a library and 
non-library part. I updated its description to reflect why it should be 
included:
	"Draw is a command interpreter based on TCL and a graphical system used 
to test and demonstrate Open CASCADE Technology modeling libraries."


Upstream requires bug reports to use it to show reproducibility of 
problems, and it's useful for learning the library, so it does need to 
be included.


Regarding the problematic binary name DRAWEXE, besides just getting rid 
of uppercase I thought perhaps it would be good to just rename it to 
e.g. `opencascade7-draw`. Thoughts?


I'll add the -doc package as well. What exactly would this be named, by 
the way, in light of my version question above? And while I'm at it, 
should I consider a -dbg package?



1. https://www.debian.org/doc/manuals/maint-guide/advanced.en.html#library

Bug#891811: RFS: hoteldruid/2.2.2-1

[Marco M. F. De Santis]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "hoteldruid":

* Package name: hoteldruid
  Version : 2.2.2-1
  Upstream Author : Marco M. F. De Santis
* URL : http://www.hoteldruid.com
* License : AGPLv3
  Section : web

It builds those binary packages:

  hoteldruid - web-based property management system for hotels or B

To access further information about this package, please visit the 
following URL:


  https://mentors.debian.net/package/hoteldruid

Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/h/hoteldruid/hoteldruid_2.2.2-1.dsc


More information about hoteldruid can be obtained from 
http://www.hoteldruid.com.


Changes since the last upload:

  * New upstream release.
  * debian/control: updated Standards-Version and added
Rules-Requires-Root
  * debian/control: added recommendation on php-imap previously included
in core php packages
  * debian/install: changed AppStream metadata location as required by
new AppStream guidelines
  * debian/install: removed xpm icon and added 64x64 png icon
  * debian/extra/appdata/hoteldruid.appdata.xml: changed license to
CC0-1.0
  * debian/compat: updated debhelper compatibility level to 11

Regards,
Marco M. F. De Santis

Bug#861649: Newer version uploaded

[Gard Spreemann]

On Wednesday, 28 February 2018 22:26:58 CET Tobias Frost wrote:
> Ok, it builds now.
> But there are tons of lintian warnings "privacy-break-generic", just
> one example: Not checked, but maybe some template for the doc
> generation has a link to this site?
> 
> […]
> 
> There are other lintian warnings as well; just a friendly reminder to
> alwyays run linitian. Better, include it in your build process so that
> it is automatically executed...

Very good point! Thanks a lot for pointing this out! I'll see if I can
patch the docs to avoid this; if not, I'll avoid building a
documentation package alltogether.

Are there other aspects of the package you feel should be improved?


 Best,
 Gard

Bug#881946: RFS: keychain/2.8.4+dfsg-1 [ITA]

[Tobias Frost]

Control: tags -1 moreinfo

I did a very quick but incomplete check on the package:

- there are many lintian messages (some warnings)
- d/compat is 9, should be bumped.
- Uploaders: Ondřej Surý  ... undocumented in the
changelog. (I assume Ondřej wants to be uploader, doesn't he? I do not
find anything in the ITP or elsewhere documenting this)
- I think the remarks from Niels are not yet adressed, are they?
- Maybe you want also to be added to d/copyright for debian/* (this is
optional)
- dep3 headers for the patch should be added. 
  - e.g has the patch been sent upstream?

--
tobi 



> Uploaders: Ondřej Surý 
> 


On Thu, 04 Jan 2018 14:09:37 +0100 Tobias Frost 
wrote:
> Control: tags -1 moreinfo
> 
> There is a new upload on mentors, but did not check was has been
> changed.
> 
> --
> tobi
> 
> 

Bug#891643: I'd appreciate if you could also give me upload rights for this package.

[Geert Stappers]

On Tue, Feb 27, 2018 at 05:27:37PM +0100, Félix Sipma wrote:
> 
} I am looking for a sponsor for package "inkscape-open-symbols".
> 
> 
> I'd appreciate if you could also give me upload rights for this package.
> 

That is documented at https://wiki.debian.org/DebianMaintainer

Yes, that implies it takes some initial effort.
Compare it with learning something new.


Groeten
Geert Stappers
-- 
Leven en laten leven

Bug#884697: RFS: logrotate/3.13.0-1 ITA

[Tobias Frost]

Ping...

Bug#891244: closing 891244

[Tobias Frost]

close 891244 
thanks

Bug#891244: RFS: gnumail/1.2.2-1.1+deb9u1 [RC] [stable]

[Tobias Frost]

On Fri, 23 Feb 2018 20:39:33 +0200 Yavor Doganov  wrote:
> Yavor Doganov wrote:
> >  * Package name: gnumail
> >Version : 1.2.2-1.1+deb9u1
> 
> Forgot to mention the release.d.o bug: #886636
> 
> 

Uploaded.
Thanks for your contribution to Debian!

--
tobi

Bug#861649: Newer version uploaded

[Tobias Frost]

Control: tags -1 moreinfo

On Mon, 05 Feb 2018 11:07:40 +0100 Gard Spreemann  wrote:
> Control: tags -1 - moreinfo
> 
> On Tuesday 26 December 2017 21:58:36 CET Tobias Frost wrote:
> > I was checking your RFS, but I cannot get it compiled...
> > Please check and then remove the moreinfo tag again...
> 
> Hello again,
> 
> Upstream has now released GUDHI 2.1.0 which is compatible with the
> CGAL version in sid.
> 
> If you have a chance to take a look, version 2.1.0-1 of the package
> can be obtained from
> 
>  https://mentors.debian.net/debian/pool/main/g/gudhi/gudhi_2.1.0+dfsg
-1.dsc
> 

Ok, it builds now.
But there are tons of lintian warnings "privacy-break-generic", just
one example: Not checked, but maybe some template for the doc
generation has a link to this site?

W: libgudhi-doc: privacy-breach-generic
usr/share/doc/libgudhi/html/_active__witness_8h_source.html [http://gudhi.gforge.inria.fr/assets/img/home.png;
alt="gudhi">] (http://gudhi.gforge.inria.fr/assets/img/home
.png) 
W: libgudhi-doc: privacy-breach-generic
usr/share/doc/libgudhi/html/_active__witness_8h_source.html [http://pages.saclay.inria.fr/vin
cent.rouvreau/gudhi/gudhi-doc-
2.0.0/assets/css/styles_feeling_responsive.css" />] (http://pages.sacla
y.inria.fr/vincent.rouvreau/gudhi/gudhi-doc-
2.0.0/assets/css/styles_feeling_responsive.css)

There are other lintian warnings as well; just a friendly reminder to
alwyays run linitian. Better, include it in your build process so that
it is automatically executed...


--
tobi

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Tobias Frost]

Hi Yangfl,

the package has now been accepted.
However, I noticed that it targets "experimental", something I missed
in the last review. Can you prepare another upload for unstable?

And please tag the release on salsa! TIA!

--
tobi

Bug#887403: marked as done (RFS: budgie-extras/0.4.2-1)

[Debian Bug Tracking System]

Your message dated Wed, 28 Feb 2018 16:21:27 +
with message-id 
and subject line closing RFS: budgie-extras/0.4.2-1
has caused the Debian Bug report #887403,
regarding RFS: budgie-extras/0.4.2-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
887403: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887403
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "budgie-extras"

 * Package name: budgie-extras
   Version : 0.4.0-1
   Upstream Author : Ubuntu Budgie Developers
 * URL : https://github.com/ubuntubudgie/budgie-extras
 * License : GPL-3+
   Section : misc

  It builds those binary packages:

budgie-clockworks-applet - Applet to display clock across multiple
time zones
 budgie-countdown-applet - Applet providing a countdown capability on
the Budgie Desktop
 budgie-dropby-applet - Applet to popup when a USB device is connected
 budgie-hotcorners-applet - Applet providing hotcorners capabilities
for the Budgie Desktop
 budgie-keyboard-autoswitch-applet - Applet adding the ability to set
a different keyboard layout per
 budgie-previews-applet - Applet providing window previews
capabilities for the Budgie Desk
 budgie-quicknote-applet - Applet providing simple notes capability
for the Budgie Desktop
 budgie-rotation-lock-applet - Applet to lock or unlock the screen rotation
 budgie-showtime-applet - Applet displaying date and time on the Budgie Desktop
 budgie-window-mover-applet - Applet allows moving windows between
workspaces for the Budgie De
 budgie-workspace-overview-applet - Applet providing quick access to
workspaces for the Budgie Deskto
 budgie-workspace-wallpaper-applet - Applet providing per workspace wallpaper

  To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/budgie-extras

  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/b/budgie-extras/budgie-extras_0.4.0-1.dsc

Notes:
1. This is a new release from the Ubuntu Budgie team providing budgie
desktop applets for
Debian and all subscriber derivatives
2. lintian -i -I --pedantic has been run on the build sources-changes
file and  is lintian free
3. check-all-the-things has been run on the source.  Fixes where
thought appropriate has been incorporated into the source before
packaging.
4. Overview of the source changes can be found in the ChangeLog file
found in the source.

Testing:

The minimal XFCE based Debian Buster was upgraded to unstable and
budgie-desktop was installed.

The package was built and each individual binary package was installed
and tested to confirm that they work correctly - this importantly
caught all the necessary runtime dependencies that have been captured
in debian/control

  Changes since the last upload:

  * New upstream release
  * Packaging Changes:
- debian/control and debian/compat: update to v11
- debian/control: Bump Standards-Version - no changes required
- debian/control: new binary packages budgie-rotation-lock-applet,
  budgie-clockworks-applet,
  budgie-dropby-applet
- debian/copyright: 2018 year updates

  Regards,
   David Mohammed
--- End Message ---
--- Begin Message ---
Package budgie-extras version 0.4.2-1 is in unstable now.
https://packages.qa.debian.org/budgie-extras--- End Message ---

Bug#891005: RFS: gdbm/1.14.1-5

[KAction]

[2018-02-28 10:21] Ansgar Burchardt 
> Gianfranco Costamagna writes:
> > I think there is nothing to worry about :)
> >
> > this is the path:
> > /usr/lib/*/diet/*/libgdbm.a
> 
> It is a problem as the package might provide different functionality
> when someone else builds and uploads it.

Well, should I introduce whole binary package with just one single
gdbm.a instead?

Bug#891005: RFS: gdbm/1.14.1-5

[Ansgar Burchardt]

Gianfranco Costamagna writes:
>>This means building the package will give different results depending
>>on dietlibc-dev installed or not?  That shouldn't happen...
>>
>>Please check via some other means that a build using dietlibc has been
>>requested; don't do different things just because a package happens to
>>be installed.
> mmm the result is not a different library, but an additional static library 
> put
> in a non-standard directory, built with another glibc.
> I think there is nothing to worry about :)
>
> this is the path:
> /usr/lib/*/diet/*/libgdbm.a

It is a problem as the package might provide different functionality
when someone else builds and uploads it.

We had problems with packages built in non-clean environments for a long
time, though it has admittedly become better with most (not all)
developers building packages in clean environments (sbuild, pbuilder,
...) or using source-only uploads.

Ansgar