Bug#831792: RFS: scid/1:4.6.2-0.1 [NMU]

[Gianfranco Costamagna]

Hi,

>Sorry for this late replay, I've been working on your advices and meanwhile 
>packaging a new released version (4.6.4).
>You'll see in this new version I had to repack upstream sources to make the 
>package DFSG compliant. Oliver did it with a script (prep.sh); I've used uscan 
>and >excluding files in debian/copyright (hope it's correct).

thanks :)

>P.D: On mentors, the watch file seems that doesn't work but on my devel 
>machine is working properly ??

not a problem.

(mentors uscan seems to be outdated)

new review:
1) please convert the versioning into 1:4.6.2-1 and remove the NMU syntax.
and add a "Set myself as Maintainer"

2) missing newline between last entry and your signature
to make it DFSG compliant.
-- Jose G. López   Mon, 08 Aug 2016 11:23:07 +0200


3) copyrights missing
grep -i copyright . -R |grep -v Fulv |grep -v Shane |grep -vi pascal


after that we should be *really* good, and I'll put the package in deferred, to 
make it reach unstable in 15 days or so
(mia team should orphan the package in the meanwhile).
In case it gets orphaned close the bug with
"set myself as Maintainer (Closes: #)

thanks!

G.

Bug#831792: RFS: scid/1:4.6.2-0.1 [NMU]

[Jose G. López]

On Tue, 26 Jul 2016 18:18:51 + (UTC)
Gianfranco Costamagna  wrote:

> lets see.
> 1)
> 
> The package will be probably orphaned in 10-15 days, so you might want to set 
> yourself
> as Maintainer and adopt it
> 
> 2)
> +* Copyright (C) 2013-2015  Fulvio Benini
> 
> 
> maybe you want also to put copyright file in machine readable format
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
> 

Done.

> 3) 
> X: scid source: maybe-not-arch-all-binnmuable scid -> scid-data
> 
> 4) the breaks+replaces can be dropped, since that version is already 
> available in oldstable
> 
> Breaks: scid (<=1:4.3.0.cvs20110714-2)
> Replaces: scid (<=1:4.3.0.cvs20110714-2)
> Recommends: scid (>=1:4.3.0.cvs20111216-1)
> 

Dropped.

> last thing:
> 
> 4) this hack seems useless now
> sed s/x86_64-linux-gnu/$(DEB_HOST_MULTIARCH)/ configure > configure.sed
> chmod 755 configure.sed
> ./configure.sed BINDIR="$(CURDIR)/debian/tmp/scid/usr/games" \

Deleted too.

> 
> please fix the above and I'll give another review/upload.
> 
> thanks,
> 
> G.

Hi Gianfranco,

Sorry for this late replay, I've been working on your advices and meanwhile 
packaging a new released version (4.6.4).
You'll see in this new version I had to repack upstream sources to make the 
package DFSG compliant. Oliver did it with a script (prep.sh); I've used uscan 
and excluding files in debian/copyright (hope it's correct).

It's uploaded to mentors[0].

Thanks and regards,

P.D: On mentors, the watch file seems that doesn't work but on my devel machine 
is working properly ??

[0]https://mentors.debian.net/package/scid


pgpgdVz1PK0qZ.pgp
Description: PGP signature

Bug#831792: RFS: scid/1:4.6.2-0.1 [NMU]

[James Cowgill]

On Tue, 2016-07-26 at 18:18 +, Gianfranco Costamagna wrote:
> control: owner -1 !
> control: tags -1 moreinfo
> 
> > I am looking for a sponsor for my package "scid":
[...]
> 3) 
> X: scid source: maybe-not-arch-all-binnmuable scid -> scid-data

This lintian tag does not indicate your package has a bug in it. The
tags description even states that you should not attempt to fix it.

James

signature.asc
Description: This is a digitally signed message part

Bug#831792: RFS: scid/1:4.6.2-0.1 [NMU]

[Gianfranco Costamagna]

last thing:

4) this hack seems useless now
sed s/x86_64-linux-gnu/$(DEB_HOST_MULTIARCH)/ configure > configure.sed
chmod 755 configure.sed
./configure.sed BINDIR="$(CURDIR)/debian/tmp/scid/usr/games" \

G.

Bug#831792: RFS: scid/1:4.6.2-0.1 [NMU]

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo


>I am looking for a sponsor for my package "scid":


lets see.
1)

The package will be probably orphaned in 10-15 days, so you might want to set 
yourself
as Maintainer and adopt it

2)
+* Copyright (C) 2013-2015  Fulvio Benini


maybe you want also to put copyright file in machine readable format
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

3) 
X: scid source: maybe-not-arch-all-binnmuable scid -> scid-data

4) the breaks+replaces can be dropped, since that version is already available 
in oldstable

Breaks: scid (<=1:4.3.0.cvs20110714-2)
Replaces: scid (<=1:4.3.0.cvs20110714-2)
Recommends: scid (>=1:4.3.0.cvs20111216-1)


please fix the above and I'll give another review/upload.

thanks,

G.

Bug#831792: RFS: scid/1:4.6.2-0.1 [NMU]

[Jose G. López]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "scid":

* Package name: scid
  Version : 4.6.2-0.1 
  Upstream Author : Fulvio Benini 
* URL : http://scid.sf.net
* License : GPL v2
  Section : games

It builds those binary packages:

  scid - chess database with play and training functionality
  scid-data  - data files for scid, the chess database application

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/scid

Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/s/scid/scid_4.6.2-0.1.dsc

As advised by Gianfranco I've upload the package to mentors. It closes some 
other bugs not reproducible by the current version and is lintian clean (hope 
so :-)).

Package development is on the following repo:

https://gitlab.com/deb-pkg/scid

Changes since the last upload:

  * Non-maintainer upload.
  * New upstream version. (Closes: #802196)
  * UCI engine settings works and doesn't show 
errors. (Closes: #801607)
  * Game list can be resized and changes total width of the 
window (Closes: #692300)
  * debian/control:
- Bump to Standards-Version 3.9.8. No changes required.
- Use tcl and tk default version provided by Debian.
- Add libsnack2 (enabling sound) and tclsh to Depends on 
  scid-data package.
  * debian/rules:
- Link with '--as-needed' to fix FTBFS. (Closes: #772432) 
  Thanks to Logan Rosen for patch.
- Add hardening flags.
- Fix executable permissions on some files.
  * debian/patches:
- tcl_syntax: Add to fix syntax for Tcl/Tk script.
- 01_datafolder.diff: Add to use a data dir variable.
- 01_soundfolder.diff: Change to use share dir variable.
- 01_Makefile.conf.diff: Change to use hardening/linking flags.
- 01_configure_tclsh.diff: Remove, tcl default version provides tclsh.
- 01_spellcorrection.diff: Remove, source file deleted by upstream.
  * debian/scid.dirs: Remove scidlet dir, it is not used anymore.
  * debian/scid.install: Remove copying to scidlet dir.
  * debian/scid-data.dirs: Add tcl dir as upstream installs it by default
  * debian/scid-data.install: Copy files to tcl dir.

Regards,


pgpA2plKblaY5.pgp
Description: PGP signature