Bug#861011: RFS: qt5ct/0.31-2 [ITP]

[Tobias Frost]

Am Mittwoch, den 27.12.2017, 14:38 +0800 schrieb Paul Wise:
> On Wed, Dec 27, 2017 at 5:25 AM, Tobias Frost wrote:
> 
> > however, those are small problems, so I've uploaded it.
> 
> Please also see my review earlier in the RFS bug report.

Of course check also pabs list of points. (most of it has been
implemented though)

--
tobi

Bug#861011: RFS: qt5ct/0.31-2 [ITP]

[Paul Wise]

On Wed, Dec 27, 2017 at 5:25 AM, Tobias Frost wrote:

> - do not install AUTHORS. This information should be visible in
> d/copyright already.

The authors of a piece of software are not always the same as the
copyright holders of that software. There are various things that can
cause this, including employment law, employment contracts, commercial
copyright transfer, copyright donations etc. I would suggest
installing AUTHORS too, so the people who actually wrote the code also
get credit.

> however, those are small problems, so I've uploaded it.

Please also see my review earlier in the RFS bug report.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Bug#861011: RFS: qt5ct/0.31-2 [ITP]

[Tobias Frost]

Hi Mateusz,

a short review:

- do not install AUTHORS. This information should be visible in
d/copyright already.
- line 4 in d/copyright is redundant
- in the meantime, a new compat level and standard version .has been
released. (Something for the next upload)
- VCS-* repository in d/control is not working, but it is probably
anyway time to move it to salsa.debian.org...

however, those are small problems, so I've uploaded it.

Thanks for your contributions to Debian!


-- 
tobi

Bug#861011: RFS: qt5ct/0.31-2 [ITP]

[Paul Wise]

On Mon, Apr 24, 2017 at 12:41 AM, Mateusz Łukasik wrote:

> qt5ct - Qt5 Configuration Utility

Since Lisandro is a Debian member and a co-maintainer of the package,
will he be uploading this?

I don't intend to sponsor this package, but here is a quick review:

There do not appear to be any issues that block the upload to Debian.

These issues would be nice to fix at some point:

It is common to put the debian/ dir under the same license as upstream
instead of a different one. This is especially important for patches,
so that upstream can just include the patches directly without asking
you for a relicense.

Please get the manual page included upstream if it isn't already.

Please get the patch included upstream if it isn't already.

Please set some more DEP-3 headers, especially Forwarded:

http://dep.debian.net/deps/dep3/

The watch file can be shortened by using @ARCHIVE_EXT@

You could eliminate README.Debian if you do this:

Alternatively, create the file /etc/X11/Xsession.d/100-qt5ct with
the following line:

export QT_QPA_PLATFORMTHEME=qt5ct

Please run this command so that diffs of debian/ are easier to read:

wrap-and-sort --short-indent --wrap-always --sort-binary-packages
--trailing-comma

The Priority field should be optional rather than extra.

Transifex is no longer a Free Software service, it would be nice if
upstream could switch to something else.

https://mako.cc/writing/hill-free_tools.html

utils/update_ts.sh should probably run lupdate from $PATH instead of /opt

Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata

Automated checks:

build

Project MESSAGE: This project is using private headers and will
therefore be tied to this specific Qt module build version.
Project MESSAGE: Running this project against other versions of the Qt
modules may crash at any arbitrary point.
Project MESSAGE: This is not a bug, but a result of using Qt
internals. You have been warned!

dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/qt5ct/usr/lib/x86_64-linux-gnu/qt5/plugins/platformthemes/libqt5ct.so
was not linked against libX11.so.6 (it uses none of the library's
symbols)


lintian

P: qt5ct source: debian-watch-may-check-gpg-signature

check-all-the-things

# is a good idea, people who have different style
# preferences will want to ignore some of the output.
# Do not bother adding non-upstreamable patches for this.
$ find . -type f \( -iname '*.sh' -o -iname '*.bash' \) -exec bashate
--ignore E002,E003 {} +
E010: Do not on same line as for: 'for tr_dir in `find ../src/ -type d
-name "translations"`'
 - ./utils/update_tx.sh : L10
E010: Do not on same line as for: 'for RESOURCE_NAME in qt5ct'
 - ./utils/update_tx.sh : L29
E010: Do not on same line as for: 'for tr_dir in `find ../src/ -type d
-name "translations"`'
 - ./utils/update_ts.sh : L7
E010: Do not on same line as for: ' for code in $LOCALES'
 - ./utils/update_ts.sh : L17
E010: Do not on same line as for: ' for qm_file in $qm_files'
 - ./utils/update_ts.sh : L34
5 bashate error(s) found

$ env PERL5OPT=-m-lib=. cme check dpkg
...
Warning in 'copyright Format' value
'http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/':
Format uses insecure http protocol instead of https
...

$ codespell --quiet-level=3
./ChangeLog.svn:553: inital  ==> initial

$ env PERL5OPT=-m-lib=. duck
I: debian/copyright:3: URL:
http://downloads.sourceforge.net/project/qt5ct: INFORMATION
(Certainty:possible)
   URL schema changed from HTTP to HTTPS during redirect(s):
http://downloads.sourceforge.net -> https://sourceforge.net
   Please investigate and update the URL eventually, to avoid
unneccesary redirects!

$ fdupes -q -r . | grep -vE
'/(\.(git|svn|bzr|hg|sgdrawer|pc)|_(darcs|FOSSIL_)|CVS)(/|$)' | cat -s
./src/qt5ct/translations/qt5ct_pt_BR.ts
./src/qt5ct/translations/qt5ct_pt.ts

$ grep -nHEr '/(home|srv|opt)(\W|$)' .
./utils/update_ts.sh:27: /opt/qt56/bin/lupdate -no-obsolete
-silent -extensions "cpp,ui" ${tr_dir}/../ -ts ${ts_files}

$ flawfinder -Q -c .


# check if these can be switched to https://
$ grep -nHrF http: .
./README:42:http://doc.qt.io/qt-5/qloggingcategory.html (paragraph
"Configuring Categories")
./debian/watch:2:http://sf.net/qt5ct/qt5ct-(\d\S*)\.(?:zip|tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz)))
./debian/copyright:1:Format:
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
./debian/copyright:3:Source: http://downloads.sourceforge.net/project/qt5ct
./debian/copyright:46: along with this program. If not, see


$ find . -type f \( -iname '*.sh' -o -iname '*.bash' -o -iname '*.zsh'
\) -exec shellcheck {} +


$ find . -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname
.svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o
-iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o
-iname .metadata -o -iname CMakeFiles -o -iname _build -o -iname
_sgbak -o -iname autom4te.cache -o -iname blib -o -iname 

Bug#861011: RFS: qt5ct/0.31-2 [ITP]

[Mateusz Łukasik]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

  I am looking for a sponsor for my package "qt5ct"

 * Package name: qt5ct
   Version : 0.31-2
   Upstream Author : Ilya Kotov 
 * URL : http://downloads.sourceforge.net/project/qt5ct
 * License : BSD-2-clause
   Section : utils

  It builds those binary packages:

qt5ct - Qt5 Configuration Utility

  To access further information about this package, please visit the 
following URL:


  https://mentors.debian.net/package/qt5ct


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/q/qt5ct/qt5ct_0.31-2.dsc



  Changes since the last upload:

  This is initial upload to Debian.


  Regards,
   Mateusz Łukasik