Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Yangfl]

2018-03-01 4:37 GMT+08:00 Tobias Frost :
> Hi Yangfl,
>
> the package has now been accepted.
> However, I noticed that it targets "experimental", something I missed
> in the last review. Can you prepare another upload for unstable?
>
> And please tag the release on salsa! TIA!
>
> --
> tobi

Uploaded to https://salsa.debian.org/pkg-deepin-team/granite . Thanks
for your reminder.

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Tobias Frost]

Hi Yangfl,

the package has now been accepted.
However, I noticed that it targets "experimental", something I missed
in the last review. Can you prepare another upload for unstable?

And please tag the release on salsa! TIA!

--
tobi

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Tobias Frost]

Am 28. Februar 2018 05:53:31 MEZ schrieb Yangfl :
>2018-02-28 2:30 GMT+08:00 Tobias Frost :
>> Homework:
>> - please manually remove the package from mentors. (as it has to pass
>NEW)
>
>IIRC the package will be auto-removed, isn't it?

After being accepted, yes. But until then it will show up on the list of 
packages needing sponsoring. To avoid that someone looks at it and waste time 
on it, simply manually delete it.

>> Future uploads:
>> - please add a dep3 header to the patch.
>> - there are tons of depereciation warnings in the upstream code..
>please ask upstream or work towards fixing them...
>
>I can't see anything like 'deprecate' from cmake log. Did I miss
>something?

Not cmake.
Iirc gtk depreciation messages in the build log.

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Yangfl]

2018-02-28 2:30 GMT+08:00 Tobias Frost :
> Homework:
> - please manually remove the package from mentors. (as it has to pass NEW)

IIRC the package will be auto-removed, isn't it?

> Future uploads:
> - please add a dep3 header to the patch.
> - there are tons of depereciation warnings in the upstream code.. please ask 
> upstream or work towards fixing them...

I can't see anything like 'deprecate' from cmake log. Did I miss something?

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Yangfl]

I (should have already) fixed them all. Will soon upload to mentors.d.o

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Tobias Frost]

On Tue, Feb 06, 2018 at 11:31:16PM +0800, Yangfl wrote:
> 2018-02-03 20:12 GMT+08:00 Tobias Frost :
> 
> > - d/changelog:
> >   As this is not an ITP (where no history is available), re-introduction
> >   has a history and you need to continue writing it. In other words:
> >   Please document the changes you have made to the packaging since the
> >   last upload to Debian.
> 
> I did include the old changelogs. Did I fat-fingered?

Yes, you've included the old changelogs, but you did not document the
changes you have made to the packaging based on version 0.3.0-2~experimental1.

(So you'll need to document also the changes you've made based on my review...)

Pleae fix that :)
 
> > - d/control:
> >   The versions of the B-D on gobject-introspection, valac and libgtk-3-dev
> >   can be dropped, as even oldstable has it.
> 
> OK.
> 
> > - d/copyright
> >   cmake/ParseArguments.cmake -> I cannot see why this is BSD-2?
> >   Please expand :) If my point is true:
> >   Do we need to remove this file because of unknown license?
> 
> CC-BY-2.5 as shown in wiki.

Ok, however it is a bit awkward* if the license is only specified on some
website. Please work toward get this file removed and replaced by stock
CMake's one.
There is no indication in the file or on the website about the copyright
years.

* It does a bit consitute the "Tentacles of Evil" problem, as websites
can change at any time. So I really ask to to look into this even for this
release.

> 
> >   lib/Widgets/ModeButton.vala -> Copyright years are 2008-2013 for all
> >   copyrght holders.
> >
> >   lib/Services/ContractorProxy.vala -> Years wrong, file header says 
> > 2011-2013
> 
> These lines come from original debian/ provided by upstream. I believe
> they track their files better than me.

They might not proficient in writing copyright files or just made a mistake.
But we generally write d/copyright based on analysis on the content of the
individual files so you use the information in the header.

> > New stuff:
> > - There is now Boyuan Yang as 2nd uploader. Can you expand on you have
> > added him?
> 
> This package is packed as part of effort to introduce DDE into Debian
> (see 
> https://anonscm.debian.org/git/pkg-deepin/pkg-deepin.git/plain/depgraph/pkg-deepin-dep.svg
> ), thus it is co-maintained. And what do you mean by "expand on"?

I meant "Explain". But as long as Boyuan is consenting being uploader it is
of course ok for me. 

> > Misc:
> > - On salsa, I think you can delete the branch deb-packaging, can't you?
> 
> These are upstream's packaging scripts. I'd like to respect any
> (further) changes made by upstream.

You can still pull from upstream and cherry pick changes. However, as this
branch might create confusion on the Debian packaging repository, it would be
better to drop it. 

> > - cmake/ParseArguments.cmake --> The wiki page in the header of the file 
> > says
> >   this may be obsolete and quote: "If you are using CMake 2.8.3 or newer 
> > please
> >   use the CMakeParseArguments macro provided by the default CMake 
> > installation
> >   instead of the code below." Please file that upstream and try to patch
> >   the build so that the cmake file from cmake is used.
> 
> Yes, maybe an issue to upstream. Still it works even with it. Maybe I
> can ask them to remove it in the next release...
> 
> > Nothing to change, but hint for future packaging:
> > You d/copyright is more verbose that it needs to be: It is perfectly
> > fine to combine Files: sections sharing the same license, even if
> > the authors / copyright years are not always the same.
> >
> > This will ease work for people reviewing
> >
> > Hard to explain by words, so a virtual example:
> >
> > Files: *
> > Copyright: 2015,2018 AuthorA 
> > License: GPL
> >
> > Files: B
> > Copyright: 2017,2018 AuthorB 
> > License: GPL
> >
> > Files: C
> > Copyright: 2016,2017 AuthorA 
> >2016,2017 AuthorB 
> > License: GPL
> >
> > can be simply written as:
> >
> > Files: *
> > Copyright: 2015,2016-2018  AuthorA 
> >2017-2018  AuthorB  > License: GPL
> 
> The original copyright did exactly this way combining everything into
> a single *. I think a verbose copyright won't harm. Of course other
> uploaders can have different opinions. But just keep it untouched...

It will make it harder to review this way, but if you like to keep it,
keep it.

> The package has re-uploaded to mentors.d.o
> 
> Thanks for your suggestions and help.

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Yangfl]

2018-02-03 20:12 GMT+08:00 Tobias Frost :

> - d/changelog:
>   As this is not an ITP (where no history is available), re-introduction
>   has a history and you need to continue writing it. In other words:
>   Please document the changes you have made to the packaging since the
>   last upload to Debian.

I did include the old changelogs. Did I fat-fingered?

> - d/control:
>   The versions of the B-D on gobject-introspection, valac and libgtk-3-dev
>   can be dropped, as even oldstable has it.

OK.

> - d/copyright
>   cmake/ParseArguments.cmake -> I cannot see why this is BSD-2?
>   Please expand :) If my point is true:
>   Do we need to remove this file because of unknown license?

CC-BY-2.5 as shown in wiki.

>   lib/Widgets/ModeButton.vala -> Copyright years are 2008-2013 for all
>   copyrght holders.
>
>   lib/Services/ContractorProxy.vala -> Years wrong, file header says 2011-2013

These lines come from original debian/ provided by upstream. I believe
they track their files better than me.

> New stuff:
> - There is now Boyuan Yang as 2nd uploader. Can you expand on you have
> added him?

This package is packed as part of effort to introduce DDE into Debian
(see 
https://anonscm.debian.org/git/pkg-deepin/pkg-deepin.git/plain/depgraph/pkg-deepin-dep.svg
), thus it is co-maintained. And what do you mean by "expand on"?

> Misc:
> - On salsa, I think you can delete the branch deb-packaging, can't you?

These are upstream's packaging scripts. I'd like to respect any
(further) changes made by upstream.

> - cmake/ParseArguments.cmake --> The wiki page in the header of the file says
>   this may be obsolete and quote: "If you are using CMake 2.8.3 or newer 
> please
>   use the CMakeParseArguments macro provided by the default CMake installation
>   instead of the code below." Please file that upstream and try to patch
>   the build so that the cmake file from cmake is used.

Yes, maybe an issue to upstream. Still it works even with it. Maybe I
can ask them to remove it in the next release...

> Nothing to change, but hint for future packaging:
> You d/copyright is more verbose that it needs to be: It is perfectly
> fine to combine Files: sections sharing the same license, even if
> the authors / copyright years are not always the same.
>
> This will ease work for people reviewing
>
> Hard to explain by words, so a virtual example:
>
> Files: *
> Copyright: 2015,2018 AuthorA 
> License: GPL
>
> Files: B
> Copyright: 2017,2018 AuthorB 
> License: GPL
>
> Files: C
> Copyright: 2016,2017 AuthorA 
>2016,2017 AuthorB 
> License: GPL
>
> can be simply written as:
>
> Files: *
> Copyright: 2015,2016-2018  AuthorA 
>2017-2018  AuthorB  License: GPL

The original copyright did exactly this way combining everything into
a single *. I think a verbose copyright won't harm. Of course other
uploaders can have different opinions. But just keep it untouched...

The package has re-uploaded to mentors.d.o

Thanks for your suggestions and help.

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Tobias Frost]

Hi,

thanks for providing an updated package.

However, I'm sorry that I have misses a few bits before:

- d/changelog:
  As this is not an ITP (where no history is available), re-introduction
  has a history and you need to continue writing it. In other words:
  Please document the changes you have made to the packaging since the
  last upload to Debian.

- d/control:
  The versions of the B-D on gobject-introspection, valac and libgtk-3-dev
  can be dropped, as even oldstable has it.

- d/copyright
  cmake/ParseArguments.cmake -> I cannot see why this is BSD-2?
  Please expand :) If my point is true:
  Do we need to remove this file because of unknown license?

  lib/Widgets/ModeButton.vala -> Copyright years are 2008-2013 for all
  copyrght holders.

  lib/Services/ContractorProxy.vala -> Years wrong, file header says 2011-2013

New stuff:
- There is now Boyuan Yang as 2nd uploader. Can you expand on you have
added him?

Misc:
- On salsa, I think you can delete the branch deb-packaging, can't you?

- cmake/ParseArguments.cmake --> The wiki page in the header of the file says
  this may be obsolete and quote: "If you are using CMake 2.8.3 or newer please
  use the CMakeParseArguments macro provided by the default CMake installation
  instead of the code below." Please file that upstream and try to patch
  the build so that the cmake file from cmake is used.

Nothing to change, but hint for future packaging:
You d/copyright is more verbose that it needs to be: It is perfectly
fine to combine Files: sections sharing the same license, even if
the authors / copyright years are not always the same.

This will ease work for people reviewing

Hard to explain by words, so a virtual example:

Files: *
Copyright: 2015,2018 AuthorA 
License: GPL

Files: B
Copyright: 2017,2018 AuthorB 
License: GPL

Files: C
Copyright: 2016,2017 AuthorA 
   2016,2017 AuthorB 
License: GPL

can be simply written as:

Files: *
Copyright: 2015,2016-2018  AuthorA 
   2017-2018  AuthorB 

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Yangfl]

Control: tags -1 - moreinfo


2018年1月23日 上午2:17，"Jeremy Bicha" 写道：

Yangfl,

Maybe you didn't see the recent comments Tobias posted on
https://bugs.debian.org/873094

Thanks,
Jeremy Bicha


Hi,

Sorry for not getting your mail. I've updated and uploaded new version.

Looking for your review.

Sincerely,

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Jeremy Bicha]

Yangfl,

Maybe you didn't see the recent comments Tobias posted on
https://bugs.debian.org/873094

Thanks,
Jeremy Bicha

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Tobias Frost]

Control: tags -1 moreinfo
Control: owner -1 !

Hi,

bug-triaging on sponsorship-requests brought me to your package, so
here's a review:

- In the meantime version 0.5 has been released. Would be great if you
could update the pakage to the latest version, (I will sponsor it then)

- please bump d/compat to 11, if possible, and also update S-V to the
current one.
- those two lines can go (we never had them in unstable)
Replaces: libgranite0 (>> 0.2~)
Conflicts: libgranite0 (>> 0.2~)

- check-all-the-things gives some additinal hints.
Not all of them are probably worth a change, but please evaluate them.

'cmake (>= 2.8)': unnecessary greater-than versioned dependency: cmake 
(>= 2.8). 

The Recommmends on apport-hooks-elementary and contractor: There is not
such a package.
Warning in 'control binary:"libgranite-dev" Depends:0' value 'gir1.2-
granite-1.0 (= ${binary:Version})': package gir1.2-granite-1.0 is
unknown. Check for typos if not a virtual package.
 
$ env PERL5OPT=-m-lib=. duck
E: debian/copyright:67: Email: victoredua...@gmal.com: ERROR
(Certainty:possible)
   victoredua...@gmal.com: No MX entry found.
   victoredua...@gmal.com: No A entry found.
   victoredua...@gmal.com: No  entry found.

I: debian/copyright:192: URL: http://www.gnu.org/licenses/: INFORMATION
(Certainty:possible)
   The web page at http://www.gnu.org/licenses/ works, but is also
available via https://www.gnu.org/licenses/, please consider switching
to HTTPS urls.

I: debian/copyright:210: URL: http://www.gnu.org/licenses/: INFORMATION
(Certainty:possible)
   The web page at http://www.gnu.org/licenses/ works, but is also
available via https://www.gnu.org/licenses/, please consider switching
to HTTPS urls.

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[yang]

Hi,
Thank very much for your interest. I've fixed them.

2017-09-20 4:46 GMT+08:00 Jeremy Bicha :
> debian/control:
> - Please remove or update the Vcs fields
> - Please drop the Pre-Depends lines
> - Maybe https://github.com/elementary/granite is a better homepage?
>
> debian/rules:
> - Please drop the dh_builddeb rule. xz is already the default
> - Please use c4 for the makeshlibs rule
>
> debian/changelog:
> - I think it is appropriate to keep the old changelog entries since
> this package was only removed from Debian 6 months ago.
>
> debian/copyright:
> - Please update the Source line to point to github since that's where
> your watch file points
>
> Please use automatic debug packages. In particular, see the top
> section (before Summary) of
> https://wiki.debian.org/AutomaticDebugPackages
>
> Thanks,
> Jeremy Bicha

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[Jeremy Bicha]

debian/control:
- Please remove or update the Vcs fields
- Please drop the Pre-Depends lines
- Maybe https://github.com/elementary/granite is a better homepage?

debian/rules:
- Please drop the dh_builddeb rule. xz is already the default
- Please use c4 for the makeshlibs rule

debian/changelog:
- I think it is appropriate to keep the old changelog entries since
this package was only removed from Debian 6 months ago.

debian/copyright:
- Please update the Source line to point to github since that's where
your watch file points

Please use automatic debug packages. In particular, see the top
section (before Summary) of
https://wiki.debian.org/AutomaticDebugPackages

Thanks,
Jeremy Bicha

Bug#873094: RFS: granite/0.4.1-1 [ITP]

[yang]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "granite"

* Package name: granite
  Version : 0.4.1-1
 Upstream Author : elementary OS
* URL : https://launchpad.net/granite
* License : LGPLv3+
  Section : libs

It builds those binary packages:

gir1.2-granite-1.0 - extension of GTK+ libraries (introspection files)
granite-demo - extension of GTK+ libraries (demo binary)
libgranite-common - extension of GTK+ libraries (common files)
libgranite-dev - extension of GTK+ libraries (development files)
libgranite3 - extension of GTK+ libraries
libgranite3-dbg - extension of GTK+ libraries (debugging symbols)

To access further information about this package, please visit the
following URL:

 https://mentors.debian.net/package/granite


Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/g/granite/granite_0.4.1-1.dsc

More information about hello can be obtained from
https://github.com/elementary/granite .

Changes since the last upload:

 granite (0.4.1-1) unstable; urgency=medium

   * Initial release (Closes: #872919)


Regards,
 Yangfl