Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Hello again! :D On 2/21/06, Margarita Manterola [EMAIL PROTECTED] wrote: On 2/10/06, Zak B. Elep [EMAIL PROTECTED] wrote: As usual the source package can be found at mentors.debian.net .[1] [1] http://mentors.debian.net/debian/pool/main/x/xshisen/ Zak, I've been looking at the package. It looks quite good. And now, even better! :D I've just uploaded xshisen 1.51-1-2 to mentors at the same location above. The new package fixes the warnings you all mentioned, even changed the rules a bit so it builds right AND plays right (after the user installs it; I found that xshisen missed /usr/share/xshisen in the previous version, crashing the game.) Yeah, as Marga said, anyone uploading this package should build with `dpkg-buildpackage -v 1.51-1` on the maintainer upload. Thanks to all who responded! Hope to see this package soon in Sid! Cheers, Zakame -- Zak B. Elep || http://zakame.spunge.org [EMAIL PROTECTED] || [EMAIL PROTECTED] 1486 7957 454D E529 E4F1 F75E 5787 B1FD FA53 851D
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
On Tue, Feb 21, 2006 at 05:37:40PM +0800, Zak B. Elep wrote: Hello again! :D On 2/21/06, Margarita Manterola [EMAIL PROTECTED] wrote: On 2/10/06, Zak B. Elep [EMAIL PROTECTED] wrote: As usual the source package can be found at mentors.debian.net .[1] [1] http://mentors.debian.net/debian/pool/main/x/xshisen/ Zak, I've been looking at the package. It looks quite good. And now, even better! :D I've just uploaded xshisen 1.51-1-2 to mentors at the same location above. The new package fixes the warnings you all mentioned, even changed the rules a bit so it builds right AND plays right (after the user installs it; I found that xshisen missed /usr/share/xshisen in the previous version, crashing the game.) Programs don't crash! You should remove that file for testing, debug the non-program, and fix it to do something useful/print a message when the datafile isn't found. Justin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Hi Justin! On 2/21/06, Justin Pryzby [EMAIL PROTECTED] wrote: Programs don't crash! You should remove that file for testing, debug the non-program, and fix it to do something useful/print a message when the datafile isn't found. I did that before uploading, of course. Now xshisen should work fine. Unfortunately, I'm hitting a snag at #291279 (strange source package) which is most likely a misversioned NMU :/ Any hints at fixing this? :) At any rate, I've to celebrate; I got my first REJECTED mail from the archive installer thanks to trying to fix this package :P Cheers, Zakame -- Zak B. Elep || http://zakame.spunge.org [EMAIL PROTECTED] || [EMAIL PROTECTED] 1486 7957 454D E529 E4F1 F75E 5787 B1FD FA53 851D
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Zak B. Elep [EMAIL PROTECTED] wrote: Unfortunately, I'm hitting a snag at #291279 (strange source package) which is most likely a misversioned NMU :/ Any hints at fixing this? :) Why not just do your upload with a proper orig.tar.gz? At any rate, I've to celebrate; I got my first REJECTED mail from the archive installer thanks to trying to fix this package :P Why was it rejected? Regards, Frank -- Frank Küster Single Molecule Spectroscopy, Protein Folding @ Inst. f. Biochemie, Univ. Zürich Debian Developer (teTeX)
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
On Tue, Feb 21, 2006 at 10:15:35PM +0800, Zak B. Elep wrote: Hi Justin! On 2/21/06, Justin Pryzby [EMAIL PROTECTED] wrote: Programs don't crash! You should remove that file for testing, debug the non-program, and fix it to do something useful/print a message when the datafile isn't found. I did that before uploading, of course. Now xshisen should work fine. Really? Your response here: http://lists.debian.org/debian-mentors/2006/02/msg00275.html seems to indicate that you fixed the package not to crash by distributing the file. Of course the file should be distributed. But even if it isn't, the program should be written to not crash, hopefully in a graceful way (eg using errorx() rather than assert()). Unfortunately, I'm hitting a snag at #291279 (strange source package) which is most likely a misversioned NMU :/ Any hints at fixing this? It is my understanding that you can fix it by making sure that the next upload has these 3 files: .orig.tar.gz, .diff.gz, .dsc. Of course there will be at least one .deb too. afaik, dpkg-buildpackage will create a native package iff the .orig.tar.gz of the right name isn't found in ../. Just make sure is named correctly and that the changelog version is right. The relevant policy is: 5.6.12 Version | If there is no debian_revision then hyphens are not allowed; http://www.us.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version I wonder why this isn't (wasn't?) enforced.. At any rate, I've to celebrate; I got my first REJECTED mail from the archive installer thanks to trying to fix this package :P Rejected why? Justin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Hi Frank! :-) On 2/21/06, Frank Küster [EMAIL PROTECTED] wrote: Why not just do your upload with a proper orig.tar.gz? Yeah, I did that on mentors :) At any rate, I've to celebrate; I got my first REJECTED mail from the archive installer thanks to trying to fix this package :P Why was it rejected? Quoting the REJECTED mail: | Rejected: xshisen_1.51-1-2.dsc refers to xshisen_1.51-1.orig.tar.gz, | but I can't find it in the queue or in the pool. Hmmm, doesn't the maintainer to upload this to main needs to do a `debuild -sa` so that everything (.orig.tar.gz, .diff.gz, and .dsc) gets to be signed off in the .changes file? Cheers, Zakame -- Zak B. Elep || http://zakame.spunge.org [EMAIL PROTECTED] || [EMAIL PROTECTED] 1486 7957 454D E529 E4F1 F75E 5787 B1FD FA53 851D
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Hi again! :d On 2/21/06, Justin Pryzby [EMAIL PROTECTED] wrote: Really? Your response here: http://lists.debian.org/debian-mentors/2006/02/msg00275.html seems to indicate that you fixed the package not to crash by distributing the file. Of course the file should be distributed. But even if it isn't, the program should be written to not crash, hopefully in a graceful way (eg using errorx() rather than assert()). Heh, I didn't get my point clearly across. Sorry for the malaprop. ;) What I meant was that, during the building of the updated xshisen, I found that xshisen won't start because it can't find its pixmaps, since it looks for these in /usr/share/xshisen , when in fact I installed those in /usr/share/games/xshisen . Naturally I had to fix the debian/rules to correct this. No files were removed or not distributed in the resulting deb. At any rate, I've to celebrate; I got my first REJECTED mail from the archive installer thanks to trying to fix this package :P Rejected why? See my reply to Frank. Anyhow, no cause to worry about this anymore, since Margarita just reuploaded, and it got ACCEPTED! Cheers to Marga! :D Thanks to all who commented! Cheers, Zakame -- Zak B. Elep || http://zakame.spunge.org [EMAIL PROTECTED] || [EMAIL PROTECTED] 1486 7957 454D E529 E4F1 F75E 5787 B1FD FA53 851D
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Zak B. Elep [EMAIL PROTECTED] wrote: Why was it rejected? Quoting the REJECTED mail: | Rejected: xshisen_1.51-1-2.dsc refers to xshisen_1.51-1.orig.tar.gz, | but I can't find it in the queue or in the pool. Hmmm, doesn't the maintainer to upload this to main needs to do a `debuild -sa` so that everything (.orig.tar.gz, .diff.gz, and .dsc) gets to be signed off in the .changes file? Yes, that should have helped. Regards, Frank -- Frank Küster Single Molecule Spectroscopy, Protein Folding @ Inst. f. Biochemie, Univ. Zürich Debian Developer (teTeX)
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Zak B. Elep [EMAIL PROTECTED] wrote: Hi again! :d On 2/21/06, Justin Pryzby [EMAIL PROTECTED] wrote: Really? Your response here: http://lists.debian.org/debian-mentors/2006/02/msg00275.html seems to indicate that you fixed the package not to crash by distributing the file. Of course the file should be distributed. But even if it isn't, the program should be written to not crash, hopefully in a graceful way (eg using errorx() rather than assert()). Heh, I didn't get my point clearly across. Sorry for the malaprop. ;) What I meant was that, during the building of the updated xshisen, I found that xshisen won't start because it can't find its pixmaps, since it looks for these in /usr/share/xshisen , when in fact I installed those in /usr/share/games/xshisen . Naturally I had to fix the debian/rules to correct this. No files were removed or not distributed in the resulting deb. It's still unclear to me whether won't start means Tells the user it won't start without these files or rather Crashes. Regards, Frank -- Frank Küster Single Molecule Spectroscopy, Protein Folding @ Inst. f. Biochemie, Univ. Zürich Debian Developer (teTeX)
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
On 2/21/06, Frank Küster [EMAIL PROTECTED] wrote: It's still unclear to me whether won't start means Tells the user it won't start without these files or rather Crashes. The former, which ends with a `no such file or directory' for /usr/share/xshisen. Cheers, Zakame -- Zak B. Elep || http://zakame.spunge.org [EMAIL PROTECTED] || [EMAIL PROTECTED] 1486 7957 454D E529 E4F1 F75E 5787 B1FD FA53 851D
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
On Tue, Feb 21, 2006 at 11:42:00PM +0800, Zak B. Elep wrote:
Hi again! :d
On 2/21/06, Justin Pryzby [EMAIL PROTECTED] wrote:
Really? Your response here:
http://lists.debian.org/debian-mentors/2006/02/msg00275.html
seems to indicate that you fixed the package not to crash by
distributing the file. Of course the file should be distributed. But
even if it isn't, the program should be written to not crash,
hopefully in a graceful way (eg using errorx() rather than assert()).
Heh, I didn't get my point clearly across. Sorry for the malaprop. ;)
What I meant was that, during the building of the updated xshisen, I
found that xshisen won't start because it can't find its pixmaps,
since it looks for these in /usr/share/xshisen , when in fact I
installed those in /usr/share/games/xshisen . Naturally I had to fix
the debian/rules to correct this. No files were removed or not
distributed in the resulting deb.
A program has to be internally consistent, and it isn't allowed to
make assumptions like if I fopen this pathname, it is guaranteed to
exist and be readable.
You should {,re}move that file, for a test, and, if the program
crashes, you should fix it to do something more useful.
Justin
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
On 2/10/06, Zak B. Elep [EMAIL PROTECTED] wrote: As usual the source package can be found at mentors.debian.net .[1] [1] http://mentors.debian.net/debian/pool/main/x/xshisen/ Zak, I've been looking at the package. It looks quite good. However, I found that at the changelog you close many bugs, acknowledging the NMUs. This is what the Developer's Reference says, but it has actually been reported as a bug, by Jeroen [1]. So, you might want to drop that and ask your future sponsor to please build the package with the -vversion option. [1]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=353447 Also, I got all these lintian errors: W: xshisen: manpage-has-errors-from-man usr/share/man/man6/xshisen.6.gz 140: a space character is not allowed in an escape name W: xshisen: manpage-has-errors-from-man usr/share/man/ja/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot adjust line W: xshisen: manpage-has-errors-from-man usr/share/man/ja_JP/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot adjust line W: xshisen: manpage-has-errors-from-man usr/share/man/ja_JP.JIS7/man6/xshisen.6.gz conversion from `JIS7' is not supported W: xshisen: manpage-has-errors-from-man usr/share/man/ja_JP.PCK/man6/xshisen.6.gz conversion from `PCK' is not supported W: xshisen: manpage-has-errors-from-man usr/share/man/ja_JP.SJIS/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot adjust line W: xshisen: manpage-has-errors-from-man usr/share/man/ja_JP.eucJP/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot adjust line W: xshisen: manpage-has-errors-from-man usr/share/man/ja_JP.ujis/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot adjust line W: xshisen: unquoted-string-in-menu-item /usr/share/menu/xshisen needs:2 W: xshisen: unquoted-string-in-menu-item /usr/share/menu/xshisen section:2 The manpages might not be errors at all, since it's in japanese, and maybe lintian is not really so good at checking japanese manpages, but the others are real warnings: ?package(xshisen):needs=X11 section=Games/Board\ title=xshisen command=/usr/games/xshisen Should be: ?package(xshisen):needs=X11 section=Games/Board\ title=xshisen command=/usr/games/xshisen Also, when running linda against it, I got this other error: W: xshisen; Package version 1.51-2 is less than 1.51-1-1.3. Which looks kind of puzzling at the first moment, but after parsing the numbers, it's correct. 1.51-2 means: upstream 1.51 - debian 2 1.51-1-1.3 means: upstream 1.51-1 - debian 1.3 So, even if the debian part is greater, the upstream part is smaller. I guess you'll have to keep the extra -1 until the next upstream release comes. -- Besos, Marga
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
On Mon, Feb 20, 2006 at 02:17:10PM -0300, Margarita Manterola wrote: On 2/10/06, Zak B. Elep [EMAIL PROTECTED] wrote: As usual the source package can be found at mentors.debian.net .[1] [1] http://mentors.debian.net/debian/pool/main/x/xshisen/ Zak, I've been looking at the package. It looks quite good. However, I found that at the changelog you close many bugs, acknowledging the NMUs. This is what the Developer's Reference says, but it has actually been reported as a bug, by Jeroen [1]. So, you might want to drop that and ask your future sponsor to please build the package with the -vversion option. [1]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=353447 Just to be clear, a single Ack NMU; closes: #n. is correct, where n is the bug number for the Here is the NMU interdiff I am about to upload bug. But Ack NMU: closes: #n, #m, ... is incorrect, where n, m, ... are bugs which are *themselves* closed (well, tagged fixed) by the NMU. Right? Justin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11
Hello, On Mon, Feb 20, 2006 at 02:17:10PM -0300, Margarita Manterola wrote: Also, I got all these lintian errors: W: xshisen: manpage-has-errors-from-man usr/share/man/man6/xshisen.6.gz 140: a space character is not allowed in an escape name This first warning is caused by a '\' not escaped. '\n' should be changed to '\\n' on line 140. (This is also the case in some of the .ja man pages.) W: xshisen: manpage-has-errors-from-man usr/share/man/ja/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot adjust line lintian don't know the encoding of the man page. This warning can be ignored. You can run man -Lja page in a japanese environment to check if there are some issues in the Japanese pages. I've noticed that the xshisen.6 page is distributed in a lot of encoding. I don't think this is necessary on Debian. Man should recode the page from /usr/share/man/ja to the user's charset. Kind Regards, -- Nekral -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
RFS: xshisen_1.51-2 --- Shisen-sho game for X11
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, I've finished repackaging xshisen-1.51 as a non-native Debian package, adopting from gadek earlier this month.[0] I have also acknowledged the NMUs done by HE, joeyh and skx; thanks a lot guys for the care! :D [0] http://lists.debian.org/debian-devel/2006/02/msg7.html Anyhow, here are the relevant details of this package, following womble's guidelines ;) Source: xshisen License: BSD-style Section: games Priority: optional Maintainer: Zak B. Elep [EMAIL PROTECTED] Build-Depends: autotools-dev, cdbs, debhelper (= 5), lesstif-dev, libx11-dev, libxmu-dev, libxpm-dev, libxt-dev, libxaw7-dev, xutils Standards-Version: 3.6.2 Description: Shisen-sho puzzle game for X11 XShisen is a puzzle game for X11. Similar to the famous Shang-hai, your objective is to remove all the pieces on the board. . This game allows you to use either original xshisen images, or - at your choice - images from kshisen. . Homepage: http://www.techfirm.co.jp/~masaoki/xshisen.html As usual the source package can be found at mentors.debian.net .[1] [1] http://mentors.debian.net/debian/pool/main/x/xshisen/ Constructive comments are very much welcome; uploads very much too. :P Cheers, Zakame - -- Zak B. Elep || http://zakame.spunge.org [EMAIL PROTECTED] || [EMAIL PROTECTED] 1486 7957 454D E529 E4F1 F75E 5787 B1FD FA53 851D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFD7La8V4ex/fpThR0RAlLGAKDHhK/GMpr7escTMbmFn9z7TtHEXwCfcJDa YOb94l81JXN6pJ3OvZ7rxls= =mBUM -END PGP SIGNATURE-
