Bug#1055448: RFS: libsilkit/4.0.37-1 [ITP] -- Simulation in the loop kit by Vector
Hi Tobi, sorry for the long wait. It took some time to fix all problems and synchronize efforts within Vector. Unfortunately, we do not have a plan for community contributions in the short/midterm. This might change in the future, we (the SIL Kit team) just cannot say when it will be happening. For now, we have made the decision to post pone our efforts to package SIL Kit within the Debian archive. Instead, we will shift development completely to the public Github repo and try to grow the community with the goal to accept patches in the future. Thanks again for the feedback and help. Let's hope we can revisit a SIL Kit request in the future. Cheers, Jan On Sun, 12 Nov 2023 11:17:36 +0100 Tobias Frost wrote: > Control: tags -1 moreinfo > > Hi Jan, > > Thanks for your RFS! > as you are listed as upstream contact, let me, as I always do, point you to > https://wiki.debian.org/UpstreamGuide > > As this is your first package your are maintaining, please also read > https://mentors.debian.net/intro-maintainers/ > > This part of the CONTRIBUTING.md concerns me: > We are sorry, but at the moment, we do not accept external contributions > until > wehave established a contribution process. We're working behind the scenes > to > get this ready in the future. Until then, we would kindly ask you to not > open pull > requests. > > This stanca is older than a year (Aug 2022), so when will this happen? > > Sorry to be blunt, but putting a DFSG license on a piece of software and > then saying we do not accept contributions, is (IMHO) not within the > spirit of the Open Source Community, even if it might on paper fullfil > the DFSG. > > This is also problematic for maintaining the package, as how should we, > as Debian, upstream patches, for example if you are go missing for > whatever reasons? Effectively, we would need to maintain a fork, and > that is certainly nothing Vector could want. > > I'd say this brings the RFS very close to the "wontfix" territory, > certainly I will not sponsor this upload, but other sponsors might. > (The review below is partial, done until I saw the README.) > > In Debian we do not package every software. So maybe I'll need a salse > pitch here: > - Why does Vector want it in the Debian archives? > - Why would Debian want it to be in the Debian archives? > - Are there other projects using the library that you intend to package > for Debian? > > On Mon, Nov 06, 2023 at 12:57:23PM +, > =?UTF-8?Q?Kr=C3=a4...@buxtehude.debian.org wrote: > > > * Package name : libsilkit > > Version: 4.0.37-1 > > Upstream contact : jan.krae...@vector.com > > * URL : https://github.com/vectorgrp/sil-kit > > * License : MIT > > * Vcs : https://github.com/vectorgrp/sil-kit > >Section: libs > > > > The source builds the following binary packages: > > > > libsilkit-dev - Development packages for libsilkit > > libsilkit4 - Simulation in the loop kit by Vector > > > > To access further information about this package, please visit the > > following URL: > > > > https://mentors.debian.net/package/libsilkit/ > > > > Alternatively, you can download the package with 'dget' using this command: > > dget -x > > https://mentors.debian.net/debian/pool/main/libs/libsilkit/libsilkit_4.0.37-1.dsc > > > > > > Changes for the initial release: > > libsilkit (4.0.37-1) unstable; urgency=medium > > . > >* Reworked the documentation on Virtual Time Synchronization > >* The documentation of the demo section now refers to the pre built > > Vector > > SIL Kit packages and not to a source build. > > > > An ITP bug for the wnpp package can be found here: > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055064 > > Here's a short review on your package: As the build fails, it is likely > to be incomplete. > > - d/changelog: An initial upload has no changes, so it would just say > "Initial upload. Closes: #your-itp-bug." > > (As there is a lots of history in d/changelog: This file is not the > upstream changelog, is about recording changes to the packaging.) > > However, as said, your only entry for the initial upload is as I > described above, delete the rest. > - d/control: > - cmake >= 3.20 is aready fulfiled in stable, you can drop the > versioned part. > - you have a -dev package and a library package - good! > However, I see that you are installing a systemd service file, that > means you also need a non-library binary package so that multi-arch > will work. (something like a -tools package > - manpage: It says it is autogenerated, so you need to generate it > during build. As you are upstream, include the manpages upstream, so > other distributions will benefit too. > > - src/ThirdPArty (most of the directories are empty, possibly
Bug#1055448: RFS: libsilkit/4.0.37-1 [ITP] -- Simulation in the loop kit by Vector
On Tue, Nov 14, 2023 at 07:45:36AM +, Krämer, Jan wrote: > Hi Tobias, > > I still have some questions: > > - Is it permitted to update the libsilkit version (to 4.0.39) within the > review process? Yes, you can update to a later version. (if you do so, just upload it to mentors.d.n and then retitle this RFS bug to reflect the new version.) > - The only remaining vendoring is GoogleTest, which is only used for > the unit/integration tests which are not shipped by the package. Is > this allowed or should we use the systems libraries here as well? It's packaged, so the packaged version should be used. > - Related, if this is allowed, do we need to include the License > information, since we do not ship source files nor object files > compiled with these source files in the binary package? My understanding is that your d/copyright needs to reflect *everything* you ship in your orig.tar. > Cheers and thanks again for the review, > Jan Cheers, -- tobi
Bug#1055448: RFS: libsilkit/4.0.37-1 [ITP] -- Simulation in the loop kit by Vector
Hi Tobias, Thank you for the quick review. I will try to provide some quick feedback/acknowledgement as well below. On Sun, 12 Nov 2023 11:17:36 +0100 Tobias Frost wrote: > Control: tags -1 moreinfo > > Hi Jan, > > Thanks for your RFS! > as you are listed as upstream contact, let me, as I always do, point you to > https://wiki.debian.org/UpstreamGuide > > As this is your first package your are maintaining, please also read > https://mentors.debian.net/intro-maintainers/ > > This part of the CONTRIBUTING.md concerns me: > We are sorry, but at the moment, we do not accept external contributions >until > wehave established a contribution process. We're working behind the scenes >to > get this ready in the future. Until then, we would kindly ask you to not >open pull > requests. > > This stanca is older than a year (Aug 2022), so when will this happen? > > Sorry to be blunt, but putting a DFSG license on a piece of software and > then saying we do not accept contributions, is (IMHO) not within the > spirit of the Open Source Community, even if it might on paper fullfil > the DFSG. > > This is also problematic for maintaining the package, as how should we, > as Debian, upstream patches, for example if you are go missing for > whatever reasons? Effectively, we would need to maintain a fork, and > that is certainly nothing Vector could want. > > I'd say this brings the RFS very close to the "wontfix" territory, > certainly I will not sponsor this upload, but other sponsors might. > (The review below is partial, done until I saw the README.) > Our team knows that this is not ideal from a community perspective and we are working towards a solution. I will try to get back to you ASAP on these points. > In Debian we do not package every software. So maybe I'll need a salse > pitch here: > - Why does Vector want it in the Debian archives? > - Why would Debian want it to be in the Debian archives? > - Are there other projects using the library that you intend to package > for Debian? > I will probably bundle this with the answer above since both deal with Vectors overall FOSS strategy. > On Mon, Nov 06, 2023 at 12:57:23PM +, > =?UTF-8?Q?Kr=C3=a4...@buxtehude.debian.org wrote: > > > * Package name : libsilkit > > Version : 4.0.37-1 > > Upstream contact : jan.krae...@vector.com > > * URL : https://github.com/vectorgrp/sil-kit > > * License : MIT > > * Vcs : https://github.com/vectorgrp/sil-kit > > Section : libs > > > > The source builds the following binary packages: > > > > libsilkit-dev - Development packages for libsilkit > > libsilkit4 - Simulation in the loop kit by Vector > > > > To access further information about this package, please visit the > > following URL: > > > > https://mentors.debian.net/package/libsilkit/ > > > > Alternatively, you can download the package with 'dget' using this command: For some reason the last part of your email is omitted from the quote, but it seems I missed quite some stuff. Thanks though for the feedback. I will work on a revised version now and update the bug report once it is uploaded. I still have some questions: - Is it permitted to update the libsilkit version (to 4.0.39) within the review process? - The only remaining vendoring is GoogleTest, which is only used for the unit/integration tests which are not shipped by the package. Is this allowed or should we use the systems libraries here as well? - Related, if this is allowed, do we need to include the License information, since we do not ship source files nor object files compiled with these source files in the binary package? Cheers and thanks again for the review, Jan
Bug#1055448: RFS: libsilkit/4.0.37-1 [ITP] -- Simulation in the loop kit by Vector
Control: tags -1 moreinfo Hi Jan, Thanks for your RFS! as you are listed as upstream contact, let me, as I always do, point you to https://wiki.debian.org/UpstreamGuide As this is your first package your are maintaining, please also read https://mentors.debian.net/intro-maintainers/ This part of the CONTRIBUTING.md concerns me: We are sorry, but at the moment, we do not accept external contributions until wehave established a contribution process. We're working behind the scenes to get this ready in the future. Until then, we would kindly ask you to not open pull requests. This stanca is older than a year (Aug 2022), so when will this happen? Sorry to be blunt, but putting a DFSG license on a piece of software and then saying we do not accept contributions, is (IMHO) not within the spirit of the Open Source Community, even if it might on paper fullfil the DFSG. This is also problematic for maintaining the package, as how should we, as Debian, upstream patches, for example if you are go missing for whatever reasons? Effectively, we would need to maintain a fork, and that is certainly nothing Vector could want. I'd say this brings the RFS very close to the "wontfix" territory, certainly I will not sponsor this upload, but other sponsors might. (The review below is partial, done until I saw the README.) In Debian we do not package every software. So maybe I'll need a salse pitch here: - Why does Vector want it in the Debian archives? - Why would Debian want it to be in the Debian archives? - Are there other projects using the library that you intend to package for Debian? On Mon, Nov 06, 2023 at 12:57:23PM +, =?UTF-8?Q?Kr=C3=a4...@buxtehude.debian.org wrote: > * Package name : libsilkit > Version : 4.0.37-1 > Upstream contact : jan.krae...@vector.com > * URL : https://github.com/vectorgrp/sil-kit > * License : MIT > * Vcs : https://github.com/vectorgrp/sil-kit > Section : libs > > The source builds the following binary packages: > > libsilkit-dev - Development packages for libsilkit > libsilkit4 - Simulation in the loop kit by Vector > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/libsilkit/ > > Alternatively, you can download the package with 'dget' using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/libs/libsilkit/libsilkit_4.0.37-1.dsc > > > Changes for the initial release: > libsilkit (4.0.37-1) unstable; urgency=medium > . > * Reworked the documentation on Virtual Time Synchronization > * The documentation of the demo section now refers to the pre built Vector > SIL Kit packages and not to a source build. > > An ITP bug for the wnpp package can be found here: > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055064 Here's a short review on your package: As the build fails, it is likely to be incomplete. - d/changelog: An initial upload has no changes, so it would just say "Initial upload. Closes: #your-itp-bug." (As there is a lots of history in d/changelog: This file is not the upstream changelog, is about recording changes to the packaging.) However, as said, your only entry for the initial upload is as I described above, delete the rest. - d/control: - cmake >= 3.20 is aready fulfiled in stable, you can drop the versioned part. - you have a -dev package and a library package - good! However, I see that you are installing a systemd service file, that means you also need a non-library binary package so that multi-arch will work. (something like a -tools package - manpage: It says it is autogenerated, so you need to generate it during build. As you are upstream, include the manpages upstream, so other distributions will benefit too. - src/ThirdPArty (most of the directories are empty, possibly this is the reason for the FTBFS) You cannot vendor libraries in Debian, you must use packaged versions. If it is not packaged, you have to package it. - It FTBFS in a clean pbuilder enviornment. (asio not found) Likely missing dependencies Checkout sbuilder or pbuilder to make sure to build in a clean enviornment. - d/copyright claims that *EVERY* file is Copyright: 2023 Vector Informatik GmbH despite ThirdParty/LICENSES.rst is contradicting it. The year is not correct either, I saw at least one file with the year 2022. Please review every file and record the copyright information appropiatly. I did not do a complete copyright review. - There is no watchfile - d/control VCS-* needs to point where the *packaging* resides, not to the upstream repo. see Policy for details. (Due to CONTRIBUTING.md any other location than salsa.d.o is IMHO inacceptable.) - Stopping here after seeing CONTRIBUTING.md. -- Cheers from Regensburg,
Bug#1055448: RFS: libsilkit/4.0.37-1 [ITP] -- Simulation in the loop kit by Vector
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "libsilkit": * Package name : libsilkit Version : 4.0.37-1 Upstream contact : jan.krae...@vector.com * URL : https://github.com/vectorgrp/sil-kit * License : MIT * Vcs : https://github.com/vectorgrp/sil-kit Section : libs The source builds the following binary packages: libsilkit-dev - Development packages for libsilkit libsilkit4 - Simulation in the loop kit by Vector To access further information about this package, please visit the following URL: https://mentors.debian.net/package/libsilkit/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/libs/libsilkit/libsilkit_4.0.37-1.dsc Changes for the initial release: libsilkit (4.0.37-1) unstable; urgency=medium . * Reworked the documentation on Virtual Time Synchronization * The documentation of the demo section now refers to the pre built Vector SIL Kit packages and not to a source build. An ITP bug for the wnpp package can be found here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055064 Regards, Jan Kraemer
