Your message dated Wed, 13 Jun 2012 21:04:07 +0200
with message-id <20120613190407.ga11...@rivendell.home.ouaza.com>
and subject line Re: New LedgerSMB Debian package, 1.3.18-1
has caused the Debian Bug report #677070,
regarding RFS: ledgersmb/1.3.18-1 -- Financial accounting and ERP program
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
677070: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677070
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "ledgersmb"
* Package name : ledgersmb
Version : 1.3.18-1
Upstream Author : The LedgerSMB Core Team
* URL : www.ledgersmb.org
* License : GPL-2+
Section : web
It builds those binary packages:
ledgersmb - Financial accounting and ERP program
To access further information about this package, please visit the
following URL:
http://mentors.debian.net/package/ledgersmb
Alternatively, one can download the package with dget using this
command:
dget -x
http://mentors.debian.net/debian/pool/main/l/ledgersmb/ledgersmb_1.3.18-1.dsc
Note that this upload will resolve bug # 676639; that issue was fixed
in upstream version 1.3.16.
More information about LedgerSMB can be obtained from
http://www.ledgersmb.org.
Changes since the last upload:
ledgersmb (1.3.18-1) unstable; urgency=low
* Changes to debian/patches/:
- Update 05_confdir.patch for the new cssdir configuration item.
- Update 10_httpdconf.patch for the new cssdir configuration item.
* Changes to debian/ledgersmb.postinst:
- Add code that creates the initial default set of css files from the
example files.
- Correct a typo in the similar code for /var/lib/ledgersmb/templates.
* Add the application css directory to the debian/ledgersmb.examples
file and remove it from the debian/ledgersmb.install file.
* Add code in ledgersmb.postrm to remove /var/lib/ledgersmb/css during
a package purge. (Like for /var/lib/ledgersmb/templates, which was
actually added with 1.3.17-1.)
* Removed the no longer needed references to libexcel-template-plus-perl
from debian/control and debian/README.Debian.
* Removed blib/man3/LedgerSMB::Template::XLS.3pm from
ledgersmb.manpages.
* Add the removal of empty example language specifc template directories
to debian/rules.
-- Robert James Clay <j...@rocasa.us> Sun, 10 Jun 2012 22:51:41 -0400
ledgersmb (1.3.17-1) unstable; urgency=low
* New upstream release.
* Add a note regarding libimage-size-perl to README.Debian.
* Changes to debian/patches/05_confdir.patch:
- Update the templates path to be /var/lib/ledgersmb/templates.
* No longer need to set ownership of /etc/ledgersmb/templates in
debian/rules.
* Add the application templates directory to the
debian/ledgersmb.examples file and remove it from the
debian/ledgersmb.install file.
* Changes to debian/control:
- Add libtemplate-plugin-latex-perl module to Recommends.
- Add the libexcel-template-plus-perl and libimage-size-perl modules
to Suggests.
* Add code in ledgersmb.postinst to create the initial default set of
templates from the example templates.
* Add code with debian/ledgersmb.preinst to, if it exists, move the
directory /etc/ledgersmb/templates to /var/lib/ledgersmb.
-- Robert James Clay <j...@rocasa.us> Sat, 02 Jun 2012 20:59:37 -0400
ledgersmb (1.3.16-1) unstable; urgency=low
* New upstream release.
* Resolves package ITP. (Closes: #406935)
* Update and rewrite debian/TODO and README.Debian.
* Update debian/NEWS, debian/templates and README.Debian regarding the
initial configuration of the package.
* Add update of PostgreSQL contrib_dir variable to
patches/05_confdir.patch.
-- Robert James Clay <j...@rocasa.us> Tue, 08 May 2012 07:55:30 -0400
Regards,
Robert James Clay
j...@rocasa.us
--- End Message ---
--- Begin Message ---
Hi,
On Mon, 11 Jun 2012, Robert James Clay wrote:
> I went ahead & submitted that Request for Sponsor bug because I
> didn't know how busy you might be at the moment. If you can take care
> it, though, I'd appreciate it as you're already more familiar with it
> than someone else might be.
Uploaded. Some comments for the next time:
1/ I would not install the "css" and "templates" directories as examples.
Because the postinst requires those files and this will break for
people who are using dpkg's --path-exclude to drop /usr/share/doc/ (to
save space). Put them in /usr/share/ledgersmb/. The "templates" symlink
there is not useful anyway since apparently you patch the configuration
to directly point to /var/lib/ledgersmb/templates. The same goes for
the css symlink since you configured apache to look directly into
/var/lib/ledgersmb/css/.
2/ I would not pollute the URL namespace with /lsmbcss. Why did you not
use /ledgersmb/css/. That way you could have kept the default value
for $cssdir. No ? (Somehow your TODO says that there are open problems
related to this)
3/ The preinst code moving /etc/ledgersmb/templates to /var/lib/ledgersmb/
should only be executed if we are upgrading from a version prior to
1.3.18-1 and if /var/lib/ledgersmb/templates/ doesn't exist yet.
4/ debian/templates contains a type "expermental" instead of
"experimental".
5/ Your TODO suggests to drop the UPGRADE file in favor of README.Debian.
In theory, it's nice but in practice it's probably best to keep it
around because you might forget to update the README.Debian and it's
generally interesting to be able to read upstream recommendations too
(after having read what the maintainer recommends in README.Debian).
> Note that this upload will resolve bug # 676639; that issue was fixed
> in upstream version 1.3.16.
You should have put a "Closes: #676639" in the changelog then... why
didn't you do that?
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/
--- End Message ---
