Bug#700233: Subject: RFS: libre-jigsaw/2012.09.09-1 [ITP]

[Jon Hulka]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package libre-jigsaw. As the name
implies, this is a jigsaw puzzle game. Currently there is nothing like it
in the Debian repositories, and I think it will be a good addition to
Debian games.

* Package name: libre-jigsaw
Version : 2012.09.09-1
Upstream Author : Jonathan Hulka jon.hu...@gmail.com
* URL : http://speedduck.net/games/jigsaw
* License : GPL (app) CC BY-SA (photos)
Section : games

It builds those binary packages:

libre-jigsaw - jigsaw puzzle
libre-jigsaw-pics - jigsaw puzzle (pictures)

To access further information about this package, please visit the
following URL:

http://mentors.debian.net/package/libre-jigsaw


Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/libr/libre-jigsaw/libre-jigsaw_2012.09.09-1.dsc

Changes since the last upload:

This is a new package.


Regards,
Jon Hulka

Bug#700233: Subject: RFS: libre-jigsaw/2012.09.09-1 [ITP]

[Paul Wise]

Here is a review:

You might want to join the games team, however we don't have many Java
folks in the team so you may also want to ask the Debian Java team for
sponsorship.

http://wiki.debian.org/Games/Team
http://wiki.debian.org/Teams/JavaPackaging

There is one game I always wanted in

Since you are upstream, please read these two pages:

http://wiki.debian.org/UpstreamGuide
http://www.freedesktop.org/wiki/Games/Upstream

Some of the links in the external advice section are about Java stuff,
you might want to look at those.

I'm interested to know which are you reasons for packaging your game
for Debian, are they any of these?

http://wiki.debian.org/AdvantagesForUpstream

No need for the comment in the watch file.

You made some of the mistakes listed here in your watch file:

http://wiki.debian.org/debian/watch#Common_mistakes

The watch file only finds 2012.03.04 instead of 2012.09.09, why is that?

Why do you run the java compiler and jar in override_dh_install? IMO
those should be run by the upstream build system at build time. In any
case they should not be run at install time.

Please include the manual page libre-jigsaw.6 upstream.

The upstream build system should install the build and install the
program, data and documentation. debian/rules and the debhelper
commands should just be a wrapper for that instead of doing the work.

The icon path in libre-jigsaw.menu is incorrect, you want
/usr/share/pixmaps/libre-jigsaw.xpm or similar.

debian/docs is empty and should be removed.

Since both packages are architecture all and one depends on the other,
there is no point splitting the package up into two as far as I can
tell, what is your reason for that?

Some of the files are not under the GPL but are instead under an
ambigous license that when read strictly, doesn't appear to allow
distribution, since use doesn't nessecarily include distribution.
Since you are the copyright holder, please change these to GPL or
another standard license. Some files don't include any copyright or
license grant, please add both to them.

If possible, I would suggest to render your icons and images from the
SVG source at build time. You can use rsvg or inkscape to render them.
For the thumbnails I would suggest resampling them with imagemagick at
build time.

The HTML files say they have been generated by Geany, which appears to
be an IDE. Is HTML the edited format or is there some other form?

Several of the images contains text. It would be better to render that
at runtime so that it can be translated into multiple languages.

Most of the images look like they were rendered from vector graphics,
but the SVG/etc files appear to be missing for most of them.

The name in debian/copyright for the nature photos should be John P
Sercel, see the bottom left of this page:

http://photos.jstechs.com/about.html#on_your_site

In the debian/copyright file you don't need the second stanza since it
is basically the same as the first one.

In debian/copyright, CC BY-SA should be CC-BY-SA:

http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification

Some automatic checks:

https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package

The SVG files leak information about where on your filesystem you
develop the game, it probably isn't very sensitive info, but I wonder
if you intended that.

javac:

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

lintian:

W: libre-jigsaw source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
P: libre-jigsaw: no-upstream-changelog
I: libre-jigsaw: possible-documentation-but-no-doc-base-registration
W: libre-jigsaw: executable-not-elf-or-script
usr/share/games/libre-jigsaw/libre-jigsaw.jar
P: libre-jigsaw-pics: no-upstream-changelog
I: libre-jigsaw-pics: possible-documentation-but-no-doc-base-registration

desktop-file-validate:

./application/libre-jigsaw.desktop: warning: value jigsaw puzzle for
key Comment in group Desktop Entry looks redundant with value
Jigsaw Puzzle of key GenericName
./application/libre-jigsaw.desktop: error: value Application;Game
for string list key Categories in group Desktop Entry does not
have a semicolon (';') as trailing character

fdupes:

./img_src/logo-big.svg
./icons/hicolor/scalable/apps/libre-jigsaw.svg

jlint produces a lot of warnings.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CAKTje6HhRox=4A_2ZgomJfHMvZROfqV_UYyp6c=oetq1ztx...@mail.gmail.com

Re: Bug#700233: Subject: RFS: libre-jigsaw/2012.09.09-1 [ITP]

[Dmitry Smirnov]

Hi Jon,

On Sun, 10 Feb 2013 22:10:08 Jon Hulka wrote:
 I am looking for a sponsor for my package libre-jigsaw. As the name
 implies, this is a jigsaw puzzle game. Currently there is nothing like it
 in the Debian repositories, and I think it will be a good addition to
 Debian games.

As I mentioned in 

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=660433#18

there are decent jigsaw puzzle games in Debian: palapeli, xjig and others.
I'm not that impressed with libre-jigsaw but the images are truly nice.

Perhaps the best would be to package images separately as a standalone source 
package to benefit other jigsaw puzzle games as well as any other use such as 
desktop backgrounds etc. In this case package description shall be neutral 
i.e. it doesn't have to mention libre-jigsaw.

The game packaging shall be improved. Paul already stressed the main points of 
importance but also you may consider

 * using javahelper.

 * to use up-to-date Standards (debian/control)

 * use xz compression for source and binaries.

 * tracking packaging in publicly accessible VCS.

By the way what's the point installing that many (14) icons to  
/usr/share/icons/hicolor? Is it really necessary?

Cheers,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

Good luck happens when preparedness meets opportunity.


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130257.09416.only...@member.fsf.org

Bug#700233: Subject: RFS: libre-jigsaw/2012.09.09-1 [ITP]

[Jon Hulka]

Thank you for giving such detailed feedback. I'll read through it carefully
over the next week, make the appropriate changes to the package and check
out the Java packaging team.

 I'm interested to know which are you reasons for packaging your game for
Debian, are they any of these?

I think most of those apply. I'm a Debian user and I believe in free
software, so I want to get involved in the project/community to some
degree. Packaging my own software seems like a good way to get started, the
learning curve isn't quite as steep. It also won't hurt to have my software
in front of a larger audience in Debian and eventually Ubuntu.

  Since both packages are architecture all and one depends on the other,
there is no point splitting the package up into two as far as I can tell,
what is your reason for that?

The images is a large package and not likely to need bug fixes. If I
release a new version of the application, it can depend on the older pics
package and lighten the bandwidth usage. The licenses are also different.

 Is HTML the edited format or is there some other form?

The HTML is original form. I don't think the generated by Geany message is
even necessary - I'll look into it.

Most of your other points are oversight or ignorance on my part. I will
change copyright to GPL for all of my code and address the other issues.

Thanks again,

 - Jon

On Sun, Feb 10, 2013 at 4:16 AM, Paul Wise p...@debian.org wrote:

 Here is a review:

 You might want to join the games team, however we don't have many Java
 folks in the team so you may also want to ask the Debian Java team for
 sponsorship.

 http://wiki.debian.org/Games/Team
 http://wiki.debian.org/Teams/JavaPackaging

 There is one game I always wanted in

 Since you are upstream, please read these two pages:

 http://wiki.debian.org/UpstreamGuide
 http://www.freedesktop.org/wiki/Games/Upstream

 Some of the links in the external advice section are about Java stuff,
 you might want to look at those.

 I'm interested to know which are you reasons for packaging your game
 for Debian, are they any of these?

 http://wiki.debian.org/AdvantagesForUpstream

 No need for the comment in the watch file.

 You made some of the mistakes listed here in your watch file:

 http://wiki.debian.org/debian/watch#Common_mistakes

 The watch file only finds 2012.03.04 instead of 2012.09.09, why is that?

 Why do you run the java compiler and jar in override_dh_install? IMO
 those should be run by the upstream build system at build time. In any
 case they should not be run at install time.

 Please include the manual page libre-jigsaw.6 upstream.

 The upstream build system should install the build and install the
 program, data and documentation. debian/rules and the debhelper
 commands should just be a wrapper for that instead of doing the work.

 The icon path in libre-jigsaw.menu is incorrect, you want
 /usr/share/pixmaps/libre-jigsaw.xpm or similar.

 debian/docs is empty and should be removed.

 Since both packages are architecture all and one depends on the other,
 there is no point splitting the package up into two as far as I can
 tell, what is your reason for that?

 Some of the files are not under the GPL but are instead under an
 ambigous license that when read strictly, doesn't appear to allow
 distribution, since use doesn't nessecarily include distribution.
 Since you are the copyright holder, please change these to GPL or
 another standard license. Some files don't include any copyright or
 license grant, please add both to them.

 If possible, I would suggest to render your icons and images from the
 SVG source at build time. You can use rsvg or inkscape to render them.
 For the thumbnails I would suggest resampling them with imagemagick at
 build time.

 The HTML files say they have been generated by Geany, which appears to
 be an IDE. Is HTML the edited format or is there some other form?

 Several of the images contains text. It would be better to render that
 at runtime so that it can be translated into multiple languages.

 Most of the images look like they were rendered from vector graphics,
 but the SVG/etc files appear to be missing for most of them.

 The name in debian/copyright for the nature photos should be John P
 Sercel, see the bottom left of this page:

 http://photos.jstechs.com/about.html#on_your_site

 In the debian/copyright file you don't need the second stanza since it
 is basically the same as the first one.

 In debian/copyright, CC BY-SA should be CC-BY-SA:


 http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification

 Some automatic checks:

 https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package

 The SVG files leak information about where on your filesystem you
 develop the game, it probably isn't very sensitive info, but I wonder
 if you intended that.

 javac:

 Note: Some input files use or override a deprecated API.
 Note: Recompile with -Xlint:deprecation for details.

 

Bug#700233: Subject: RFS: libre-jigsaw/2012.09.09-1 [ITP]

[Jon Hulka]

 there are decent jigsaw puzzle games in Debian: palapeli, xjig and
others.
 I'm not that impressed with libre-jigsaw but the images are truly nice.

I know I'm biased, but I didn't find these to be very playable.

 Perhaps the best would be to package images separately as a standalone
source
 package to benefit other jigsaw puzzle games as well as any other use
such as
 desktop backgrounds etc. In this case package description shall be neutral
 i.e. it doesn't have to mention libre-jigsaw.

 The game packaging shall be improved. Paul already stressed the main
points of
 importance but also you may consider

  * using javahelper.

  * to use up-to-date Standards (debian/control)

 * use xz compression for source and binaries.

 * tracking packaging in publicly accessible VCS.

Looks like I have my work cut out for me :-)

 By the way what's the point installing that many (14) icons to
 /usr/share/icons/hicolor? Is it really necessary?

Probably not - I'm learning.

Thanks,
 - Jon

Bug#700233: Subject: RFS: libre-jigsaw/2012.09.09-1 [ITP]

[Dmitry Smirnov]

On Mon, 11 Feb 2013 12:50:47 Jon Hulka wrote:
  there are decent jigsaw puzzle games in Debian: palapeli, xjig and
 
 others.
 
  I'm not that impressed with libre-jigsaw but the images are truly nice.
 
 I know I'm biased, but I didn't find these to be very playable.

Did you have a good look?

Clearly palapely is very playable because you can zoom-in/zoom-out, scroll  
and easily connect pieces together while in libre-jigsaw pieces are snapping 
together only after annoying precision-work.
Besides pieces are looking better in palepeli.

To appreciate xjig you need a little bit more patience: it is mostly 
controlled by command line and parhaps lacking some GUI to choose an image but 
it's gameplay is rich, unique and challenging because pieces can be flipped 
over as well as rotated.

I might be overly critical to libre-jigsaw but its interface do not appears 
very impressive to me...

 
  By the way what's the point installing that many (14) icons to
  /usr/share/icons/hicolor? Is it really necessary?
 
 Probably not - I'm learning.

Thank you for your effort. It is appreciated despite some criticism that you 
may feel. :)

Regards,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201302111310.35632.only...@member.fsf.org