Re: Bug#749213: RFS: qtop/2.2.3-2 [ITP]
Hi Andrew, Thank you for your review ! I haven't gotten a chance to look at this very deeply yet. No problem, it's already very nice to spare time to review this package ! :) I've also spoken with Axel (Beckert), and he signaled me other bugs. So, the quality of this package should be better now. A quick look suggests that the License filed in debian/copyright for the upstream files should be GPL-2+ instead of just GPL-2. I've updated d/copyright to change it. It also fails to build for me in a clean sid pbuilder: The build-dependencies were wrong. I had not tried to build the package with pbuilder ! Now, it builds fine. And finally, you seem to have renamed the binary but not the Exec field in the desktop file, so that will be broken. Added to name.patch. ;) So... I've made many changes, and, to make clearer, I've written a changelog: * d/rules: - Deleted all declarations that debhelper 8 needed which are useless with debhelper 9. * d/control: - Changed debhelper required version to 9.0.0. - Added new build-dependencies. * d/compat: - Using compatibility level 9. * d/qtop.1: - Deleted the paragraph about 'info qtop' which was useless. * d/patches/name.patch: - Added Top.desktop to the patch. * d/copyright: - Changed upstream license from GPL-2 to GPL-2+. Regards, Hugo -- Hugo Lefeuvre (hugo6390)|www.hugo6390.org 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E signature.asc Description: Digital signature
Bug#749213: RFS: qtop/2.2.3-2 [ITP]
On Tue, Jun 10, 2014 at 5:19 AM, Hugo Lefeuvre hugo6...@orange.fr wrote: Hi, I've spoken with the Upstream to find a good name. He have also made a new version of the software to allow other binary names (2.2.4). The final name of this package is qtop: I've also made an update, and, finally, the package seems ready to be uploaded. qtop appears to be Lintian errors/warnings clear and compiles fine on my computer. :) Hi Hugo, I haven't gotten a chance to look at this very deeply yet. A quick look suggests that the License filed in debian/copyright for the upstream files should be GPL-2+ instead of just GPL-2. It also fails to build for me in a clean sid pbuilder: -- debian/rules build dh build dh_testdir dh_auto_configure mkdir -p obj-x86_64-linux-gnu cd obj-x86_64-linux-gnu cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None -- The C compiler identification is GNU 4.8.3 -- The CXX compiler identification is GNU 4.8.3 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /usr/share/cmake-2.8/Modules/FindQt4.cmake:1386 (message): Found unsuitable Qt version from NOTFOUND, this code requires Qt 4.x Call Stack (most recent call first): base/CMakeLists.txt:17 (FIND_PACKAGE) -- Configuring incomplete, errors occurred! See also /tmp/buildd/qtop-2.2.4/obj-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log. dh_auto_configure: cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None returned exit code 1 debian/rules:11: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 And finally, you seem to have renamed the binary but not the Exec field in the desktop file, so that will be broken. Thanks for your work on Debian! -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cal6k_axj+u0z-sjq46itx7kmcxz9m3b4kbes5orrt3qn5v6...@mail.gmail.com
Bug#749213: RFS: qtop/2.2.3-2 [ITP]
Hi, I've spoken with the Upstream to find a good name. He have also made a new version of the software to allow other binary names (2.2.4). The final name of this package is qtop: I've also made an update, and, finally, the package seems ready to be uploaded. qtop appears to be Lintian errors/warnings clear and compiles fine on my computer. :) The package is available at the same adress.[0] Regards, Hugo [0] https://mentors.debian.net/package/qtop -- Hugo Lefeuvre (hugo6390)|www.hugo6390.org 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E signature.asc Description: Digital signature
Re: Bug#749213: RFS: qtop/2.2.3-2 [ITP]
Hi, I'm actually speaking with the Upstream to find a good name for this package. It will maybe change again. Regards, Hugo -- Hugo Lefeuvre (hugo6390)|www.hugo6390.org 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E signature.asc Description: Digital signature
Bug#749213: RFS: qtop/2.2.3-2 [ITP]
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package qtop Package name: qtop Version : 2.2.3-2 Upstream Author : Hugo Pereira Da Costa hugo.pere...@free.fr URL : http://hugo.pereira.free.fr/software/ License : GPL2 Programming lang: C++ / Qt5 Section : admin It builds this binary package: qtop - windowed version of the console top command To access further information about this package, please visit the following URL: http://mentors.debian.net/package/qtop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/q/qtop/qtop_2.2.3-2.dsc More information about top can be obtained from Hugo Pereira's website: http://hugo.pereira.free.fr/ I've already asked for a sponsorship, but the name of the package was buggy. I've also made a patch to change the name of the software from 'Top' to 'qtop'. qtop (2.2.3-2) unstable; urgency=low * debian/patches/name.patch: - Changes the name of the binary from Top to qtop. -- Hugo Lefeuvre hugo6...@orange.fr Sun, 25 May 2014 00:42:12 +0200 qtop (2.2.3-1) unstable; urgency=low * Initial release (Closes: #731881) -- Hugo Lefeuvre hugo6...@orange.fr Sun, 18 May 2014 17:23:10 +0200 Regards, Hugo -- Hugo Lefeuvre (hugo6390)|www.hugo6390.org 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E signature.asc Description: Digital signature
Bug#749213: RFS: qtop/2.2.3-2 [ITP]
On Sun, May 25, 2014 at 10:16 AM, Hugo Lefeuvre hugo6...@orange.fr wrote: I've already asked for a sponsorship, but the name of the package was buggy. I've also made a patch to change the name of the software from 'Top' to 'qtop'. qtop (2.2.3-2) unstable; urgency=low * debian/patches/name.patch: - Changes the name of the binary from Top to qtop. -- Hugo Lefeuvre hugo6...@orange.fr Sun, 25 May 2014 00:42:12 +0200 qtop (2.2.3-1) unstable; urgency=low * Initial release (Closes: #731881) -- Hugo Lefeuvre hugo6...@orange.fr Sun, 18 May 2014 17:23:10 +0200 Since the package has been never released, please remove the changelog entry for 2.2.3-2 and keep only the first with Initial release. -- regards, Mattia Rizzolo GPG Key: 4096R/B9444540 http://goo.gl/I8TMB more about me: http://mapreri.org Launchpad User: https://launchpad.net/~mapreri Ubuntu Wiki page: https://wiki.ubuntu.com/MattiaRizzolo -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cahkymet3gjkva+vpyfnnfaybhhualctwn+qtdvgcmfnb0cv...@mail.gmail.com
Bug#749213: RFS: qtop/2.2.3-2 [ITP]
Since the package has been never released, please remove the changelog entry for 2.2.3-2 and keep only the first with Initial release. I've corrected it. The new version is on mentors.debian.org at the same adress. [0] Regards, Hugo [0] https://mentors.debian.net/package/qtop -- Hugo Lefeuvre (hugo6390)|www.hugo6390.org 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E signature.asc Description: Digital signature
