Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Giulio Paci]

On 20/03/2016 22:37, Jakub Wilk wrote:
> * Giulio Paci , 2016-03-20, 03:05:
>>> I'm looking partly shocked at the commit
>>> 6fc1eec66c259cefeeb13453c3ceeb206fb24a55 why did you *substituted* the 
>>> pristine-tar data?  You should always just add them.
>>
>> This is just because upstream never tagged a version, nor released a package.
>> I imported one using 0.0.1 version, but later noticed that 1.0 was set in 
>> the source and so I renamed the package.
> 
> Um. If upstream didn't make a release, then you ask them to make one, instead 
> of declaring yourself that this random git snapshot will be called 1.0.
> 
> That the source says it's "1.0" is not very relevant, unless upstream bumps 
> version in every commit; and they don't.

You are right. I wrote an email to Brad asking for a release.

> Also, you probably want to fix your debian/watch. :)

This for sure. Although steelskin is an interesting project as well... ;-)

Thank you for these comments.

Bests,
Giulio

Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Jakub Wilk]

* Giulio Paci , 2016-03-20, 03:05:

I'm looking partly shocked at the commit
6fc1eec66c259cefeeb13453c3ceeb206fb24a55 why did you *substituted* the 
pristine-tar data?  You should always just add them.


This is just because upstream never tagged a version, nor released a package.
I imported one using 0.0.1 version, but later noticed that 1.0 was set 
in the source and so I renamed the package.


Um. If upstream didn't make a release, then you ask them to make one, 
instead of declaring yourself that this random git snapshot will be 
called 1.0.


That the source says it's "1.0" is not very relevant, unless upstream 
bumps version in every commit; and they don't.


Also, you probably want to fix your debian/watch. :)

--
Jakub Wilk

Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Giulio Paci]

Hi Mattia,
thank you for your review and for wishing to sponsor this package.

On 19/03/2016 13:37, Mattia Rizzolo wrote:
> control: tag -1 moreinfo
> control: owner -1 !
> 
> On Fri, Feb 05, 2016 at 03:04:19PM +0100, Giulio Paci wrote:
>>   I am looking for a sponsor for my package "msi-keyboard":
> 
> alright.
> 
>>   https://anonscm.debian.org/cgit/collab-maint/msi-keyboard.git
> 
> cool!  finally somebody coming here with a git repository!
> 
> though:
> * I see no tags, I expect to see at least the upstream/* tags (also
>   otherwise gbp can be noisy and annoying)

Added a tag.

> * the HEAD points to master; given that the packaging branch is
>   "debian", please configure the remote repository on collab-maint to
>   have HEAD point to "debian" instead, so that cloning the repository
>   gives you the packaging branch even without specifying it.

Fixed.

> * as said you are using a non-standard repository layout, so I expect
>   debian/gbp.conf to be explicitly configured to use
>   'debian-branch = debian' and 'upstream-branch = master'

Fixed.

> * also, Vcs-Git does not specify the branch (which is kinda optional if
>   you set correctly HEAD on the remote repository, but it wouldn't harm
>   to write it here too)

Fixed.

> * I'm looking partly shocked at the commit
>   6fc1eec66c259cefeeb13453c3ceeb206fb24a55 why did you *substituted* the
>   pristine-tar data?  You should always just add them.

This is just because upstream never tagged a version, nor released a package.
I imported one using 0.0.1 version, but later noticed that 1.0 was set in the 
source and so I renamed the package.
This was before publishing the repository, while doing preliminary package work.
Then I forgot to cleanup the history before publishing it. :-(

> that's just about the git repository.
> 
> review on the package itself:
> * debian/control:
>   + please sort the build-deps with wrap-and-sort or with cme or

Done.

>   + please bump Standards-Version to 3.9.7

Done.

>   + please drop the build-dep on dpkg-dev, that version is old enough
> and dpkg-dev is in build-essential

Ok.

>   + please build-dep on debhelper (>= 9), no need for that ~

Ok.

>   + please drop the version constriction on qt5-qmake, that version is
> old enough

Ok.

> * debian/changelog:
>   + I see there is a weird space between the month and the year, how so?

Manual editing instead of using dch.

> * debian/copyright:
>   + there is a \t at line 9, please just use spaces for consistency.  I
> have a feeling you editor is configured to show a tab as 8 spaces,
> but this is not everybody's configuration, in fact here the line is
> indeed in a weird way.

Fixed (and correct guess about the editor configuration).

>   + please use the license names as specified by DEP-5, so name it
> "BSD-3-clause" and not lowercase

Fixed.

> * debian/msi-keyboard.{post,pre}inst:
>   + what aree these?  Quasi-empty files?

Dropped. I added them while trying to understand how to deal udev files... And 
then forgot about them.
BTW: do you know how to make the udev file work after installation, without 
rebooting the system?

> * debian/patches:
>   + debian/patches/series is empty, please remove the whole directory

Ok.

> Then, here it fails to build:
> 
>debian/rules override_dh_auto_build
> make[1]: Entering directory '/build/msi-keyboard-1.0'
> PATH="`pwd`":"$PATH" help2man msi-keyboard --no-info --name="MSI steelseries 
> keyboard color changer" > debian/msi-keyboard.1
> help2man: can't get `--help' info from msi-keyboard
> Try `--no-discard-stderr' if option outputs to stderr
> debian/rules:12: recipe for target 'override_dh_auto_build' failed
> make[1]: *** [override_dh_auto_build] Error 2
> make[1]: Leaving directory '/build/msi-keyboard-1.0'
> debian/rules:6: recipe for target 'build' failed
> make: *** [build] Error 2
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
> E: Failed autobuilding of package

Fixed. The issue was the build order vs help2man run, as Jakub said.

> I wonder why not just use `help2man ./msi-keyboard ...` instead of
> messing around with PATH (which is probably what went wrong here).

As Jakub pointed out, this is needed to get proper command name in the man page.

Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Jakub Wilk]

* Mattia Rizzolo , 2016-03-19, 12:37:

PATH="`pwd`":"$PATH" help2man msi-keyboard --no-info --name="MSI steelseries keyboard 
color changer" > debian/msi-keyboard.1
help2man: can't get `--help' info from msi-keyboard
Try `--no-discard-stderr' if option outputs to stderr
debian/rules:12: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory '/build/msi-keyboard-1.0'
debian/rules:6: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package


I wonder why not just use `help2man ./msi-keyboard ...` instead of 
messing around with PATH


Fiddling with PATH often necessary when the --help output depends on 
argv[0], which seems to be the case here.



(which is probably what went wrong here).


Nope. The culprit is that debian/rules tries generating the manpage 
before building the executable.


--
Jakub Wilk

Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Mattia Rizzolo]

control: tag -1 moreinfo
control: owner -1 !

On Fri, Feb 05, 2016 at 03:04:19PM +0100, Giulio Paci wrote:
>   I am looking for a sponsor for my package "msi-keyboard":

alright.

>   https://anonscm.debian.org/cgit/collab-maint/msi-keyboard.git

cool!  finally somebody coming here with a git repository!

though:
* I see no tags, I expect to see at least the upstream/* tags (also
  otherwise gbp can be noisy and annoying)
* the HEAD points to master; given that the packaging branch is
  "debian", please configure the remote repository on collab-maint to
  have HEAD point to "debian" instead, so that cloning the repository
  gives you the packaging branch even without specifying it.
* as said you are using a non-standard repository layout, so I expect
  debian/gbp.conf to be explicitly configured to use
  'debian-branch = debian' and 'upstream-branch = master'
* also, Vcs-Git does not specify the branch (which is kinda optional if
  you set correctly HEAD on the remote repository, but it wouldn't harm
  to write it here too)
* I'm looking partly shocked at the commit
  6fc1eec66c259cefeeb13453c3ceeb206fb24a55 why did you *substituted* the
  pristine-tar data?  You should always just add them.


that's just about the git repository.

review on the package itself:
* debian/control:
  + please sort the build-deps with wrap-and-sort or with cme or
  + please bump Standards-Version to 3.9.7
  + please drop the build-dep on dpkg-dev, that version is old enough
and dpkg-dev is in build-essential
  + please build-dep on debhelper (>= 9), no need for that ~
  + please drop the version constriction on qt5-qmake, that version is
old enough
* debian/changelog:
  + I see there is a weird space between the month and the year, how so?
* debian/copyright:
  + there is a \t at line 9, please just use spaces for consistency.  I
have a feeling you editor is configured to show a tab as 8 spaces,
but this is not everybody's configuration, in fact here the line is
indeed in a weird way.
  + please use the license names as specified by DEP-5, so name it
"BSD-3-clause" and not lowercase
* debian/msi-keyboard.{post,pre}inst:
  + what aree these?  Quasi-empty files?
* debian/patches:
  + debian/patches/series is empty, please remove the whole directory


Then, here it fails to build:

   debian/rules override_dh_auto_build
make[1]: Entering directory '/build/msi-keyboard-1.0'
PATH="`pwd`":"$PATH" help2man msi-keyboard --no-info --name="MSI steelseries 
keyboard color changer" > debian/msi-keyboard.1
help2man: can't get `--help' info from msi-keyboard
Try `--no-discard-stderr' if option outputs to stderr
debian/rules:12: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory '/build/msi-keyboard-1.0'
debian/rules:6: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package


I wonder why not just use `help2man ./msi-keyboard ...` instead of
messing around with PATH (which is probably what went wrong here).

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Re: Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Giulio Paci]

Hi Paul,

Il 22/feb/2016 07:52, "Paul Wise"  ha scritto:
>
> On Sun, Feb 21, 2016 at 6:59 PM, Giulio Paci wrote:
>
> > Do you have any suggestions about where to look for sponsor (maybe a
group
> > dedicated to hardware support or laptops or gaming)?
>
> A couple of possibilities:
>
> https
://
lists.debian.org
/
debian-laptop
/

> https
:// 
wiki.debian.org /Games/Team


Thank you!
I started my search on DebianOn wiki page, but did not find these lists (by
reading more carefully, now, I can see the Mobile link there).

Bests,
Giulio

Re: Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Paul Wise]

On Sun, Feb 21, 2016 at 6:59 PM, Giulio Paci wrote:

> Do you have any suggestions about where to look for sponsor (maybe a group
> dedicated to hardware support or laptops or gaming)?

A couple of possibilities:

https://lists.debian.org/debian-laptop/
https://wiki.debian.org/Games/Team

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Re: Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Giulio Paci]

Hi to all,
  I am looking for a sponsor for this package, that is needed to support a
feature (it is possible to change the backlight colors) of the keyboard of
my laptop (MSI GS60).

Is there anybody in this list willing to review/sponsor this package?

Do you have any suggestions about where to look for sponsor (maybe a group
dedicated to hardware support or laptops or gaming)?

Thank you for your help,
Giulio
Il 05/feb/2016 15:06, "Giulio Paci"  ha scritto:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
>   I am looking for a sponsor for my package "msi-keyboard":
>
> * Package name: msi-keyboard
>   Version : 1.0
>   Upstream Author : Brad Parker
> * URL : https://github.com/bparker06/msi-keyboard/
> * License : BSD 3-clause
>   Programming Lang: C++
>   Description : command line tool to change MSI steelseries keyboards
> color setup
>
> It builds this binary package:
>
>   msi-keyboard - command line tool to change MSI steelseries keyboards
> color setup
>
> The sources for the package can be found at:
>
>   https://anonscm.debian.org/cgit/collab-maint/msi-keyboard.git
>
> Regards,
> Giulio Paci
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1
>
> iQIcBAEBCgAGBQJWtKvfAAoJEM7JlC23rbhv+78P/3MdAbfnhgo4j4IQANWjQbHY
> PXs44AKBJ/gaN4E6Hrx5dVoG2lzmYVqJDhnPsajI6gHCVlZX5yge9DhRzeq+VMyQ
> rbJE7Ou3TfOjxl9lumkO0Rh1kJQsoe3hxDqqgfAhr0tREjwTzgPdS/rcnzMldeZF
> Ygbcd+x155dZ1fH9aq0xZXbUcV5O3ROj32b5H6kFGlP9WtvFPkg/Aw1AYNy5+SDF
> cqf8qhBuuVaNdakQ7Q8vrEPbdXO2PF5lKtmz1H8XNHEGGpNyu4jlHrWawR2PAKuC
> arTKKyEAwZGCB67HyK0f/aTiFAbBw0fA/Y/sXzOKvza2sIxkIUYm1wJ9YQi4EbPb
> 0sBd17DIuK9icSd7n0rMoPrtEnX5qsUTYiqgNLsJip5bHpyIMHv9FNZnDh0DEdlt
> vZZCHGE+GPUbqrXFFwAigSD4NRP3nGOgq6yjKkkHZw6GosR942kQfDN7schPgv9l
> pftk6kEkQn3TjniDUa9FFs7ibNFKA1OWKE0GNNiuBZ8P5N7As1FZvvT/CoE7vrbN
> UoKCMYwbaKprvZzZDcPOAuETJoqaO25o620Gga4AlNdk2tih1gAtwzzX/aqa3RQz
> srq3QWwkWbZmY3XQgB11alW6xJHQFl7g6EwWim43E1VZpTppXQLZcVUlX1m5mGuE
> d0OTX5lBOTOnSTVbvhzp
> =7IJc
> -END PGP SIGNATURE-
>
>

Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup

[Giulio Paci]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

  I am looking for a sponsor for my package "msi-keyboard":

* Package name: msi-keyboard
  Version : 1.0
  Upstream Author : Brad Parker
* URL : https://github.com/bparker06/msi-keyboard/
* License : BSD 3-clause
  Programming Lang: C++
  Description : command line tool to change MSI steelseries keyboards color 
setup

It builds this binary package:

  msi-keyboard - command line tool to change MSI steelseries keyboards color 
setup

The sources for the package can be found at:

  https://anonscm.debian.org/cgit/collab-maint/msi-keyboard.git

Regards,
Giulio Paci
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBCgAGBQJWtKvfAAoJEM7JlC23rbhv+78P/3MdAbfnhgo4j4IQANWjQbHY
PXs44AKBJ/gaN4E6Hrx5dVoG2lzmYVqJDhnPsajI6gHCVlZX5yge9DhRzeq+VMyQ
rbJE7Ou3TfOjxl9lumkO0Rh1kJQsoe3hxDqqgfAhr0tREjwTzgPdS/rcnzMldeZF
Ygbcd+x155dZ1fH9aq0xZXbUcV5O3ROj32b5H6kFGlP9WtvFPkg/Aw1AYNy5+SDF
cqf8qhBuuVaNdakQ7Q8vrEPbdXO2PF5lKtmz1H8XNHEGGpNyu4jlHrWawR2PAKuC
arTKKyEAwZGCB67HyK0f/aTiFAbBw0fA/Y/sXzOKvza2sIxkIUYm1wJ9YQi4EbPb
0sBd17DIuK9icSd7n0rMoPrtEnX5qsUTYiqgNLsJip5bHpyIMHv9FNZnDh0DEdlt
vZZCHGE+GPUbqrXFFwAigSD4NRP3nGOgq6yjKkkHZw6GosR942kQfDN7schPgv9l
pftk6kEkQn3TjniDUa9FFs7ibNFKA1OWKE0GNNiuBZ8P5N7As1FZvvT/CoE7vrbN
UoKCMYwbaKprvZzZDcPOAuETJoqaO25o620Gga4AlNdk2tih1gAtwzzX/aqa3RQz
srq3QWwkWbZmY3XQgB11alW6xJHQFl7g6EwWim43E1VZpTppXQLZcVUlX1m5mGuE
d0OTX5lBOTOnSTVbvhzp
=7IJc
-END PGP SIGNATURE-