Bug#860123: RFS: gsignond/1.0.6 [ITP] -- gSSO daemon and default plugins

[Paul Wise]

On Wed, Apr 12, 2017 at 1:05 AM, Corentin Noël wrote:

> https://mentors.debian.net/debian/pool/main/g/gsignond/gsignond_1.0.6.dsc

I don't intend to sponsor this, but here is a quick review:

debian/source/format should be 3.0 (quilt) instead of 3.0 (native) and
the version number should be 1.0.6-1 instead of 1.0.6.

Usually DH_VERBOSE is not set in debian/rules, you might want to
comment that out or remove it.

DEB_CONFIGURE_EXTRA_FLAGS is a cdbs-specific make variable but your
debian/rules doesn't use cdbs, I would suggest removing those lines
and the associated comment from debian/rules.

dh --parallel is the default with debhelper compat 10, I would suggest
you read the debhelper manual page for more information about compat
level 10, remove --parallel from debian/rules and bump debian/compat
to 10. One thing this will do is enabling autoreconf, which should
always be done, even in lower compat levels.

Please remove override_dh_auto_test, all packages should run their
build time tests. If they currently fail on Debian you can run them
but not fail the build.

Why does debian/rules override the upstream location for the configuration file?

debian/README.Debian doesn't look useful, I would suggest removing it.

The maintainer scripts contain a lot of boilerplate comments that can
be removed.

The handling of gsignond.conf in the maintainer scripts looks very
strange, is that needed?

I'm not sure, but I think ldconfig should never be run manually from
maintainer scripts.

I don't think a -dev package is the right place for dbus service definitions?

debian/install should be removed because you have all the other
debian/*.install files.

debian/gsignond-doc.docs looks strange, I'd suggest removing it.

The Vcs-* fields refer to the Debian packaging VCS, not the upstream VCS.

You should use unstable rather than UNRELEASED as the target suite in
debian/changelog.

You should close your ITP in debian/changelog, I'd suggest retitling
the RFP you filed to ITP:

https://bugs.debian.org/831747
https://www.debian.org/Bugs/server-control#retitle

The upstream README.md doesn't contain any information useful to users
of the binary packages, I'd suggest not installing it.

The upstream NEWS file is empty, I'd suggest contacting upstream to
ask them to remove it or put useful information in it. Also, don't
install it in the Debian binary packages.

You might want to setup some tests for ci.debian.net:

https://ci.debian.net/doc/

tools/archive.sh contains some commands for creating tarballs but
hardcodes the version number to 0.0.2, you might want to talk to
usptream about fixing that.

We generally encourage upstreams to not distribute debian/
directories, even in subdirs like dists/debian/

The tests and dbus files hard-code paths in /tmp but they should never
do that, instead they should only ever use random filenames for /tmp/.

Are you sure the package build needs vala? There is only one *.vala
file and it doesn't seem to be touched by the build.

Automatic checks:

build:

gsignond-signonui-data.c:390: Warning: gSignond:
gsignond_signonui_data_set_forgot_password: invalid return annotation
gsignond-signonui-data.c:424: Warning: gSignond:
gsignond_signonui_data_set_forgot_password_url: invalid return
annotation
gsignond-signonui-data.c:793: Warning: gSignond:
gsignond_signonui_data_set_url_response: invalid return annotation
gsignond-utils.c:311: Warning: gSignond: gsignond_variant_to_sequence:
return value: Invalid non-constant return of bare structure or union;
register as boxed type or (skip)
gsignond-utils.c:366: Warning: gSignond: gsignond_array_to_sequence:
return value: Invalid non-constant return of bare structure or union;
register as boxed type or (skip)
gsignond-utils.c:394: Warning: gSignond:
gsignond_copy_array_to_sequence: return value: Invalid non-constant
return of bare structure or union; register as boxed type or (skip)
gsignond-session-data.c:218: Warning: gSignond:
gsignond_session_data_get_allowed_realms: return value: Invalid
non-constant return of bare structure or union; register as boxed type
or (skip)
...
gtkdoc-mkdb --module=gsignond --output-format=xml
--expand-content-files="" --main-sgml-file=gsignond-docs.sgml
${_source_dir} --xml-mode --output-format=xml
../include/gsignond/gsignond.h:41: warning: Section gsignond is not
defined in the gsignond-sections.txt file.
...
gtkdoc-fixxref --module=gsignond --module-dir=html
--html-dir=/usr/share/gtk-doc/html
html/GSignondPlugin.html:154: warning: no link for: 'GStrv' -> (GStrv).
html/GSignondPlugin.html:179: warning: no link for:
'G-SIGNAL-RUN-FIRST:CAPS' -> (Run First).
html/GSignondPlugin.html:247: warning: no link for: 'GObject' ->
(GObject).
html/GSignondPlugin.html:637: warning: no link for: 'GError' -> (GError).
html/GSignondPlugin.html:897: warning: no link for: 'GTypeInterface'
-> (GTypeInterface).
html/GSignondSessionData.html:277: warning: no link for: 'GVariant' ->
(GVariant).
html/GSignondSessionData.html:525: warning: 

Bug#860123: RFS: gsignond/1.0.6 [ITP] -- gSSO daemon and default plugins

[Corentin Noël]

Package: sponsorship-requests
Severity: wishlist

 Dear mentors,

  I am looking for a sponsor for my package "gsignond":

 * Package name: gsignond
   Version : 1.0.6
   Upstream Author : Alexander Kanavin 
 * URL : https://gitlab.com/accounts-sso/gsignond
 * License : LGPL 2.1+
   Section : net

  It builds those binary packages:

gir1.2-gsignond-1.0 - gir bindings for gsignond
gsignond - gSSO daemon and default plugins
gsignond-doc - documentation for gsignond
libgsignond-common-dev - development files for gsignond
libgsignond-common0 - gSSO common library

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/gsignond


  Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/g/gsignond/gsignond_1.0.6.dsc

  More information about gsignond can be obtained from
https://gitlab.com/accounts-sso/gsignond.

  Regards,
  Corentin Noël