Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
On Sun, 24 Feb 2019 17:16:16 +0100 Philipp Meisberger wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "python-rfid" > > * Package name: python-rfid >Version : 1.2 >Upstream Author : Philipp Meisberger > * URL : https://github.com/philippmeisberger/pyrfid.git > * License : D-FSL >Section : python > > It builds those binary packages: > > python-rfid - Python 2 written library for an 125kHz RFID reader > python3-rfid - Python 3 written library for an 125kHz RFID reader The D-FSL[0] license used seems to be the same as the one discussed in the past in debian-legal[1] - 2004. [0] - https://www.hbz-nrw.de/produkte/open-access/lizenzen/dfsl/german-free-software-license [1] - https://lists.debian.org/debian-legal/2004/12/msg00123.html Project: https://github.com/bastianraschke/pyfingerprint/blob/Development/LICENSE There are some incompatible parts/snippets. Although GPL appears in the text. One more link: https://spdx.org/licenses/ Regards, Herbert
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
On Tue, Mar 05, 2019 at 10:34:24PM +0100, Philipp Meisberger wrote: > the doc/RDM6300_doc.pdf is just a datasheet taken from > https://elty.pl/upload/download/RFID/RDM630-Spec.pdf. Should I remove it > since I do not have a build script? Yes, you need to repack the orig tarball to not ship a non-free file. > I prefer having just one repo. But if it is necessary I upload it on salsa. It's not necessary to have the repo on salsa. But it's helpful to have a repo that can be used to build the package. This implies certain things about the file layout and the branch layout which are not true for your repo. You may look at git-buildpackage if you are interested, buyt I suspect you'll need to improve your upstream workflows to be able to use it (starting with moving the actual module source to the top level). Though it looks like it's not even on PyPI? -- WBR, wRAR signature.asc Description: PGP signature
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
Hi, the doc/RDM6300_doc.pdf is just a datasheet taken from https://elty.pl/upload/download/RFID/RDM630-Spec.pdf. Should I remove it since I do not have a build script? Nevertheless the PDF is excluded from Debian package. I prefer having just one repo. But if it is necessary I upload it on salsa. Regards, Philipp Am 28.02.19 um 17:35 schrieb Andrey Rahmatullin: > On Thu, Feb 28, 2019 at 06:24:43PM +0200, Andrius Merkys wrote: >> 1. Please separate the packaging of your project (the src/debian/ >> directory) and place it in a packaging repository on salsa.debian.org. >> This is the usual practice now. > I can't call this "the usual practice". The usual practice is publishing a > repo that allows building a Debian package but we don't require that. The > usual practice is publishing it on salsa but we don't require that either. > As for the repo contents, the usual practice is a branch with upstream > sources merged into a branch with upstream sources + debian. And when you > publish a packaging repo it should be an useful packaging repo and not > just something on salsa. > >> 5. Is doc/RDM6300_doc.pdf your own creation, or taken from somewhere >> else? In the latter case, please take into consideration possible >> licensing restrictions on its usage. > The bigger problem is that the package must also ship the PDF sources and > build scripts. > signature.asc Description: OpenPGP digital signature
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
On 2019-02-28 18:35, Andrey Rahmatullin wrote: > I can't call this "the usual practice". The usual practice is publishing a > repo that allows building a Debian package but we don't require that. The > usual practice is publishing it on salsa but we don't require that either. > As for the repo contents, the usual practice is a branch with upstream > sources merged into a branch with upstream sources + debian. And when you > publish a packaging repo it should be an useful packaging repo and not > just something on salsa. Indeed. I was too quick to summarize here. Best, Andrius -- Andrius Merkys Vilnius University Institute of Biotechnology, Saulėtekio al. 7, room V325 LT-10257 Vilnius, Lithuania signature.asc Description: OpenPGP digital signature
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
On Thu, Feb 28, 2019 at 06:24:43PM +0200, Andrius Merkys wrote: > 1. Please separate the packaging of your project (the src/debian/ > directory) and place it in a packaging repository on salsa.debian.org. > This is the usual practice now. I can't call this "the usual practice". The usual practice is publishing a repo that allows building a Debian package but we don't require that. The usual practice is publishing it on salsa but we don't require that either. As for the repo contents, the usual practice is a branch with upstream sources merged into a branch with upstream sources + debian. And when you publish a packaging repo it should be an useful packaging repo and not just something on salsa. > 5. Is doc/RDM6300_doc.pdf your own creation, or taken from somewhere > else? In the latter case, please take into consideration possible > licensing restrictions on its usage. The bigger problem is that the package must also ship the PDF sources and build scripts. -- WBR, wRAR signature.asc Description: PGP signature
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
Hi Philipp, thanks for fixing the package. Please find my comments below. On 2019-02-28 15:35, Philipp Meisberger wrote: > thanks for your remarks, especially "pybuild". Really simple now. Sure, > removing files from "/usr/local/" was a fix for an ancient previous > version. I removed it. I also tried to fix all Lintian warnings. Great! It seems much cleaner now. > I am > not very familiar with all RFID protocols. So I cannot say EM4100 is > popular or not. I agree, that "python-em4100" would be a better package > name, but I maintain the project since 2014. So if the name changes > there must be at least the virtual package "python-rfid". Understood. Please notice that as "python-rfid" is not in Debian yet, there is no need for virtual packages there. Nevertheless I agree that it's better to have package's name as close to the upstream's name as possible. > I also heard, that Python 2 will be superseded completely by Python 3 > this year. What is your opinion about the Python 2 package? Is it still > necessary? It's true that Python 2 is going away soon. I suggest dropping Python 2 package it in favor for Python 3. Some additional remarks: 1. Please separate the packaging of your project (the src/debian/ directory) and place it in a packaging repository on salsa.debian.org. This is the usual practice now. 2. I see that the debhelper compatibility level and Standards-Version are outdated. Can you bump them to 12 and 4.3.0, accordingly? 3. Your package build-depends on python3. It isn't necessary, as dh-python brings it with itself. 4. Please add ITP bug number to your debian/changelog. 5. Is doc/RDM6300_doc.pdf your own creation, or taken from somewhere else? In the latter case, please take into consideration possible licensing restrictions on its usage. Let me know should you need any help. Andrius -- Andrius Merkys Vilnius University Institute of Biotechnology, Saulėtekio al. 7, room V325 LT-10257 Vilnius, Lithuania signature.asc Description: OpenPGP digital signature
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
Hi Andrius, thanks for your remarks, especially "pybuild". Really simple now. Sure, removing files from "/usr/local/" was a fix for an ancient previous version. I removed it. I also tried to fix all Lintian warnings. I am not very familiar with all RFID protocols. So I cannot say EM4100 is popular or not. I agree, that "python-em4100" would be a better package name, but I maintain the project since 2014. So if the name changes there must be at least the virtual package "python-rfid". I also heard, that Python 2 will be superseded completely by Python 3 this year. What is your opinion about the Python 2 package? Is it still necessary? Best regards, Philipp Am 26.02.19 um 16:26 schrieb Andrius Merkys: > Hi Philipp, > > On Sun, 24 Feb 2019 17:16:16 +0100 Philipp Meisberger > wrote: >> To access further information about this package, please visit the >> following URL: >> >> https://mentors.debian.net/package/python-rfid > > I gave your package a look and wrote some comments on the mentors.d.n > (not sure if you are subscribed to notifications there, thus a ping). > While the package seemingly builds and installs fine, there are some > things that need to be fixed to make your package acceptable in Debian. > > Best wishes, > Andrius > signature.asc Description: OpenPGP digital signature
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
Hi Philipp, On Sun, 24 Feb 2019 17:16:16 +0100 Philipp Meisberger wrote: > To access further information about this package, please visit the > following URL: > > https://mentors.debian.net/package/python-rfid I gave your package a look and wrote some comments on the mentors.d.n (not sure if you are subscribed to notifications there, thus a ping). While the package seemingly builds and installs fine, there are some things that need to be fixed to make your package acceptable in Debian. Best wishes, Andrius -- Andrius Merkys Vilnius University Institute of Biotechnology, Saulėtekio al. 7, room V325 LT-10257 Vilnius, Lithuania
Bug#923162: RFS: python-rfid/1.2 [ITP] -- friendly greeter
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "python-rfid" * Package name: python-rfid Version : 1.2 Upstream Author : Philipp Meisberger * URL : https://github.com/philippmeisberger/pyrfid.git * License : D-FSL Section : python It builds those binary packages: python-rfid - Python 2 written library for an 125kHz RFID reader python3-rfid - Python 3 written library for an 125kHz RFID reader To access further information about this package, please visit the following URL: https://mentors.debian.net/package/python-rfid Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/p/python-rfid/python-rfid_1.2.dsc More information about python-rfid can be obtained from https://github.com/philippmeisberger/pyrfid. Changes since the last upload: * Added support for Python3 (still compatible with Python 2) Regards, Philipp Meisberger signature.asc Description: OpenPGP digital signature
