Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-14 Thread Michal Čihař
Hi

Dne Tue, 12 May 2009 23:26:40 +0800
Vern Sun s5u...@gmail.com napsal(a):

 on 二, 2009-05-12 at 17:02 +0800, Michal Čihař wrote:
  - you should split the library to libcconv0 and rename devel package to
libcconv-dev
  - please write useful description, pointing user to url is not a useful
description
 done
 
  - cconv man page is obviously generated, you should include it's
sources and generate it during build
 I use asciidoc to generate manpage, fixed.
 
  - Vcs-* fields are for debian packaging not for upstream
  - README.Debian is useless
  - why do you install empty file NEWS?
 clear
 
 Reuploaded. The package can be found on mentors.debian.net:
 - URL: http://mentors.debian.net/debian/pool/main/c/cconv
 - Source repository: deb-src http://mentors.debian.net/debian unstable main
   contrib non-free
 - dget http://mentors.debian.net/debian/pool/main/c/cconv/cconv_0.5.2-1.dsc

There are still some things:

- static library and libtool script should go to devel package (*.la,
  *.a)
- are all those versioned build depends really needed?
- I don't think that iconv based is important information which
  should be as first in short description. Either remove it completely
  or move it to the end.
- there is no need for creating postinst for library package
- lintian --pendantic:
P: libcconv0: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
P: cconv: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
P: libcconv-dev: copyright-refers-to-symlink-license 
usr/share/common-licenses/GPL

-- 
Michal Čihař | http://cihar.com | http://blog.cihar.com


signature.asc
Description: PGP signature


Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-14 Thread Vern Sun
on 四, 2009-05-14 at 18:11 +0800, Michal Čihař wrote:
 - are all those versioned build depends really needed?

as you said cconv man page is obviously generated, you should include it's
sources and generate it during build. most of the depends are used for
generate man page. 

 - there is no need for creating postinst for library package

the problem is lintian show error if I deleted the postinst:

  E: libcconv0: postinst-must-call-ldconfig usr/lib/libcconv.so.0.0.0
  N: 
  N:The package installs shared libraries in a directory controlled by the
  N:dynamic library loader. Therefore, the package must call ldconfig in
  N:its postinst script.
  N:
  N:Refer to Debian Policy Manual section 8.1.1 (ldconfig) for details.
  N:
  N:Severity: serious, Certainty: certain

please tell me what I am doing wrong. thanks.

-- 
Vern
2009-05-14


signature.asc
Description: Digital signature


Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-14 Thread Michal Čihař
Hi

Dne Thu, 14 May 2009 19:19:19 +0800
Vern Sun s5u...@gmail.com napsal(a):

 on 四, 2009-05-14 at 18:11 +0800, Michal Čihař wrote:
  - are all those versioned build depends really needed?
 
 as you said cconv man page is obviously generated, you should include it's
 sources and generate it during build. most of the depends are used for
 generate man page. 

I'm talking about versions, not about dependencies.

 
  - there is no need for creating postinst for library package
 
 the problem is lintian show error if I deleted the postinst:
 
   E: libcconv0: postinst-must-call-ldconfig usr/lib/libcconv.so.0.0.0
   N: 
   N:The package installs shared libraries in a directory controlled by the
   N:dynamic library loader. Therefore, the package must call ldconfig in
   N:its postinst script.
   N:
   N:Refer to Debian Policy Manual section 8.1.1 (ldconfig) for details.
   N:
   N:Severity: serious, Certainty: certain
 
 please tell me what I am doing wrong. thanks.

You miss call to dh_makeshlibs. Consider switching to dh, which will do
all jobs for you.

-- 
Michal Čihař | http://cihar.com | http://blog.cihar.com


signature.asc
Description: PGP signature


Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-14 Thread Vern Sun
on 四, 2009-05-14 at 19:54 +0800, Michal Čihař wrote:
 I'm talking about versions, not about dependencies.
 
sorry about my poor english.

 - are all those versioned build depends really needed?

i am not sure about this, but i have removed the versions.

 - static library and libtool script should go to devel package (*.la,
   *.a)

done

 - I don't think that iconv based is important information which
   should be as first in short description. Either remove it completely
   or move it to the end.

completely removed

 - there is no need for creating postinst for library package

fixed

 - lintian --pendantic:
 P: libcconv0: copyright-refers-to-symlink-license 
 usr/share/common-licenses/GPL
 P: cconv: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
 P: libcconv-dev: copyright-refers-to-symlink-license 
 usr/share/common-licenses/GPL

fixed

reuploaded. the package can be found on mentors.debian.net:
- dget http://mentors.debian.net/debian/pool/main/c/cconv/cconv_0.5.2-1.dsc

thanks again.
-- 
Vern
2009-05-14


signature.asc
Description: Digital signature


Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-14 Thread Michal Čihař
Hi

Dne Thu, 14 May 2009 21:09:03 +0800
Vern Sun s5u...@gmail.com napsal(a):

 reuploaded. the package can be found on mentors.debian.net:
 - dget http://mentors.debian.net/debian/pool/main/c/cconv/cconv_0.5.2-1.dsc

Uploaded, thanks.


-- 
Michal Čihař | http://cihar.com | http://blog.cihar.com


signature.asc
Description: PGP signature


RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-12 Thread Vern Sun
Dear mentors,

I am looking for a sponsor for my package cconv.

* Package name: cconv
  Version : 0.5.2-1
  Upstream Author : 杨建禹 httpqu...@sina.com.cn
* URL : http://code.google.com/p/cconv/
* License : GPLv2
  Section : text

It builds these binary packages:
cconv  - iconv based simplified-traditional chinese conversion tool
cconv-dev  - iconv based simplified-traditional chinese conversion tool 
(development files)

This tool is useful to convert all existing Chinese WML files for the Debian
website from Big5 to UTF-8. Examples:
$ echo 内存,海内存知已,後天,皇后 | cconv -f utf-8 -t utf8-tw
記憶體,海內存知已,後天,皇后

The package appears to be lintian clean.

The upload would fix these bugs: 528319.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/c/cconv
- Source repository: deb-src http://mentors.debian.net/debian unstable main 
contrib non-free
- dget http://mentors.debian.net/debian/pool/main/c/cconv/cconv_0.5.2-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards
-- 
Vern
2009-05-12


signature.asc
Description: Digital signature


Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-12 Thread Michal Čihař
Hi

Dne Tue, 12 May 2009 16:21:32 +0800
Vern Sun s5u...@gmail.com napsal(a):

 The package can be found on mentors.debian.net:
 - URL: http://mentors.debian.net/debian/pool/main/c/cconv
 - Source repository: deb-src http://mentors.debian.net/debian unstable main 
 contrib non-free
 - dget http://mentors.debian.net/debian/pool/main/c/cconv/cconv_0.5.2-1.dsc

- you might want to use debhelper 7 features (dh) to simplify
  debian/rules, your package seems to be good candidate to this
- lintian slightly complains:
P: cconv-dev: copyright-refers-to-symlink-license usr/share/common-licenses/GPL 
P: cconv: copyright-refers-to-symlink-license usr/share/common-licenses/GPL 
I: cconv: extended-description-is-probably-too-short
- any reason why library is placed in /usr/lib/cconv?
- you should split the library to libcconv0 and rename devel package to
  libcconv-dev
- please write useful description, pointing user to url is not a useful
  description
- you need to list all copyrights and licenses in debian/copyright
- Vcs-* fields are for debian packaging not for upstream
- -dev package is not a metapackage
- cconv man page is obviously generated, you should include it's
  sources and generate it during build
- README.Debian is useless
- why do you install empty file NEWS?

-- 
Michal Čihař | http://cihar.com | http://blog.cihar.com


signature.asc
Description: PGP signature


Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-12 Thread Paul Wise
On Tue, May 12, 2009 at 4:21 PM, Vern Sun s5u...@gmail.com wrote:

 cconv      - iconv based simplified-traditional chinese conversion tool
 cconv-dev  - iconv based simplified-traditional chinese conversion tool 
 (development files)

 This tool is useful to convert all existing Chinese WML files for the Debian
 website from Big5 to UTF-8. Examples:
 $ echo 内存,海内存知已,後天,皇后 | cconv -f utf-8 -t utf8-tw
 記憶體,海內存知已,後天,皇后

Why isn't iconv capable of doing this? iconv --list contains Big5 here.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-12 Thread LI Daobing
On Tue, May 12, 2009 at 18:12, Paul Wise p...@debian.org wrote:
 On Tue, May 12, 2009 at 4:21 PM, Vern Sun s5u...@gmail.com wrote:

 cconv  - iconv based simplified-traditional chinese conversion tool
 cconv-dev  - iconv based simplified-traditional chinese conversion tool 
 (development files)

 This tool is useful to convert all existing Chinese WML files for the Debian
 website from Big5 to UTF-8. Examples:
 $ echo 内存,海内存知已,後天,皇后 | cconv -f utf-8 -t utf8-tw
 �w,海�却嬷�已,後天,皇后

 Why isn't iconv capable of doing this? iconv --list contains Big5 here.

iconv can't cover this. It sounds like an automatic translation
instead of changing encoding.

i don't know how to explain this, but if you lived in Chinese culture,
you should know it's true.

zh-autoconvert has a similar function like this program.

wikipedia page:
http://en.wikipedia.org/wiki/Traditional_Chinese_characters
http://en.wikipedia.org/wiki/Simplified_Chinese_characters

-- 
Best Regards
LI Daobing


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-12 Thread Paul Wise
2009/5/12 LI Daobing lidaob...@debian.org:

 iconv can't cover this. It sounds like an automatic translation
 instead of changing encoding.

 i don't know how to explain this, but if you lived in Chinese culture,
 you should know it's true.

 zh-autoconvert has a similar function like this program.

 wikipedia page:
 http://en.wikipedia.org/wiki/Traditional_Chinese_characters
 http://en.wikipedia.org/wiki/Simplified_Chinese_characters

Thanks for the explanation, something like this probably would have
been useful in the initial RFS.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool

2009-05-12 Thread Vern Sun
on 二, 2009-05-12 at 17:02 +0800, Michal Čihař wrote:
 - you should split the library to libcconv0 and rename devel package to
   libcconv-dev
 - please write useful description, pointing user to url is not a useful
   description
done

 - cconv man page is obviously generated, you should include it's
   sources and generate it during build
I use asciidoc to generate manpage, fixed.

 - Vcs-* fields are for debian packaging not for upstream
 - README.Debian is useless
 - why do you install empty file NEWS?
clear

Reuploaded. The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/c/cconv
- Source repository: deb-src http://mentors.debian.net/debian unstable main
  contrib non-free
- dget http://mentors.debian.net/debian/pool/main/c/cconv/cconv_0.5.2-1.dsc

Thanks for the review.
-- 
Vern
2009-05-12


signature.asc
Description: Digital signature