Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-16 Thread Bas Wijnen
On Mon, Oct 15, 2007 at 10:20:06AM -0500, Luis Rodrigo Gallardo Cruz wrote: Bas Wijnen [EMAIL PROTECTED] writes: I have just one question about this part: @@ -40,6 +40,7 @@ #include grun2.xpm #if defined (HAVE_GETTEXT) || defined (HAVE_CATGETS) #include libintl.h +#define UTF8

Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-16 Thread Luis Rodrigo Gallardo Cruz
Bas Wijnen [EMAIL PROTECTED] writes: On Mon, Oct 15, 2007 at 10:20:06AM -0500, Luis Rodrigo Gallardo Cruz wrote: Bas Wijnen [EMAIL PROTECTED] writes: Why do you need to #define this? Just because I dislike using magic constants. But looking at the rest of the code, I would just use the

Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-16 Thread Bas Wijnen
On Tue, Oct 16, 2007 at 07:52:33AM -0500, Luis Rodrigo Gallardo Cruz wrote: Bas Wijnen [EMAIL PROTECTED] writes: Is it ok with you if I upload it with a string literal instead of a define? Yes, no problem. Thanks for the review. One more thing, the package failed to build a second time,

Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-16 Thread Luis Rodrigo Gallardo Cruz
On Tue, Oct 16, 2007 at 04:02:28PM +0200, Bas Wijnen wrote: On Tue, Oct 16, 2007 at 07:52:33AM -0500, Luis Rodrigo Gallardo Cruz wrote: Bas Wijnen [EMAIL PROTECTED] writes: Is it ok with you if I upload it with a string literal instead of a define? Yes, no problem. Thanks for the

[Uploaded] Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-16 Thread Bas Wijnen
Hi, I've uploaded the package with those changes to the 7-day delayed queue. Please let me know if there are any problems (I'll subscribe to the PTS, but I don't get the reply e-mails from the upload). Thanks, Bas On Tue, Oct 16, 2007 at 12:21:14PM -0500, Luis Rodrigo Gallardo Cruz wrote: On

Re: [Uploaded] Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-16 Thread Luis Rodrigo Gallardo Cruz
On Tue, Oct 16, 2007 at 09:08:12PM +0200, Bas Wijnen wrote: Hi, I've uploaded the package with those changes to the 7-day delayed queue. Please let me know if there are any problems (I'll subscribe to the PTS, but I don't get the reply e-mails from the upload). Tks. -- Rodrigo Gallardo

Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-15 Thread Bas Wijnen
Hi, On Mon, Sep 24, 2007 at 03:41:27PM -0500, Luis Rodrigo Gallardo Cruz wrote: I am looking for a sponsor for a 7 days delayed NMU of package grun. I was a bit busy, and expected someone else to look at this before me, but appearantly that didn't happen. It seems like a serious problem, so

Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-10-15 Thread Luis Rodrigo Gallardo Cruz
Bas Wijnen [EMAIL PROTECTED] writes: I have just one question about this part: @@ -40,6 +40,7 @@ #include grun2.xpm #if defined (HAVE_GETTEXT) || defined (HAVE_CATGETS) #include libintl.h +#define UTF8 UTF-8 #else #include intl/libintl.h #endif @@ -1107,6 +1108,7 @@ int PASCAL

RFS: grun -- GTK based Run dialog [delayed-7 NMU]

2007-09-24 Thread Luis Rodrigo Gallardo Cruz
Dear mentors, I am looking for a sponsor for a 7 days delayed NMU of package grun. The upload would fix these bugs: 438704 This is a long standing (but recently reported, sadly) bug that has just become grave, because with gtk 2.12 it now results on inmediate segfaults when using grun. The