Bug#658834: marked as done (RFS: jabber-querybot -- Modular xmpp/jabber bot)
Your message dated Tue, 3 Apr 2012 16:33:15 +0200 with message-id 20120403143315.ga7...@mbalmer.nine.ch and subject line Re: RFS: jabber-querybot has caused the Debian Bug report #658834, regarding RFS: jabber-querybot -- Modular xmpp/jabber bot to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 658834: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658834 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package jabber-querybot. * Package name: jabber-querybot Version : 0.1.0-1 Upstream Author : Marco Balmer ma...@balmer.name * URL : https://github.com/micressor/jabber-querybot * License : GPL-3+ Section : net Changes since the last upload: jabber-querybot (0.1.0-1) unstable; urgency=low * New 0.1.0 upstream files * d/dirs: Remove usr/share/jabber-querybot/lib * d/jabber-querybot.install: Removed files which are installed with Makefile.PL * d/preinst: Exec only during upgrade case * d/watch: Update watch file according to new tags -- Marco Balmer ma...@balmer.name Fri, 03 Feb 2012 22:26:46 +0100 It builds those binary packages: jabber-querybot - Modular xmpp/jabber bot To access further information about this package, please visit the following URL: http://mentors.debian.net/package/jabber-querybot Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.1.0-1.dsc I would be glad if someone uploaded this package for me. Kind regards, Marco Balmer ---End Message--- ---BeginMessage--- Thanks for uploading. Marco On Fri, Mar 23, 2012 at 04:20:38PM +0100, Didier Raboud wrote: Le dimanche, 5 février 2012 17.33:31, vous avez écrit : I am looking for a sponsor for my package jabber-querybot. Uploaded. Thanks for your time and patience and sorry for my delay in answering. signature.asc Description: GnuPG Signature ---End Message---
Bug#658834: RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package jabber-querybot. * Package name: jabber-querybot Version : 0.1.0-1 Upstream Author : Marco Balmer ma...@balmer.name * URL : https://github.com/micressor/jabber-querybot * License : GPL-3+ Section : net Changes since the last upload: jabber-querybot (0.1.0-1) unstable; urgency=low * New 0.1.0 upstream files * d/dirs: Remove usr/share/jabber-querybot/lib * d/jabber-querybot.install: Removed files which are installed with Makefile.PL * d/preinst: Exec only during upgrade case * d/watch: Update watch file according to new tags -- Marco Balmer ma...@balmer.name Fri, 03 Feb 2012 22:26:46 +0100 It builds those binary packages: jabber-querybot - Modular xmpp/jabber bot To access further information about this package, please visit the following URL: http://mentors.debian.net/package/jabber-querybot Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.1.0-1.dsc I would be glad if someone uploaded this package for me. Kind regards, Marco Balmer -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120206103322.31393.47245.report...@mbalmer.nine.ch
Bug#658834: RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot
On Mon, Feb 6, 2012 at 6:33 PM, Marco Balmer ma...@balmer.name wrote: RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot This isn't a QA upload since the package is not orphaned. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6eal9rcto7abgpdrmisygm61n3zwocbpz+egaqu87y...@mail.gmail.com
Bug#658834: RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot
retitle 658834 RFS: jabber-querybot -- Modular xmpp/jabber bot thanks On Mon, Feb 06, 2012 at 06:48:28PM +0800, Paul Wise wrote: On Mon, Feb 6, 2012 at 6:33 PM, Marco Balmer ma...@balmer.name wrote: RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot This isn't a QA upload since the package is not orphaned. You're right! -Marco -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120206130535.go18...@mbalmer.nine.ch
Processed: Re: Bug#658834: RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot
Processing commands for cont...@bugs.debian.org: retitle 658834 RFS: jabber-querybot -- Modular xmpp/jabber bot Bug #658834 [sponsorship-requests] RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot Changed Bug title to 'RFS: jabber-querybot -- Modular xmpp/jabber bot' from 'RFS: jabber-querybot [QA] -- Modular xmpp/jabber bot' thanks Stopping processing here. Please contact me if you need assistance. -- 658834: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658834 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.132853384910034.transcr...@bugs.debian.org
RFS: jabber-querybot
Dear mentors, I am looking for a sponsor for my package jabber-querybot. * Package name: jabber-querybot Version : 0.1.0-1 Upstream Author : Marco Balmer ma...@balmer.name * URL : http://github.com/micressor/jabber-querybot * License : GPL-3+ Section : net It builds those binary packages: jabber-querybot - Modular xmpp/jabber bot To access further information about this package, please visit the following URL: http://mentors.debian.net/package/jabber-querybot Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.1.0-1.dsc jabber-querybot (0.1.0-1) unstable; urgency=low * New 0.1.0 upstream files * d/dirs: Remove usr/share/jabber-querybot/lib * d/jabber-querybot.install: Removed files which are installed with Makefile.PL * d/preinst: Exec only during upgrade case * d/watch: Update watch file according to new tags I would be glad if someone uploaded this package for me. Kind regards, Marco Balmer signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
On Wed, 23 Nov 2011 08:06:09 +0100, Marco Balmer wrote: Good point! I changed upstream and built a new version: http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc * d/postinst: removed * File installed to /etc/jabber-querybot Hi Marco, unfortunately, there are things you should change before I can upload: - according to debdiff between the version currently in unstable and this version, you changed the 0.0.4-1 changelog entry; which you should really not (unless there is a good reason; in which case you should mention it in the changelog entry for the to-be-uploaded version) - you have to cleanup after the faulty postinst that reached the archive in jabber-querybot 0.0.4-1 (and I plea guilty for this). If you just drop the postinst without making sure the symlink that it added is properly removed, then it will end up with that situation: $ ls -la /etc/jabber-querybot/ total 12 drwxr-xr-x 2 root root 4096 Nov 23 09:42 . drwxr-xr-x 43 root root 4096 Nov 23 09:37 .. lrwxrwxrwx 1 root root 50 Nov 23 09:38 Querymodule.pm - /usr/share/doc/jabber-querybot/examples/Testbot.pm -rwxr-xr-x 1 root root 2133 Nov 23 06:33 Querymodule.pm.dpkg-new So you probably need a preinst that checks the version you are upgrading from, tests the symlink and removes it in case it still exists. Then, at unpacking phase, the correct Querymodule.pm file will get unpacked at its correct place. Cheers, OdyX -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/65b94463e22662bc604cab826cb22...@raboud.com
Re: RFS: jabber-querybot
On Wed, Nov 23, 2011 at 10:46:42AM +0100, Didier Raboud wrote: unfortunately, there are things you should change before I can upload: - according to debdiff between the version currently in unstable and this version, you changed the 0.0.4-1 changelog entry; which you should really not (unless there is a good reason; in which case you should mention it in the changelog entry for the to-be-uploaded version) I was not able to find the place I changed log entry for 0.0.4-1. How can I show this with debdiff? - you have to cleanup after the faulty postinst that reached the archive in jabber-querybot 0.0.4-1 (and I plea guilty for this). If you just drop the postinst without making sure the symlink that it added is properly removed, then it will end up with that situation: So you probably need a preinst that checks the version you are upgrading from, tests the symlink and removes it in case it still exists. Then, at unpacking phase, the correct Querymodule.pm file will get unpacked at its correct place. I just fixed this and added d/preinst: http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc -- Marco signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
On Wed, 23 Nov 2011 11:52:05 +0100, Marco Balmer wrote:
On Wed, Nov 23, 2011 at 10:46:42AM +0100, Didier Raboud wrote:
unfortunately, there are things you should change before I can
upload:
- according to debdiff between the version currently in unstable and
this version, you changed the 0.0.4-1 changelog entry; which you
should really not (unless there is a good reason; in which case you
should mention it in the changelog entry for the to-be-uploaded
version)
I was not able to find the place I changed log entry for 0.0.4-1.
How can I show this with debdiff?
With something like:
$ apt-get source jabber-querybot/unstable
$ dget -x
http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc
$ debdiff jabber-querybot_0.0.{4,5.1}-1.dsc | grep -A 10
'jabber-querybot (0.0.4-1)'
- you have to cleanup after the faulty postinst that reached the
archive in jabber-querybot 0.0.4-1 (and I plea guilty for this). If
you just drop the postinst without making sure the symlink that it
added is properly removed, then it will end up with that situation:
So you probably need a preinst that checks the version you are
upgrading from, tests the symlink and removes it in case it still
exists. Then, at unpacking phase, the correct Querymodule.pm file
will get unpacked at its correct place.
I just fixed this and added d/preinst:
http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc
Quoting myself extensively in the preinst is not needed. Additionally,
you forgot the checks the version you are upgrading from in the
postinst. The advantage of doing this explicitely is that the code gets
run once for each user and then can be removed in the unstable version
when jabber-querybot reaches stable (as users are mandated to upgrade
from stable to stable releases...). See
http://wiki.debian.org/MaintainerScripts for clear graphs.
IMHO, the check you are doing in the preinst is not sufficient; what if
Random Joe has set up a symlink named
/etc/jabber-querybot/Querymodule.pm that points to his user directory
(for whatever reason)? Then with this preinst, you are not preserving
his changes. So you have to test if the user is both upgrading
(information is in $1) and is doing so from a version smaller than
0.0.5.1-1 (as it's the first version that introduces the fix)
(information is in $2). Then, to be on the safe side, you also have to
check that the symlink you want to remove indeed points to the place you
had setup in the faulty postinst. In that case only you can safely
remove the symlink.
If both this and the changelog issue are fixed properly, then I will
upload. :-
Cheers,
OdyX
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/fb664b215088f59da3604fb77f618...@raboud.com
Re: RFS: jabber-querybot
On Wed, Nov 23, 2011 at 01:57:49PM +0100, Didier Raboud wrote: - according to debdiff between the version currently in unstable and this version, you changed the 0.0.4-1 changelog entry; which you should really not (unless there is a good reason; in which case you should mention it in the changelog entry for the to-be-uploaded version) IMHO, the check you are doing in the preinst is not sufficient; what if Random Joe has set up a symlink named /etc/jabber-querybot/Querymodule.pm that points to his user directory (for whatever reason)? Then with this preinst, you are not preserving his changes. So you have to test if the user is both upgrading (information is in $1) and is doing so from a version smaller than 0.0.5.1-1 (as it's the first version that introduces the fix) (information is in $2). Then, to be on the safe side, you also have to check that the symlink you want to remove indeed points to the place you had setup in the faulty postinst. In that case only you can safely remove the symlink. If both this and the changelog issue are fixed properly, then I will upload. :- Lesson learned! Thx! I hope you are happy with this: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc - d/changelog entry what was changed: Seems to be a handling challange on my side between which version is uploaded/queued/in progress. Fixed now. - d/preinst: Implemented according to your remarks. -- Marco signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
Hi Marco, Marco Balmer wrote: On Wed, Nov 23, 2011 at 01:57:49PM +0100, Didier Raboud wrote: - according to debdiff between the version currently in unstable and this version, you changed the 0.0.4-1 changelog entry; which you should really not (unless there is a good reason; in which case you should mention it in the changelog entry for the to-be-uploaded version) IMHO, the check you are doing in the preinst is not sufficient; what if Random Joe has set up a symlink named /etc/jabber-querybot/Querymodule.pm that points to his user directory (for whatever reason)? Then with this preinst, you are not preserving his changes. So you have to test if the user is both upgrading (information is in $1) and is doing so from a version smaller than 0.0.5.1-1 (as it's the first version that introduces the fix) (information is in $2). Then, to be on the safe side, you also have to check that the symlink you want to remove indeed points to the place you had setup in the faulty postinst. In that case only you can safely remove the symlink. If both this and the changelog issue are fixed properly, then I will upload. :- Lesson learned! Thx! I hope you are happy with this: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc - d/changelog entry what was changed: Seems to be a handling challange on my side between which version is uploaded/queued/in progress. Fixed now. - d/preinst: Implemented according to your remarks. You can use '[ file1 -ef file2 ]' instead of greping the output of 'ls -l' to test if file1 and file2 are linked. Just a suggestion. Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/2023144154.gd2...@marvin.lan
Re: RFS: jabber-querybot
Hi Benoît, On Wed, Nov 23, 2011 at 03:41:55PM +0100, Benoît Knecht wrote: Lesson learned! Thx! I hope you are happy with this: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc - d/changelog entry what was changed: Seems to be a handling challange on my side between which version is uploaded/queued/in progress. Fixed now. - d/preinst: Implemented according to your remarks. You can use '[ file1 -ef file2 ]' instead of greping the output of 'ls -l' to test if file1 and file2 are linked. Just a suggestion. Nice! That's much better. Thank you! -- Marco signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
On Wed, 23 Nov 2011 15:21:38 +0100, Marco Balmer wrote: - d/preinst: Implemented according to your remarks. Almost there! :- == your code == if [ -L /etc/jabber-querybot/Querymodule.pm ] \ [ $1 = upgrade ] \ [ $2 = 0.0.4-1 ]; then if ls -l /etc/jabber-querybot/Querymodule.pm | grep -q \ /usr/share/doc/jabber-querybot/examples/Testbot.pm; then rm /etc/jabber-querybot/Querymodule.pm fi fi == /your code == With your current code, the link type will be tested at each run of the preinst. In fact, your lazy evaluation checks things in reverse order: first the link, then the version, then are we upgrading?; where it's probably more efficient to test things in the reverse order (as the lazy evaluation will stop as soon as possible). Furthermore, you take the output of ls as granted and check its content with grep; that's not very efficient (and error prone; what if I had setup that symlink to /home/me/stuff/usr/share/doc/jabber-querybot/examples/Testbot.pm ?) And the preinst will only work when upgraded from _exactly_ 0.0.4-1; what if jabber-querybot exists (in derivatives, binary rebuilds, etc) in versions bigger than that but still smaller than 0.0.5.1-1 ? For this, dpkg --compare-versions is usually used, as it provides clean = = operators, for this purpose. What about that snippet? (which I wrote with inspiration from my local /var/lib/dpkg/info/*.preinst e.g.) == proposal == case $1 in upgrade) if dpkg --compare-versions $2 lt 0.0.5.1-1; then if [ -L /etc/jabber-querybot/Querymodule.pm ] [ `readlink /etc/jabber-querybot/Querymodule.pm` = /usr/share/doc/jabber-querybot/examples/Testbot.pm ]; then rm /etc/jabber-querybot/Querymodule.pm fi fi ;; esac == /proposal == Cheers, OdyX -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/dc51fddf8ea3de6a9801efe467910...@raboud.com
Re: RFS: jabber-querybot
And now finally taking care of the install step too: this is needed if someones installs jabber-querybot 0.0.4-1, uninstalls it (the symlink doesn't get removed) and then installs 0.0.5.1-1. On Wed, 23 Nov 2011 16:15:51 +0100, Didier Raboud wrote: Or now with the -ef suggestion (way nicer!): On Wed, 23 Nov 2011 16:04:20 +0100, Didier Raboud wrote: What about that snippet? (which I wrote with inspiration from my local /var/lib/dpkg/info/*.preinst e.g.) == proposal 3 == case $1 in upgrade|install) if dpkg --compare-versions $2 lt 0.0.5.1-1; then if [ /etc/jabber-querybot/Querymodule.pm -ef /usr/share/doc/jabber-querybot/examples/Testbot.pm ]; then rm /etc/jabber-querybot/Querymodule.pm fi fi ;; esac == /proposal 3 == -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1c5a009875074f9fa19aa52801f2e...@raboud.com
Re: RFS: jabber-querybot
Didier, On Wed, Nov 23, 2011 at 04:22:06PM +0100, Didier Raboud wrote: And now finally taking care of the install step too: this is needed if someones installs jabber-querybot 0.0.4-1, uninstalls it (the symlink doesn't get removed) and then installs 0.0.5.1-1. On Wed, 23 Nov 2011 16:15:51 +0100, Didier Raboud wrote: Or now with the -ef suggestion (way nicer!): On Wed, 23 Nov 2011 16:04:20 +0100, Didier Raboud wrote: What about that snippet? (which I wrote with inspiration from my local /var/lib/dpkg/info/*.preinst e.g.) == proposal 3 == case $1 in upgrade|install) if dpkg --compare-versions $2 lt 0.0.5.1-1; then if [ /etc/jabber-querybot/Querymodule.pm -ef /usr/share/doc/jabber-querybot/examples/Testbot.pm ]; then rm /etc/jabber-querybot/Querymodule.pm fi fi ;; esac == /proposal 3 == Finaly I implemented your proposal 3. Learned a lot today! Thanks to all. dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc -- Marco signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
Or now with the -ef suggestion (way nicer!): On Wed, 23 Nov 2011 16:04:20 +0100, Didier Raboud wrote: What about that snippet? (which I wrote with inspiration from my local /var/lib/dpkg/info/*.preinst e.g.) == proposal 2 == case $1 in upgrade) if dpkg --compare-versions $2 lt 0.0.5.1-1; then if [ /etc/jabber-querybot/Querymodule.pm -ef /usr/share/doc/jabber-querybot/examples/Testbot.pm ]; then rm /etc/jabber-querybot/Querymodule.pm fi fi ;; esac == /proposal 2 == -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/493ef0271300df90a8930c05eca4c...@raboud.com
Re: RFS: jabber-querybot
Le mercredi, 23 novembre 2011 16.30:11, Marco Balmer a écrit : Finaly I implemented your proposal 3. Learned a lot today! Thanks to all. Uploaded. . -- OdyX signature.asc Description: This is a digitally signed message part.
RFS: jabber-querybot
Dear mentors, I am looking for a sponsor for my package jabber-querybot. * Package name: jabber-querybot Version : 0.0.5-1 Upstream Author : Marco Balmer ma...@balmer.name * URL : https://github.com/micressor/jabber-querybot * License : GPL-3+ Section : net It builds those binary packages: jabber-querybot - Modular xmpp/jabber bot To access further information about this package, please visit the following URL: http://mentors.debian.net/package/jabber-querybot Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5-1.dsc I would be glad if someone uploaded this package for me. Kind regards, -- Marco Balmer signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
* Marco Balmer ma...@balmer.name, 2011-11-22, 13:37: http://mentors.debian.net/package/jabber-querybot Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5-1.dsc I would be glad if someone uploaded this package for me. (I don't intend to sponsor this package.) What is the purpose of the postinst script? It looks like it's violating policy 12.3, 10.7.2 and 10.7.3. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/2022125648.ga...@jwilk.net
Re: RFS: jabber-querybot
Dear Jakub, On Tue, Nov 22, 2011 at 01:56:48PM +0100, Jakub Wilk wrote: * Marco Balmer ma...@balmer.name, 2011-11-22, 13:37: http://mentors.debian.net/package/jabber-querybot Thanks for reviewing. (I don't intend to sponsor this package.) What is the purpose of the postinst script? It looks like it's violating policy 12.3, 10.7.2 and 10.7.3. This package in every case need hands on from the user. The only purpose of postinst is: User get back a correct error message from the package binary instead of a perl compilation error. Do you have a have suggestion? -- Marco Balmer signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
On Tue, Nov 22, 2011 at 01:56:48PM +0100, Jakub Wilk wrote: What is the purpose of the postinst script? It looks like it's violating policy 12.3, 10.7.2 and 10.7.3. Thanks Jakub for the heads'up (given that the postinst is in unstable, you might want to reportbug that…) This package in every case need hands on from the user. The only purpose of postinst is: User get back a correct error message from the package binary instead of a perl compilation error. Do you have a have suggestion? Either: - make sure no error happens if no file exists under /etc/jabber-querybot/, - make sure that the error message is meaningful, - make sure the process is well-documented, - install that file (instead of symlinking) under /etc/jabber-querybot Cheers, -- OdyX -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20221833.13975.o...@debian.org
Re: RFS: jabber-querybot
Dear Didier, Jakub and Mentors, On Tue, Nov 22, 2011 at 06:33:13PM +0100, Didier Raboud wrote: On Tue, Nov 22, 2011 at 01:56:48PM +0100, Jakub Wilk wrote: What is the purpose of the postinst script? It looks like it's violating policy 12.3, 10.7.2 and 10.7.3. Either: - make sure no error happens if no file exists under /etc/jabber-querybot/, - make sure that the error message is meaningful, - make sure the process is well-documented, - install that file (instead of symlinking) under /etc/jabber-querybot Good point! I changed upstream and built a new version: http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.5.1-1.dsc * d/postinst: removed * File installed to /etc/jabber-querybot -- Marco signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
Le mercredi, 9 novembre 2011 14.01:17, Marco Balmer a écrit : Dear mentors, I am looking for a sponsor for my package jabber-querybot. I would be glad if someone uploaded this package for me. Uploaded; thanks for your work! (I'm not sure I would have written the postinst that way, but it looks fine so.) Cheers, -- OdyX signature.asc Description: This is a digitally signed message part.
RFS: jabber-querybot
Dear mentors, I am looking for a sponsor for my package jabber-querybot. * Package name: jabber-querybot Version : 0.0.4-1 Upstream Author : Marco Balmer ma...@balmer.name * URL : https://github.com/micressor/jabber-querybot * License : GPL-3+ Section : net It builds those binary packages: jabber-querybot - Modular xmpp/jabber bot To access further information about this package, please visit the following URL: http://mentors.debian.net/package/jabber-querybot Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.4-1.dsc I would be glad if someone uploaded this package for me. Kind regards, -- Marco Balmer signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
Dear Dider, mentors, On Thu, Oct 20, 2011 at 03:20:09PM +0200, Didier Raboud wrote: Now on for the review: * the debian/copyright file seems to be aspsms-t's . :-) And you should use the versioned shortname for the GPL (e.g. GPL-2+, as in http://dep.debian.net/deps/dep5/#AEN462 ). You can drop the name from the liense paragraph and then copy-paste it to your various debian/copyright files. According to your remarks I fixed: * debian/copyright * debian/changelog * debian/control http://mentors.debian.net/debian/pool/main/j/jabber-querybot/jabber-querybot_0.0.2-1.dsc Thx -Marco signature.asc Description: GnuPG Signature
Re: RFS: jabber-querybot
Le vendredi, 14 octobre 2011 11.40:16, Marco Balmer a écrit : Dear mentors, I am looking for a sponsor for a my new debian package: * Package name: jabber-querybot Hi Marco, and thanks for this new package, indeed probably useful to have in Debian ! Now on for the review: * the debian/copyright file seems to be aspsms-t's . :-) And you should use the versioned shortname for the GPL (e.g. GPL-2+, as in http://dep.debian.net/deps/dep5/#AEN462 ). You can drop the name from the liense paragraph and then copy-paste it to your various debian/copyright files. * I don't find the long description particularly descriptive as it basically tells us Jabber bot framework for Perl (does Perl need Jabber bots ?), from swissjabber (hi there !), now opensource (if it's in Debian (main), it's freesoftware, so this doesn't add much value), simple and nice piece of code (that's entirely subjective). Additionally, the short description is read as jabber-querybot is a Modular xmpp/jabber bot. So is jabber-querybot an actual bot or a framework to write bots? I think a think-trough and rewrite of both descriptions would be good, while keeping [DP§3.4] in mind. * As jabber-querybot was never in Debian, you should merge the initial changelog entries in order to only have one when the package enters NEW. While this is mostly a taste reason, I think it's pretty much common-practice to only have and keep changelog entries for versions that have actually reached the Debian archive. If you do upload those packages to other archives, then it might make sense to name those differently from unstable. And make sure to remind your sponsoree to use the -v option of dpkg-genchanges in order to have the ITP bug referred in the changes file. (So short version of that is: would be good although not necessary if it comes with a nice rationale.) Cheers, OdyX [DP§3.4] http://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions signature.asc Description: This is a digitally signed message part.
RFS: jabber-querybot
Dear mentors, I am looking for a sponsor for a my new debian package: * Package name: jabber-querybot Version : 0.0.1-1 Upstream Author : Marco Balmer ma...@balmer.name * URL : http://github.com/micressor/jabber-querybot * License : GPLv2 Description : Modular xmpp/jabber bot jabber-querybot is a Jabber bot framework for Perl that enables you to easily write simple Jabber bots. . This bot is from swissjabber team and now under opensource license available. . It's a simple concept with a lot of experiences implemented to this nice pice of code. To access further information about this package, please visit the following URL: http://mentors.debian.net/package/jabber-querybot ITP bug is available: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=645266 I would be glad if someone uploaded this package for me. Kind regards, Marco Balmer signature.asc Description: GnuPG Signature
