Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-02-02 Thread Jakub Wilk

* Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-02-01, 18:51:
What does +testing.1 mean? Is that a pre-release thing? If this is 
the case, then use ~ instead of +.

Yes , it is pre-release version .
The upstream had -testting.1 in his version and I had to change this 
to meet the upstream_version requirements .


- is allowed in upstream_version. But please notice that:

0.4.3-1  0.4.3+testing.1-1  0.4.3-testing.1-1

So you'll have a big problem once upstream releases the final 0.4.3. 
That's why you should use ~:


0.4.3~testing.1-1  0.4.3-1

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120202220803.gc8...@jwilk.net



Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-02-02 Thread Alex Mestiashvili
On 02/02/2012 11:08 PM, Jakub Wilk wrote:
 * Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-02-01, 18:51:
 What does +testing.1 mean? Is that a pre-release thing? If this is
 the case, then use ~ instead of +.
 Yes , it is pre-release version .
 The upstream had -testting.1 in his version and I had to change
 this to meet the upstream_version requirements .

 - is allowed in upstream_version. But please notice that:

 0.4.3-1  0.4.3+testing.1-1  0.4.3-testing.1-1

 So you'll have a big problem once upstream releases the final 0.4.3.
 That's why you should use ~:

 0.4.3~testing.1-1  0.4.3-1

I see.Great hint!  thank you ,
Alex


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f2b8e22.20...@biotec.tu-dresden.de



Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-02-01 Thread Alex Mestiashvili
On 02/01/2012 12:42 AM, Jakub Wilk wrote:
 * Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-01-28, 12:09:
 I also modified changelog such a way that line debian/control
 added DM-Upload-Allowed appears in the correct section , but I
 have some doubts if it is ok to edit old changelog sections .
 That's fine with me.

 But please don't change timestamp for the old version.
Ok , good to know .

 (Also, DM-Upload-Allowed: yes used to be the last line in the source
 stanza, is there a reason you moved it?)
No, there is no reason , but will take into account for the next time .

 I've re-uploaded the package with fixed version string :
 http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.3+testing.1-1.dsc


 What does +testing.1 mean? Is that a pre-release thing? If this is
 the case, then use ~ instead of +.

Yes , it is pre-release version .
The upstream had -testting.1 in his version and I had to change this
to meet the upstream_version requirements .
But I wasn't sure which delimiter to use .

Thank you for mentoring and best regards,
Alex


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f297b8e.8090...@biotec.tu-dresden.de



Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-01-31 Thread Jakub Wilk

* Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-01-28, 12:09:
I also modified changelog such a way that line debian/control added 
DM-Upload-Allowed appears in the correct section , but I have some 
doubts if it is ok to edit old changelog sections .

That's fine with me.


But please don't change timestamp for the old version.

(Also, DM-Upload-Allowed: yes used to be the last line in the source 
stanza, is there a reason you moved it?)



I've re-uploaded the package with fixed version string :
http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.3+testing.1-1.dsc


What does +testing.1 mean? Is that a pre-release thing? If this is the 
case, then use ~ instead of +.


--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120131234227.ga4...@jwilk.net



Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-01-28 Thread Alex Mestiashvili

On 01/21/2012 03:02 PM, Alex Mestiashvili wrote:

On 01/20/2012 06:28 PM, Jakub Wilk wrote:

* Alex Mestiashvilia...@biotec.tu-dresden.de, 2012-01-16, 20:16:

http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.2-2.dsc


The changelog says debian/control added DM-Upload-Allowed, but
0.4.2-1 had already this field.

What do you mean by other architectures (in the patch header)?


Hi Jakub ,

It failed to built on many archs -
https://buildd.debian.org/status/package.php?p=libpam-abl
With this patch it suppose to be better , but I agree that the
description sounds ambiguous.
I've uploaded a new version with the corrected description .

Assuming that the patch header was meant to follow DEP-3, then please
note that the Description field is supposed to be like Description in
debian/control: there are two parts, short and long one (though the
latter is optional).

But let's go to more important things. This:

 printf(PAD %s (%lu)\n, buf, (unsigned long)data.size /
sizeof(time_t));

is surely better than:

 printf(PAD %s (%ld)\n, buf, (long int)data.size / sizeof(time_t));

(which you had in the previous version). But to be pedantically
correct, it really should be:

 printf(PAD %s (%zu)\n, buf, (size_t)data.size / sizeof(time_t));


I also modified changelog such a way that line debian/control added
DM-Upload-Allowed appears in the correct section , but I have some
doubts if it is ok to edit old changelog sections .

That's fine with me.


I see , your version is better .
But the upstream has released a new version which fixes this and other
problems .
I hope that shape of the package is good enough .
http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.3-testing.1.dsc

Thank you for taking care ,
Alex




I've re-uploaded the package with fixed version string :
http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.3+testing.1-1.dsc

Regards ,
Alex


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f23d778.80...@biotec.tu-dresden.de



Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-01-21 Thread Alex Mestiashvili
On 01/20/2012 06:28 PM, Jakub Wilk wrote:
 * Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-01-16, 20:16:
 http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.2-2.dsc

 The changelog says debian/control added DM-Upload-Allowed, but
 0.4.2-1 had already this field.

 What do you mean by other architectures (in the patch header)?

 Hi Jakub ,

 It failed to built on many archs -
 https://buildd.debian.org/status/package.php?p=libpam-abl
 With this patch it suppose to be better , but I agree that the
 description sounds ambiguous.
 I've uploaded a new version with the corrected description .

 Assuming that the patch header was meant to follow DEP-3, then please
 note that the Description field is supposed to be like Description in
 debian/control: there are two parts, short and long one (though the
 latter is optional).

 But let's go to more important things. This:

 printf(PAD %s (%lu)\n, buf, (unsigned long)data.size /
 sizeof(time_t));

 is surely better than:

 printf(PAD %s (%ld)\n, buf, (long int)data.size / sizeof(time_t));

 (which you had in the previous version). But to be pedantically
 correct, it really should be:

 printf(PAD %s (%zu)\n, buf, (size_t)data.size / sizeof(time_t));

 I also modified changelog such a way that line debian/control added
 DM-Upload-Allowed appears in the correct section , but I have some
 doubts if it is ok to edit old changelog sections .

 That's fine with me.


I see , your version is better .
But the upstream has released a new version which fixes this and other
problems .
I hope that shape of the package is good enough .
http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.3-testing.1.dsc

Thank you for taking care ,
Alex






-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f1ac577.5000...@biotec.tu-dresden.de



Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-01-20 Thread Jakub Wilk

* Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-01-16, 20:16:

http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.2-2.dsc
The changelog says debian/control added DM-Upload-Allowed, but 
0.4.2-1 had already this field.


What do you mean by other architectures (in the patch header)?


Hi Jakub ,

It failed to built on many archs -
https://buildd.debian.org/status/package.php?p=libpam-abl
With this patch it suppose to be better , but I agree that the 
description sounds ambiguous.

I've uploaded a new version with the corrected description .


Assuming that the patch header was meant to follow DEP-3, then please 
note that the Description field is supposed to be like Description in 
debian/control: there are two parts, short and long one (though the 
latter is optional).


But let's go to more important things. This:

printf(PAD %s (%lu)\n, buf, (unsigned long)data.size / 
sizeof(time_t));

is surely better than:

printf(PAD %s (%ld)\n, buf, (long int)data.size / sizeof(time_t));

(which you had in the previous version). But to be pedantically correct, 
it really should be:


printf(PAD %s (%zu)\n, buf, (size_t)data.size / sizeof(time_t));

I also modified changelog such a way that line debian/control added 
DM-Upload-Allowed appears in the correct section , but I have some 
doubts if it is ok to edit old changelog sections .


That's fine with me.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120120172858.ga8...@jwilk.net



RFS: libpam-abl , bug fix , package is already in Debian

2012-01-16 Thread Alex Mestiashvili
Dear mentors ,
could you please sponsor my package libpam-abl which fixes FTBFS bug #655119

http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.2-2.dsc

Thank you ,
Alex


On 05/07/2011 04:59 PM, Alex Mestiashvili wrote:
 Package name: libpam-abl
 License : GPL 2
 Description : pam_abl blocks hosts which are attempting a brute
 force attack.
  pam_abl is able to protect any service which uses it for authentication.
  It works on the assumption that an attacker won't get the password right
  without a lot of trying. It watches for attacks by counting how many
 times
  a certain user or host tries to log into the service unsuccessfully.
  When a set number of failed logins occurs, the host or user name is
  recorded. After that point, it will be impossible for that user or
  host to successfully log in. The attacker can keep trying as much as
  he wants, but will never find a way to login with his current method.

 Bug #356733 ITP: libpam-abl -- blacklist hosts and users after failed
 authentication attempts

 the package is uploaded to mentors.debian.net

 http://mentors.debian.net/debian/pool/main/l/libpam-abl/

 Thank you in advance ,

 Alex




signature.asc
Description: OpenPGP digital signature


Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-01-16 Thread Jakub Wilk

* Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-01-16, 19:21:

Dear mentors ,
could you please sponsor my package libpam-abl which fixes FTBFS bug #655119

http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.2-2.dsc


The changelog says debian/control added DM-Upload-Allowed, but 0.4.2-1 
had already this field.


What do you mean by other architectures (in the patch header)?

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120116183822.ga3...@jwilk.net



Re: RFS: libpam-abl , bug fix , package is already in Debian

2012-01-16 Thread Alex Mestiashvili
On 01/16/2012 07:38 PM, Jakub Wilk wrote:
 * Alex Mestiashvili a...@biotec.tu-dresden.de, 2012-01-16, 19:21:
 Dear mentors ,
 could you please sponsor my package libpam-abl which fixes FTBFS bug
 #655119

 http://mentors.debian.net/debian/pool/main/libp/libpam-abl/libpam-abl_0.4.2-2.dsc


 The changelog says debian/control added DM-Upload-Allowed, but
 0.4.2-1 had already this field.

 What do you mean by other architectures (in the patch header)?

Hi Jakub ,

It failed to built on many archs -
https://buildd.debian.org/status/package.php?p=libpam-abl
With this patch it suppose to be better , but I agree that the
description sounds ambiguous.
I've uploaded a new version with the corrected description .
I also modified changelog such a way that line debian/control added
DM-Upload-Allowed appears in
the correct section , but I have some doubts if it is ok to edit old
changelog sections .

Best regards ,
Alex


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f14778d.5010...@biotec.tu-dresden.de